Skip to content

Commit 43d6b16

Browse files
committed
fix: use correct dependencies names in emscripten
some have -mt, some have the format name in it, so cover all that cases only use mp3 as music format
1 parent 98d2bbb commit 43d6b16

File tree

2 files changed

+21
-12
lines changed

2 files changed

+21
-12
lines changed

platforms/build-web.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ fi
1919
EMSDK_QUIET=1 source "$EMSCRIPTEN_ROOT/emsdk_env.sh" >/dev/null
2020

2121
## build theneeded dependencies
22-
embuilder build sdl2 harfbuzz freetype zlib sdl2_ttf vorbis mpg123 ogg libmodplug sdl2_mixer libpng libjpeg "sdl2_image:formats=png,jpg,svg" icu
22+
embuilder build sdl2-mt harfbuzz-mt freetype zlib sdl2_ttf mpg123 sdl2_mixer_mp3 libpng-mt libjpeg "sdl2_image:formats=png,jpg,svg" icu-mt
2323

2424
export EMSCRIPTEN_SYS_ROOT="$EMSCRIPTEN_ROOT/upstream/emscripten/cache/sysroot"
2525

@@ -38,7 +38,7 @@ export ENDIANESS="little"
3838

3939
export ROMFS="platforms/romfs"
4040

41-
export PACKAGE_FLAGS="'--use-port=sdl2', '--use-port=harfbuzz', '--use-port=freetype', '--use-port=zlib', '--use-port=sdl2_ttf', '--use-port=vorbis', '--use-port=mpg123', '--use-port=ogg', '--use-port=libmodplug', '--use-port=sdl2_mixer', '-sSDL2_MIXER_FORMATS=[\"ogg\",\"mp3\",\" mod\"]','--use-port=libpng', '--use-port=libjpeg', '--use-port=sdl2_image', '-sSDL2_IMAGE_FORMATS=[\"png\",\"jpg\",\"svg\"]','--use-port=icu'"
41+
export PACKAGE_FLAGS="'--use-port=sdl2', '--use-port=harfbuzz', '--use-port=freetype', '--use-port=zlib', '--use-port=sdl2_ttf', '--use-port=mpg123', '--use-port=sdl2_mixer', '-sSDL2_MIXER_FORMATS=[\"mp3\"]','--use-port=libpng', '--use-port=libjpeg', '--use-port=sdl2_image','-sSDL2_IMAGE_FORMATS=[\"png\",\"jpg\",\"svg\"]', '--use-port=icu'"
4242

4343
export COMMON_FLAGS="'-fexceptions', '-pthread', '-sEXCEPTION_CATCHING_ALLOWED=[..]', $PACKAGE_FLAGS"
4444

tools/dependencies/meson.build

Lines changed: 19 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -48,11 +48,22 @@ if meson.is_cross_build()
4848
only_allow_native_libs = true
4949

5050
## map native libraries to dependencies
51-
map_native_dependencies = ['SDL2-mt', 'SDL2_ttf', 'mpg123', 'SDL2_mixer', 'SDL2_image']
52-
foreach map_native_dependency : map_native_dependencies
53-
native_dep = cpp.find_library(map_native_dependency, required: true)
51+
map_native_dependencies = [
52+
['SDL2-mt', 'SDL2'],
53+
['SDL2_ttf'],
54+
['mpg123'],
55+
['SDL2_mixer_mp3', 'SDL2_mixer'],
56+
['SDL2_image_jpg-png-svg', 'SDL2_image'],
57+
['icu_common-mt', 'icu-uc'],
58+
]
59+
foreach native_dependency_tuple : map_native_dependencies
60+
native_dep_lib_name = native_dependency_tuple[0]
61+
62+
native_dep_name = native_dependency_tuple.length() == 2 ? native_dependency_tuple[1] : native_dep_lib_name
63+
64+
native_dep = cpp.find_library(native_dep_lib_name, required: true)
5465

55-
if map_native_dependency == 'SDL2-mt'
66+
if native_dep_name == 'SDL2'
5667

5768
major_version = cpp.get_define(
5869
'SDL_MAJOR_VERSION',
@@ -89,9 +100,9 @@ if meson.is_cross_build()
89100
+ '.'
90101
+ patch_version,
91102
)
92-
meson.override_dependency('SDL2', native_dep_with_version)
103+
meson.override_dependency(native_dep_name, native_dep_with_version)
93104
else
94-
meson.override_dependency(map_native_dependency, native_dep)
105+
meson.override_dependency(native_dep_name, native_dep)
95106

96107
endif
97108

@@ -105,10 +116,8 @@ if meson.is_cross_build()
105116
'freetype',
106117
'harfbuzz-mt',
107118
'z',
108-
'vorbis',
109-
'ogg',
110-
'modplug',
111-
'png',
119+
'mpg123',
120+
'png-mt',
112121
'jpeg',
113122
'fetch-mt',
114123
]

0 commit comments

Comments
 (0)