fix clang-tidy errors

Author: Totto16

src/game/simulated_tetrion.cpp

@@ -29,6 +29,10 @@ SimulatedTetrion::SimulatedTetrion(
 
 SimulatedTetrion::~SimulatedTetrion() = default;
 
+SimulatedTetrion::SimulatedTetrion(const SimulatedTetrion& other) = default;
+
+SimulatedTetrion::SimulatedTetrion(SimulatedTetrion&& other) noexcept = default;
+
 void SimulatedTetrion::update_step(const SimulationStep simulation_step_index) {
     switch (m_game_state) {
         case GameState::Playing: {
@@ -324,7 +328,7 @@ void SimulatedTetrion::clear_fully_occupied_lines() {
 
 void SimulatedTetrion::lock_active_tetromino(const SimulationStep simulation_step_index) {
     assert(m_active_tetromino.has_value());
-    for (const Mino& mino : m_active_tetromino->minos()) {
+    for (const Mino& mino : m_active_tetromino->minos()) { // NOLINT(bugprone-unchecked-optional-access)
         m_mino_stack.set(mino.position(), mino.type());
     }
     m_allowed_to_hold = true;

src/game/simulated_tetrion.hpp

@@ -58,16 +58,23 @@ struct SimulatedTetrion {
     u64 m_lock_delay_step_index;
 
 protected:
-    MinoStack m_mino_stack;
-    u32 m_level;
-    u32 m_lines_cleared = 0;
-    u64 m_score = 0;
-
-
-    std::optional<Tetromino> m_active_tetromino;
-    std::optional<Tetromino> m_ghost_tetromino;
-    std::optional<Tetromino> m_tetromino_on_hold;
-    std::array<std::optional<Tetromino>, num_preview_tetrominos> m_preview_tetrominos{};
+    MinoStack
+            m_mino_stack; // NOLINT(misc-non-private-member-variables-in-classes,cppcoreguidelines-non-private-member-variables-in-classes)
+    u32 m_level; // NOLINT(misc-non-private-member-variables-in-classes,cppcoreguidelines-non-private-member-variables-in-classes)
+    u32 m_lines_cleared = // NOLINT(misc-non-private-member-variables-in-classes,cppcoreguidelines-non-private-member-variables-in-classes)
+            0;
+    u64 m_score = // NOLINT(misc-non-private-member-variables-in-classes,cppcoreguidelines-non-private-member-variables-in-classes)
+            0;
+
+
+    std::optional<Tetromino>
+            m_active_tetromino; // NOLINT(misc-non-private-member-variables-in-classes,cppcoreguidelines-non-private-member-variables-in-classes)
+    std::optional<Tetromino>
+            m_ghost_tetromino; // NOLINT(misc-non-private-member-variables-in-classes,cppcoreguidelines-non-private-member-variables-in-classes)
+    std::optional<Tetromino>
+            m_tetromino_on_hold; // NOLINT(misc-non-private-member-variables-in-classes,cppcoreguidelines-non-private-member-variables-in-classes)
+    std::array<std::optional<Tetromino>, num_preview_tetrominos>
+            m_preview_tetrominos{}; // NOLINT(misc-non-private-member-variables-in-classes,cppcoreguidelines-non-private-member-variables-in-classes)
 
 private:
     Random m_random;
@@ -79,19 +86,26 @@ struct SimulatedTetrion {
     std::optional<std::shared_ptr<recorder::RecordingWriter>> m_recording_writer;
 
 protected:
-    ServiceProvider* const m_service_provider;
+    ServiceProvider*
+            m_service_provider; // NOLINT(misc-non-private-member-variables-in-classes,cppcoreguidelines-non-private-member-variables-in-classes)
 
 public:
     SimulatedTetrion(
             u8 tetrion_index,
             Random::Seed random_seed,
             u32 starting_level,
-            ServiceProvider* const service_provider,
+            ServiceProvider* service_provider,
             std::optional<std::shared_ptr<recorder::RecordingWriter>> recording_writer
     );
 
     virtual ~SimulatedTetrion();
 
+    SimulatedTetrion(const SimulatedTetrion& other);
+    SimulatedTetrion& operator=(const SimulatedTetrion& other) = delete;
+
+    SimulatedTetrion(SimulatedTetrion&& other) noexcept;
+    SimulatedTetrion& operator=(SimulatedTetrion&& other) noexcept = delete;
+
     void update_step(SimulationStep simulation_step_index);
 
     // returns if the input event lead to a movement
@@ -145,7 +159,7 @@ struct SimulatedTetrion {
 
     [[nodiscard]] u64 get_gravity_delay_frames() const;
 
-    static u8 rotation_to_index(Rotation from, Rotation to);
+    static u8 rotation_to_index(Rotation from, Rotation rotation_to);
 
     static constexpr auto wall_kick_data_jltsz = WallKickTable{
         // North -> East

src/game/simulation.cpp

@@ -5,16 +5,9 @@
 #include "core/helper/expected.hpp"
 #include "input/replay_input.hpp"
 #include "simulation.hpp"
-#include "ui/layout.hpp"
 
 #include <spdlog/spdlog.h>
 
-namespace {
-
-    const auto dummy_layout = ui::AbsolutLayout{ 0, 0, 0, 0 };
-
-}
-
 
 Simulation::Simulation(
         const std::shared_ptr<input::ReplayGameInput>& input,

src/game/tetrion.cpp

@@ -39,7 +39,6 @@ Tetrion::Tetrion(
             1, 3, ui::Direction::Vertical, ui::AbsolutMargin{ 0 }, std::pair<double, double>{ 0.0, 0.1 }
     );
 
-    //TODO:
     auto* text_layout = get_text_layout();
 
     constexpr auto text_size = utils::get_orientation() == utils::Orientation::Landscape

src/game/tetrion.hpp

@@ -37,6 +37,12 @@ struct Tetrion final : public ui::Widget, SimulatedTetrion {
 
     ~Tetrion() override;
 
+    Tetrion(const Tetrion& other) = delete;
+    Tetrion& operator=(const Tetrion& other) = delete;
+
+    Tetrion(Tetrion&& other) noexcept = delete;
+    Tetrion& operator=(Tetrion&& other) noexcept = delete;
+
     void render(const ServiceProvider& service_provider) const override;
     [[nodiscard]] Widget::EventHandleResult
     handle_event(const std::shared_ptr<input::InputManager>& input_manager, const SDL_Event& event) override;

src/input/guid.hpp

@@ -115,8 +115,8 @@ namespace { //NOLINT(cert-dcl59-cpp,google-build-namespaces)
 
 
                 const auto temp_result = single_hex_color_value(
-                        input + offset
-                ); //NOLINT(cppcoreguidelines-pro-bounds-pointer-arithmetic)
+                        input + offset //NOLINT(cppcoreguidelines-pro-bounds-pointer-arithmetic)
+                );
 
                 PROPAGATE(temp_result, sdl::GUID, std::string);
 

tests/utils/helper.hpp

@@ -25,7 +25,7 @@ MATCHER(OptionalHasNoValue, "optional has no value") {
 }
 
 
-#define ASSERT_FAIL(x)                                                                           \
+#define ASSERT_FAIL(x) /*NOLINT(cppcoreguidelines-macro-usage)*/                                 \
     do {                                                                                         \
         std::cerr << "assertion fail in " << __FILE__ << ":" << __LINE__ << ": " << (x) << "\n"; \
         utils::unreachable();                                                                    \