lint: fix clang-tidy warnings

Author: Totto16

src/graphics/window.cpp

@@ -6,11 +6,11 @@
 Window::Window(const std::string& title, WindowPosition position, u32 width, u32 height)
     : Window{ title, static_cast<u32>(position), static_cast<u32>(position), width, height } { }
 
-Window::Window(const std::string& title, u32 x, u32 y, u32 width, u32 height)
+Window::Window(const std::string& title, u32 x_pos, u32 y_pos, u32 width, u32 height)
     : m_window{ SDL_CreateWindow(
               title.c_str(),
-              static_cast<int>(x),
-              static_cast<int>(y),
+              static_cast<int>(x_pos),
+              static_cast<int>(y_pos),
               static_cast<int>(width),
               static_cast<int>(height),
               0
@@ -19,14 +19,14 @@ Window::Window(const std::string& title, u32 x, u32 y, u32 width, u32 height)
 Window::Window(const std::string& title, WindowPosition position)
     : Window{ title, static_cast<u32>(position), static_cast<u32>(position) } { }
 
-Window::Window(const std::string& title, u32 x, u32 y) {
+Window::Window(const std::string& title, u32 x_pos, u32 y_pos) {
 
     SDL_DisplayMode mode{};
     const int result = SDL_GetCurrentDisplayMode(0, &mode);
     if (result != 0) {
         throw std::runtime_error{ "failed in getting display mode: " + std::string{ SDL_GetError() } };
     }
-    m_window = SDL_CreateWindow(title.c_str(), static_cast<int>(x), static_cast<int>(y), mode.w, mode.h, 0);
+    m_window = SDL_CreateWindow(title.c_str(), static_cast<int>(x_pos), static_cast<int>(y_pos), mode.w, mode.h, 0);
     if (m_window == nullptr) {
         throw std::runtime_error{ "failed in creating window: " + std::string{ SDL_GetError() } };
     }

src/graphics/window.hpp

@@ -22,9 +22,9 @@ struct Window final {
 
 public:
     OOPETRIS_GRAPHICS_EXPORTED Window(const std::string& title, WindowPosition position, u32 width, u32 height);
-    OOPETRIS_GRAPHICS_EXPORTED Window(const std::string& title, u32 x, u32 y, u32 width, u32 height);
+    OOPETRIS_GRAPHICS_EXPORTED Window(const std::string& title, u32 x_pos, u32 y_pos, u32 width, u32 height);
     OOPETRIS_GRAPHICS_EXPORTED Window(const std::string& title, WindowPosition position);
-    OOPETRIS_GRAPHICS_EXPORTED Window(const std::string& title, u32 x, u32 y);
+    OOPETRIS_GRAPHICS_EXPORTED Window(const std::string& title, u32 x_pos, u32 y_pos);
     OOPETRIS_GRAPHICS_EXPORTED Window(const Window&) = delete;
     OOPETRIS_GRAPHICS_EXPORTED Window(Window&&) = delete;
     OOPETRIS_GRAPHICS_EXPORTED Window& operator=(const Window&) = delete;

src/libs/core/helper/date.cpp

@@ -23,7 +23,7 @@ date::ISO8601Date::ISO8601Date(std::tm tm) {
 date::ISO8601Date date::ISO8601Date::now() {
     auto now = std::chrono::system_clock::now();
     const std::time_t time = std::chrono::system_clock::to_time_t(now);
-    return { static_cast<u64>(time) };
+    return ISO8601Date{ static_cast<u64>(time) };
 }
 
 

src/libs/core/helper/date.hpp

@@ -18,7 +18,7 @@ namespace date {
         static constexpr const char* iso_8601_format_string = "%Y%m%dT%H%M%S";
 
     public:
-        OOPETRIS_CORE_EXPORTED ISO8601Date(u64 value);
+        OOPETRIS_CORE_EXPORTED explicit ISO8601Date(u64 value);
 
         OOPETRIS_CORE_EXPORTED static ISO8601Date now();
         OOPETRIS_CORE_EXPORTED static helper::expected<ISO8601Date, std::string> from_string(const std::string& input);

src/libs/core/helper/sleep.cpp

@@ -17,7 +17,7 @@ using namespace std::chrono_literals;
 #endif
 
 
-bool helper::sleep_nanoseconds(std::chrono::nanoseconds ns) {
+bool helper::sleep_nanoseconds(std::chrono::nanoseconds nano_seconds) {
 
 #if defined(_MSC_VER)
     // windows supports more than 100 ns precision, see here: https://randomascii.wordpress.com/2020/10/04/windows-timer-resolution-the-great-rule-change/
@@ -30,7 +30,7 @@ bool helper::sleep_nanoseconds(std::chrono::nanoseconds ns) {
         return false;
     }
     // use negative ns to set relative intervals
-    li.QuadPart = -ns.count();
+    li.QuadPart = -nano_seconds.count();
     if (!SetWaitableTimer(timer, &li, 0, nullptr, nullptr, false)) {
         CloseHandle(timer);
         return false;
@@ -46,9 +46,11 @@ bool helper::sleep_nanoseconds(std::chrono::nanoseconds ns) {
     int result{};
     struct timespec remaining{};
     struct timespec current{
-        static_cast<decltype(remaining.tv_sec)>(std::chrono::duration_cast<std::chrono::seconds>(ns).count()),
-        static_cast<decltype(remaining.tv_nsec)>(
-                ns.count() % std::chrono::duration_cast<std::chrono::nanoseconds>(1s).count()
+        .tv_sec = static_cast<decltype(remaining.tv_sec)>(
+                std::chrono::duration_cast<std::chrono::seconds>(nano_seconds).count()
+        ),
+        .tv_nsec = static_cast<decltype(remaining.tv_nsec)>(
+                nano_seconds.count() % std::chrono::duration_cast<std::chrono::nanoseconds>(1s).count()
         ),
     };
 

src/libs/core/helper/sleep.hpp

@@ -8,6 +8,6 @@
 
 namespace helper {
 
-    OOPETRIS_CORE_EXPORTED bool sleep_nanoseconds(std::chrono::nanoseconds ns);
+    OOPETRIS_CORE_EXPORTED bool sleep_nanoseconds(std::chrono::nanoseconds nano_seconds);
 
 }

src/ui/layouts/scroll_layout.hpp

@@ -29,7 +29,7 @@ namespace ui {
     };
 
     struct AbsolutItemSize : public ItemSize {
-        OOPETRIS_GRAPHICS_EXPORTED AbsolutItemSize(u32 height);
+        OOPETRIS_GRAPHICS_EXPORTED explicit AbsolutItemSize(u32 height);
     };