Skip to content

Commit 55675a9

Browse files
committed
fix clang-tidy errors
1 parent 1ea03b3 commit 55675a9

File tree

2 files changed

+11
-6
lines changed

2 files changed

+11
-6
lines changed

src/ui/components/color_picker.cpp

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,7 @@ detail::ColorSlider::ColorSlider(
2828
std::move(setter),
2929
step,
3030
layout,
31-
is_top_level },
32-
m_texture{} {
31+
is_top_level } {
3332

3433
change_layout();
3534

@@ -149,7 +148,10 @@ void detail::ColorCanvas::draw_pseudo_circle(const ServiceProvider& service_prov
149148
}
150149

151150
helper::BoolWrapper<std::pair<ui::EventHandleType, ui::Widget*>>
152-
detail::ColorCanvas::handle_event(const SDL_Event& event, const Window* window) {
151+
detail::ColorCanvas::handle_event( //NOLINT(readability-function-cognitive-complexity)
152+
const SDL_Event& event,
153+
const Window* window
154+
) {
153155
Widget::EventHandleResult handled = false;
154156

155157
const auto fill_rect = layout().get_rect();
@@ -456,7 +458,10 @@ void ui::ColorPicker::render(const ServiceProvider& service_provider) const {
456458
}
457459

458460
helper::BoolWrapper<std::pair<ui::EventHandleType, ui::Widget*>>
459-
ui::ColorPicker::handle_event(const SDL_Event& event, const Window* window) {
461+
ui::ColorPicker::handle_event( //NOLINT(readability-function-cognitive-complexity)
462+
const SDL_Event& event,
463+
const Window* window
464+
) {
460465

461466
auto handled = m_color_slider->handle_event(event, window);
462467

src/ui/components/textinput.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@ ui::TextInput::handle_event( // NOLINT(readability-function-cognitive-complexity
194194
}
195195
case SDLK_c: {
196196
if ((event.key.keysym.mod & KMOD_CTRL) != 0) {
197-
int result = SDL_SetClipboardText(m_text.c_str());
197+
const int result = SDL_SetClipboardText(m_text.c_str());
198198
if (result != 0) {
199199
throw helper::MinorError{
200200
fmt::format("failed in setting the clipboard text: {}", SDL_GetError())
@@ -246,7 +246,7 @@ void ui::TextInput::set_text(const std::string& text) {
246246
return m_text;
247247
}
248248

249-
void ui::TextInput::recalculate_textures(bool text_changed) {
249+
void ui::TextInput::recalculate_textures(bool text_changed) { //NOLINT(readability-function-cognitive-complexity)
250250

251251
const auto& renderer = m_service_provider->renderer();
252252

0 commit comments

Comments
 (0)