fix: catch error in get_api and return a helper::unexpected

also add break to the switch, where I forgot them

Author: Totto16

src/lobby/api.cpp

@@ -63,7 +63,7 @@ lobby::API::API(const std::string& api_url)
             throw std::runtime_error("Couldn't setup authentication");
         }
     } else {
-        spdlog::error("API {}", value.error());
+        spdlog::info("API: Key not found, so probably not logged in already: {}", value.error());
     }
 }
 
@@ -83,17 +83,22 @@ lobby::API::~API() = default;
 
 helper::expected<lobby::API, std::string> lobby::API::get_api(const std::string& url) {
 
-    API api{ url };
+    try {
 
-    const auto reachable = api.check_reachability();
+        API api{ url };
 
-    if (not reachable.has_value()) {
-        return helper::unexpected<std::string>{ reachable.error() };
-    }
+        const auto reachable = api.check_reachability();
+
+        if (not reachable.has_value()) {
+            return helper::unexpected<std::string>{ reachable.error() };
+        }
 
-    //TODO(Totto):  once version is standard, check here if the version is supported
+        //TODO(Totto):  once version is standard, check here if the version is supported
 
-    return api;
+        return api;
+    } catch (const std::exception& err) {
+        return helper::unexpected<std::string>{ err.what() };
+    }
 }
 
 void lobby::API::check_url(const std::string& url, std::function<void(const bool success)>&& callback) {

src/lobby/credentials/secret.cpp

@@ -35,8 +35,10 @@ secret::SecretStorage::SecretStorage(KeyringType type) : m_type{ type } {
     switch (m_type) {
         case secret::KeyringType::User:
             key_type = KEY_SPEC_USER_KEYRING;
+            break;
         case secret::KeyringType::Session:
             key_type = KEY_SPEC_SESSION_KEYRING;
+            break;
         case secret::KeyringType::Persistent: {
             // -1 stands for current uid, 0 stands for: do not create a link to another keyring
             this->m_ring_id = keyctl_get_persistent(-1, 0);