fix: fix the application class, add a default destructor and move functions to cpp

Author: Totto16

src/executables/game/application.cpp

@@ -120,6 +120,8 @@ Application::Application(std::shared_ptr<Window>&& window, CommandLineArguments&
     }
 }
 
+Application::~Application() = default;
+
 #if defined(__EMSCRIPTEN__)
 void c_loop_entry(void* arg) {
     auto application = reinterpret_cast<Application*>(arg);
@@ -624,3 +626,73 @@ void Application::reload_api(const settings::Settings& settings) {
         spdlog::info("No lobby API provided");
     }
 }
+
+
+void Application::push_scene(std::unique_ptr<scenes::Scene> scene) {
+    m_scene_stack.push_back(std::move(scene));
+}
+
+// implementation of ServiceProvider
+[[nodiscard]] EventDispatcher& Application::event_dispatcher() {
+    return m_event_dispatcher;
+}
+
+[[nodiscard]] const EventDispatcher& Application::event_dispatcher() const {
+    return m_event_dispatcher;
+}
+
+FontManager& Application::font_manager() {
+    return *m_font_manager;
+}
+
+[[nodiscard]] const FontManager& Application::font_manager() const {
+    return *m_font_manager;
+}
+
+CommandLineArguments& Application::command_line_arguments() {
+    return m_command_line_arguments;
+}
+
+[[nodiscard]] const CommandLineArguments& Application::command_line_arguments() const {
+    return m_command_line_arguments;
+}
+
+SettingsManager& Application::settings_manager() {
+    return *m_settings_manager;
+}
+
+[[nodiscard]] const SettingsManager& Application::settings_manager() const {
+    return *m_settings_manager;
+}
+
+MusicManager& Application::music_manager() {
+    return *m_music_manager;
+}
+
+[[nodiscard]] const MusicManager& Application::music_manager() const {
+    return *m_music_manager;
+}
+
+[[nodiscard]] const Renderer& Application::renderer() const {
+    return m_renderer;
+}
+
+[[nodiscard]] const Window& Application::window() const {
+    return *m_window;
+}
+
+[[nodiscard]] Window& Application::window() {
+    return *m_window;
+}
+
+[[nodiscard]] input::InputManager& Application::input_manager() {
+    return *m_input_manager;
+}
+
+[[nodiscard]] const input::InputManager& Application::input_manager() const {
+    return *m_input_manager;
+}
+
+[[nodiscard]] const std::unique_ptr<lobby::API>& Application::api() const {
+    return m_api;
+}

src/executables/game/application.hpp

@@ -144,6 +144,8 @@ struct Application final : public EventListener, public ServiceProvider {
     Application(Application&& other) noexcept = delete;
     Application& operator=(Application&& other) noexcept = delete;
 
+    ~Application();
+
     void run();
 
     void handle_event(const SDL_Event& event) override;
@@ -158,76 +160,40 @@ struct Application final : public EventListener, public ServiceProvider {
     void emscripten_do_process();
 #endif
 
-    //TODO(Totto): move those functions bodies to the cpp
-
-    void push_scene(std::unique_ptr<scenes::Scene> scene) {
-        m_scene_stack.push_back(std::move(scene));
-    }
+    void push_scene(std::unique_ptr<scenes::Scene> scene);
 
     // implementation of ServiceProvider
-    [[nodiscard]] EventDispatcher& event_dispatcher() override {
-        return m_event_dispatcher;
-    }
+    [[nodiscard]] EventDispatcher& event_dispatcher() override;
 
-    [[nodiscard]] const EventDispatcher& event_dispatcher() const override {
-        return m_event_dispatcher;
-    }
+    [[nodiscard]] const EventDispatcher& event_dispatcher() const override;
 
-    FontManager& font_manager() override {
-        return *m_font_manager;
-    }
+    FontManager& font_manager() override;
 
-    [[nodiscard]] const FontManager& font_manager() const override {
-        return *m_font_manager;
-    }
+    [[nodiscard]] const FontManager& font_manager() const override;
 
-    CommandLineArguments& command_line_arguments() override {
-        return m_command_line_arguments;
-    }
+    CommandLineArguments& command_line_arguments() override;
 
-    [[nodiscard]] const CommandLineArguments& command_line_arguments() const override {
-        return m_command_line_arguments;
-    }
+    [[nodiscard]] const CommandLineArguments& command_line_arguments() const override;
 
-    SettingsManager& settings_manager() override {
-        return *m_settings_manager;
-    }
+    SettingsManager& settings_manager() override;
 
-    [[nodiscard]] const SettingsManager& settings_manager() const override {
-        return *m_settings_manager;
-    }
+    [[nodiscard]] const SettingsManager& settings_manager() const override;
 
-    MusicManager& music_manager() override {
-        return *m_music_manager;
-    }
+    MusicManager& music_manager() override;
 
-    [[nodiscard]] const MusicManager& music_manager() const override {
-        return *m_music_manager;
-    }
+    [[nodiscard]] const MusicManager& music_manager() const override;
 
-    [[nodiscard]] const Renderer& renderer() const override {
-        return m_renderer;
-    }
+    [[nodiscard]] const Renderer& renderer() const override;
 
-    [[nodiscard]] const Window& window() const override {
-        return *m_window;
-    }
+    [[nodiscard]] const Window& window() const override;
 
-    [[nodiscard]] Window& window() override {
-        return *m_window;
-    }
+    [[nodiscard]] Window& window() override;
 
-    [[nodiscard]] input::InputManager& input_manager() override {
-        return *m_input_manager;
-    }
+    [[nodiscard]] input::InputManager& input_manager() override;
 
-    [[nodiscard]] const input::InputManager& input_manager() const override {
-        return *m_input_manager;
-    }
+    [[nodiscard]] const input::InputManager& input_manager() const override;
 
-    [[nodiscard]] const std::unique_ptr<lobby::API>& api() const override {
-        return m_api;
-    }
+    [[nodiscard]] const std::unique_ptr<lobby::API>& api() const override;
 
 
 #if defined(_HAVE_DISCORD_SDK)