Merge pull request #194 from OpenBrickProtocolFoundation/cpp_httplib_fallback

Support HTTP on every platfom

Author: Totto16

.clang-tidy

@@ -1,6 +1,6 @@
 # taken from https://github.com/cpp-linter/cpp-linter-action/blob/main/demo/.clang-tidy
 ---
-Checks: "clang-diagnostic-*,clang-analyzer-*,bugprone-*,misc-*,performance-*,readability-*,portability-*,modernize-*,cppcoreguidelines-*,google-*,llvm-*,cert-*,-modernize-use-trailing-return-type,-bugprone-argument-comment,-misc-include-cleaner,-cppcoreguidelines-avoid-magic-numbers,-readability-magic-numbers,-readability-avoid-nested-conditional-operator,-llvm-namespace-comment,-llvm-header-guard"
+Checks: "clang-diagnostic-*,clang-analyzer-*,bugprone-*,misc-*,performance-*,readability-*,portability-*,modernize-*,cppcoreguidelines-*,google-*,llvm-*,cert-*,-modernize-use-trailing-return-type,-bugprone-argument-comment,-misc-include-cleaner,-cppcoreguidelines-avoid-magic-numbers,-readability-magic-numbers,-readability-avoid-nested-conditional-operator,-llvm-namespace-comment,-llvm-header-guard,-google-build-explicit-make-pair"
 WarningsAsErrors: ""
 HeaderFilterRegex: "oopetris/src/.*"
 FormatStyle: "file"

.github/workflows/cpp-linter.yml

@@ -51,7 +51,7 @@ jobs:
           tidy-checks: ''
           step-summary: true
           file-annotations: true
-          ignore: subprojects|build|android|assets|recordings|docs|toolchains|platforms|wrapper|src/libs/core/hash-library
+          ignore: subprojects|build|android|assets|recordings|docs|toolchains|platforms|wrapper|src/libs/core/hash-library|src/lobby/curl_client.*
 
       - name: Fail CI run if linter checks failed
         if: steps.linter.outputs.checks-failed != 0

src/helper/graphic_utils.cpp

@@ -11,9 +11,7 @@ std::vector<std::string> utils::supported_features() {
 
     std::vector<std::string> features{};
 
-#if !defined(_ONLINE_MULTIPLAYER_NOT_SUPPORTED)
     features.emplace_back("online multiplayer");
-#endif
 
 #if defined(_HAVE_FILE_DIALOGS)
     features.emplace_back("file dialogs");