clang-tidy, input:

- fix more errors
- remove duplicate call to get_menu_event

Author: Totto16

src/manager/sdl_key.cpp

@@ -396,7 +396,9 @@ helper::expected<sdl::Key, std::string> sdl::Key::from_string(const std::string&
 
     for (const auto& modifier : multiple) {
         const auto sdl_modifier = to_sdl_modifier(modifier);
-        if (((other.m_modifiers & sdl_modifier) & (this->m_modifiers & sdl_modifier)) == 0) {
+        if (((other.m_modifiers & sdl_modifier) & (this->m_modifiers & sdl_modifier) //NOLINT(misc-redundant-expression)
+            )
+            == 0) {
             return false;
         }
     }

src/scenes/single_player_game/single_player_game.cpp

@@ -110,15 +110,17 @@ namespace scenes {
 
         const auto& game_input = m_game->game_input();
 
-        if ((game_input->get_menu_event(event) == input::MenuEvent::Pause
+        const auto& menu_event = game_input->get_menu_event(event);
+
+        if ((menu_event == input::MenuEvent::Pause
              or input_manager->get_navigation_event(event) == input::NavigationEvent::BACK)
             and not m_game->is_game_finished()) {
             m_next_scene = NextScene::Pause;
             m_game->set_paused(true);
             return true;
         }
 
-        if (game_input->get_menu_event(event) == input::MenuEvent::OpenSettings) {
+        if (menu_event == input::MenuEvent::OpenSettings) {
             m_next_scene = NextScene::Settings;
             return true;
         }

src/ui/components/label.hpp

@@ -23,7 +23,7 @@ namespace ui {
         void render(const ServiceProvider& service_provider) const override;
 
         [[nodiscard]] Widget::EventHandleResult
-        handle_event(const std::shared_ptr<input::InputManager>& input_manager, const SDL_Event&) override;
+        handle_event(const std::shared_ptr<input::InputManager>& input_manager, const SDL_Event& /*event*/) override;
 
         void set_text(const ServiceProvider& service_provider, const std::string& text);
     };