Skip to content

Commit 9fc93e3

Browse files
committed
clang-tidy:
- fix more errors
1 parent b8d91d0 commit 9fc93e3

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

src/input/input.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -330,7 +330,7 @@ namespace {
330330
if (auto primary_input = utils::is_child_class<PrimaryInputType>(input); primary_input.has_value()) {
331331
auto result = get_game_input_by_input(service_provider, input);
332332
if (result.has_value()) {
333-
return result.value();
333+
return result;
334334
}
335335
}
336336
}

src/ui/components/textinput.cpp

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,10 @@ void ui::TextInput::render(const ServiceProvider& service_provider) const {
102102
}
103103

104104
helper::BoolWrapper<std::pair<ui::EventHandleType, ui::Widget*>>
105-
ui::TextInput::handle_event(const std::shared_ptr<input::InputManager>& input_manager, const SDL_Event& event) {
105+
ui::TextInput::handle_event( //NOLINT(readability-function-cognitive-complexity)
106+
const std::shared_ptr<input::InputManager>& input_manager,
107+
const SDL_Event& event
108+
) {
106109

107110
//TODO(Totto): if already has focus, position cursor there, where we clicked
108111
if (const auto hover_result = detect_hover(input_manager, event); hover_result) {

tests/core/color.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -256,7 +256,7 @@ TEST(ColorConversion, HSVtoRGBtoHSV) {
256256
}
257257

258258

259-
TEST(ColorConversion, RGG_to_HSV_to_RGB) {
259+
TEST(ColorConversion, RGGtoHSVtoRGB) {
260260

261261
#if COLOR_TEST_MODE == 0
262262
const std::vector<Color> colors{

0 commit comments

Comments
 (0)