utils:

- replace utils::unreachable by macro, that also prints the current line and function, this is not possible with a constexpr function, so a macros has to be used

Author: Totto16

src/discord/core.cpp

@@ -15,7 +15,7 @@
         case ArtAsset::logo:
             return "logo";
         default:
-            utils::unreachable();
+            UNREACHABLE();
     }
 }
 

src/game/graphic_helpers.cpp

@@ -21,7 +21,7 @@ namespace {
             case MinoTransparency::Solid:
                 return utils::to_underlying(transparency);
             default:
-                utils::unreachable();
+                UNREACHABLE();
         }
     }
 } // namespace

src/game/tetrion.cpp

@@ -561,7 +561,7 @@ u8 Tetrion::rotation_to_index(const Rotation from, const Rotation rotation_to) {
     if (from == Rotation::North and rotation_to == Rotation::West) {
         return 7;
     }
-    utils::unreachable();
+    UNREACHABLE();
 }
 
 bool Tetrion::is_tetromino_position_valid(const Tetromino& tetromino) const {
@@ -628,7 +628,7 @@ bool Tetrion::move(const Tetrion::MoveDirection move_direction) {
             return true;
     }
 
-    utils::unreachable();
+    UNREACHABLE();
 }
 
 helper::optional<const Tetrion::WallKickTable*> Tetrion::get_wall_kick_table() const {
@@ -646,6 +646,6 @@ helper::optional<const Tetrion::WallKickTable*> Tetrion::get_wall_kick_table() c
         case helper::TetrominoType::O:
             return {};
         default:
-            utils::unreachable();
+            UNREACHABLE();
     }
 }

src/graphics/texture.cpp

@@ -37,7 +37,7 @@ Texture Texture::prerender_text(
                 font.get(), text.c_str(), text_color, utils::sdl_color_from_color(background_color)
         );
     } else {
-        utils::unreachable();
+        UNREACHABLE();
     }
     if (surface == nullptr) {
         throw std::runtime_error(fmt::format("Failed to pre-render text into surface with error: {}", SDL_GetError()));

src/helper/color.cpp

@@ -153,7 +153,7 @@ namespace {
             return color.to_string(force_alpha);
         }
         default:
-            utils::unreachable();
+            UNREACHABLE();
     }
 }
 

src/helper/color.hpp

@@ -208,7 +208,7 @@ struct Color {
                 d_b = x_offset;
                 break;
             default:
-                utils::unreachable();
+                UNREACHABLE();
         }
 
 

src/helper/utils.hpp

@@ -61,18 +61,10 @@ namespace utils {
 
 #if __cpp_lib_unreachable >= 202202L
     [[noreturn]] inline void unreachable() {
-#if !defined(NDEBUG)
-        std::cerr << "UNREACHABLE\n";
-#endif
-
         std::unreachable();
     }
 #else
     [[noreturn]] inline void unreachable() {
-#if !defined(NDEBUG)
-        std::cerr << "UNREACHABLE\n";
-#endif
-
 #if defined(_MSC_VER) && !defined(__clang__) // MSVC
         __assume(false);
 #else                                        // GCC, Clang
@@ -125,9 +117,20 @@ namespace utils {
 
 } // namespace utils
 
-
 #define UNUSED(x) (void(x)) // NOLINT(cppcoreguidelines-macro-usage)
 
+#if !defined(NDEBUG)
+#define UNREACHABLE() /* NOLINT(cppcoreguidelines-macro-usage)*/                                           \
+    do {                                                                                                   \
+        std::cerr << "UNREACHABLE " << (__FILE__) << ":" << (__LINE__) << " - " << (__FUNCTION__) << "\n"; \
+        utils::unreachable();                                                                              \
+    } while (false)
+#else
+#define UNREACHABLE() utils::unreachable // NOLINT(cppcoreguidelines-macro-usage)
+#endif
+// NOLINT(cppcoreguidelines-macro-usage)
+
+
 #if defined(NDEBUG)
 #define ASSERT(x) (UNUSED(x)) // NOLINT(cppcoreguidelines-macro-usage)
 #else

src/input/controller_input.cpp

@@ -126,7 +126,7 @@ input::ControllerInput::get_by_device_index(int device_index) {
         case NavigationEvent::TAB:
             throw std::runtime_error("Tab is not supported");
         default:
-            utils::unreachable();
+            UNREACHABLE();
     }
 }
 
@@ -234,7 +234,7 @@ input::ControllerGameInput::ControllerGameInput(
         case input::MenuEvent::OpenSettings:
             return m_settings.open_settings.to_string();
         default:
-            utils::unreachable();
+            UNREACHABLE();
     }
     //
 }

src/input/game_input.cpp

@@ -69,7 +69,7 @@ void input::GameInput::handle_event(const InputEvent event, const SimulationStep
         case InputEvent::HoldReleased:
             break;
         default:
-            utils::unreachable();
+            UNREACHABLE();
     }
 }
 

src/input/guid.cpp

@@ -34,6 +34,6 @@ sdl::GUID::GUID(const SDL_GUID& data) : m_guid{} {
             return fmt::format("{:02x}", fmt::join(m_guid, ""));
         }
         default:
-            utils::unreachable();
+            UNREACHABLE();
     }
 }