fix (hopefully) all clang-tidy errors

Author: Totto16

.github/workflows/cpp-linter.yml

@@ -48,7 +48,7 @@ jobs:
           tidy-checks: ""
           step-summary: true
           file-annotations: true
-          ignore: subprojects|build|android|assets|recordings|docs|toolchains|platforms|src/thirdparty
+          ignore: subprojects|build|android|assets|recordings|docs|toolchains|platforms|src/libs/core/hash-library|wrapper/javascript/
 
       - name: Fail CI run if linter checks failed
         if: steps.linter.outputs.checks-failed != 0

src/manager/music_manager.cpp

@@ -20,7 +20,7 @@ MusicManager::MusicManager(ServiceProvider* service_provider, u8 channel_size)
       m_channel_size{ channel_size },
       m_chunk_map{ std::unordered_map<std::string, Mix_Chunk*>{} },
       m_service_provider{ service_provider },
-      volume{ m_service_provider->command_line_arguments().silent ? std::nullopt : std::optional{ 1.0F } } {
+      m_volume{ m_service_provider->command_line_arguments().silent ? std::nullopt : std::optional{ 1.0F } } {
     if (s_instance != nullptr) {
         spdlog::error("it's not allowed to create more than one MusicManager instance");
         return;
@@ -57,7 +57,7 @@ MusicManager::MusicManager(ServiceProvider* service_provider, u8 channel_size)
 
     s_instance = this;
 
-    set_volume(volume, true);
+    set_volume(m_volume, true);
 }
 
 MusicManager::~MusicManager() noexcept {
@@ -95,7 +95,7 @@ std::optional<std::string> MusicManager::load_and_play_music(const std::filesyst
     }
 
     // if we are mute, set the current music to this
-    if (not volume.has_value()) {
+    if (not m_volume.has_value()) {
         assert(m_queued_music == nullptr && "No queued music is possible, when muted!");
         if (m_music != nullptr) {
             Mix_FreeMusic(m_music);
@@ -258,7 +258,7 @@ void MusicManager::set_volume(
         const bool notify_listeners
 ) {
 
-    if (volume == new_volume and not force_update) {
+    if (m_volume == new_volume and not force_update) {
         return;
     }
 
@@ -268,15 +268,15 @@ void MusicManager::set_volume(
             Mix_HaltMusic();
         }
 
-        volume = std::nullopt;
+        m_volume = std::nullopt;
     }
 
 
     const int new_volume_mapped =
             not new_volume.has_value() ? 0 : static_cast<int>(MIX_MAX_VOLUME * new_volume.value());
     Mix_VolumeMusic(new_volume_mapped);
 
-    if (not volume.has_value()) {
+    if (not m_volume.has_value()) {
 
         if (m_music != nullptr) {
             const int result = Mix_PlayMusic(m_music, -1);
@@ -289,10 +289,10 @@ void MusicManager::set_volume(
     }
 
 
-    volume = new_volume;
+    m_volume = new_volume;
     if (notify_listeners) {
-        for (const auto& [_, listener] : volume_listeners) {
-            listener(volume);
+        for (const auto& [_, listener] : m_volume_listeners) {
+            listener(m_volume);
         }
     }
 }

src/manager/music_manager.hpp

@@ -31,8 +31,8 @@ struct MusicManager final {
     static constexpr unsigned fade_ms = 500;
     usize m_delay = MusicManager::fade_ms;
     ServiceProvider* m_service_provider;
-    std::optional<double> volume;
-    std::unordered_map<std::string, VolumeChangeFunction> volume_listeners;
+    std::optional<double> m_volume;
+    std::unordered_map<std::string, VolumeChangeFunction> m_volume_listeners;
 
 public:
     explicit MusicManager(ServiceProvider* service_provider, u8 channel_size = 2);
@@ -58,20 +58,20 @@ struct MusicManager final {
 
     bool add_volume_listener(const std::string& name, VolumeChangeFunction change_function) {
 
-        if (volume_listeners.contains(name)) {
+        if (m_volume_listeners.contains(name)) {
             return false;
         }
 
-        volume_listeners.insert_or_assign(name, std::move(change_function));
+        m_volume_listeners.insert_or_assign(name, std::move(change_function));
         return true;
     }
 
     bool remove_volume_listener(const std::string& name) {
-        if (not volume_listeners.contains(name)) {
+        if (not m_volume_listeners.contains(name)) {
             return false;
         }
 
-        volume_listeners.erase(name);
+        m_volume_listeners.erase(name);
         return true;
     }
 

src/scenes/recording_selector/recording_selector.hpp

@@ -34,7 +34,7 @@ namespace scenes {
     private:
         ui::TileLayout m_main_layout;
         std::optional<details::recording::selector::Command> m_next_command{ std::nullopt };
-        std::vector<std::filesystem::path> m_chosen_paths{};
+        std::vector<std::filesystem::path> m_chosen_paths;
 
     public:
         explicit RecordingSelector(ServiceProvider* service_provider, const ui::Layout& layout);

src/scenes/replay_game/replay_game.hpp

@@ -10,7 +10,7 @@ namespace scenes {
         enum class NextScene : u8 { Pause, Settings };
 
 
-        std::optional<NextScene> m_next_scene{};
+        std::optional<NextScene> m_next_scene;
         std::vector<std::unique_ptr<Game>> m_games;
 
     public:

src/scenes/single_player_game/single_player_game.hpp

@@ -11,7 +11,7 @@ namespace scenes {
         enum class NextScene : u8 { Pause, Settings };
 
 
-        std::optional<NextScene> m_next_scene{};
+        std::optional<NextScene> m_next_scene;
         std::unique_ptr<Game> m_game;
 
     public:

src/ui/layouts/focus_layout.hpp

@@ -26,8 +26,10 @@ namespace ui {
         FocusOptions m_options;
 
     protected:
-        std::optional<u32> m_focus_id{};
-        std::vector<std::unique_ptr<Widget>> m_widgets{};
+        std::optional<u32>
+                m_focus_id; // NOLINT(misc-non-private-member-variables-in-classes,cppcoreguidelines-non-private-member-variables-in-classes)
+        std::vector<std::unique_ptr<Widget>>
+                m_widgets; // NOLINT(misc-non-private-member-variables-in-classes,cppcoreguidelines-non-private-member-variables-in-classes)
 
     public:
         explicit FocusLayout(const Layout& layout, u32 focus_id, FocusOptions options, bool is_top_level);