fix: fix clang-tidy warnings

Author: Totto16

src/discord/core.cpp

@@ -49,11 +49,11 @@ DiscordInstance::DiscordInstance()
 
 
     m_client.SetStatusChangedCallback(
-            [this](discordpp::Client::Status status, discordpp::Client::Error error, int32_t errorDetail) -> void {
+            [this](discordpp::Client::Status status, discordpp::Client::Error error, int32_t error_detail) -> void {
                 if (error != discordpp::Client::Error::None) {
                     this->m_status = DiscordStatus::Error;
                     spdlog::error(
-                            "Connection Error: {} - Details: {}", discordpp::Client::ErrorToString(error), errorDetail
+                            "Connection Error: {} - Details: {}", discordpp::Client::ErrorToString(error), error_detail
                     );
                     return;
                 }
@@ -75,7 +75,7 @@ void DiscordInstance::after_ready() {
 
     this->m_client.GetDiscordClientConnectedUser(
             constants::discord::application_id,
-            [this](discordpp::ClientResult result, std::optional<discordpp::UserHandle> user) -> void {
+            [this](const discordpp::ClientResult& result, std::optional<discordpp::UserHandle> user) -> void {
                 if (result.Successful() and user.has_value()) {
 
                     auto user_handle = m_client.GetUser(user->Id());
@@ -139,15 +139,15 @@ void DiscordInstance::update() {
 
 void DiscordInstance::set_activity(const DiscordActivityWrapper& activity) {
 
-    auto raw_activity = activity.get_raw();
+    const auto& raw_activity = activity.get_raw();
 
     if (not raw_activity.operator bool()) {
         spdlog::error("Tried to set an invalid Discord Activity!");
         return;
     }
 
     // Update rich presence
-    m_client.UpdateRichPresence(raw_activity, [](discordpp::ClientResult result) {
+    m_client.UpdateRichPresence(raw_activity, [](const discordpp::ClientResult& result) {
         if (result.Successful()) {
             spdlog::info("Rich Presence updated successfully");
         } else {

src/discord/core.hpp

@@ -46,7 +46,7 @@ namespace constants::discord {
 
 struct DiscordActivityWrapper {
 private:
-    discordpp::Activity m_activity{};
+    discordpp::Activity m_activity;
 
     [[nodiscard]] discordpp::ActivityTimestamps get_timestamps();
 
@@ -124,7 +124,7 @@ struct DiscordInstance {
 
     OOPETRIS_GRAPHICS_EXPORTED ~DiscordInstance();
 
-    OOPETRIS_GRAPHICS_EXPORTED void update();
+    OOPETRIS_GRAPHICS_EXPORTED static void update();
 
     OOPETRIS_GRAPHICS_EXPORTED void set_activity(const DiscordActivityWrapper& activity);
 

src/executables/game/application.cpp

@@ -382,7 +382,8 @@ void Application::update() {
                                 },
                                 [this](const scenes::Scene::Push& push) {
                                     spdlog::info("pushing back scene {}", magic_enum::enum_name(push.target_scene));
-                                    m_scene_stack.push_back(scenes::create_scene(*this, push.target_scene, push.layout)
+                                    m_scene_stack.push_back(
+                                            scenes::create_scene(*this, push.target_scene, push.layout)
                                     );
                                 },
                                 [this](scenes::Scene::RawPush& raw_push) {
@@ -433,14 +434,13 @@ void Application::update() {
     if (m_discord_instance.has_value()) {
 
         switch (m_discord_instance->get_status()) {
-            case DiscordStatus::Starting:
-                break;
             case DiscordStatus::Error:
                 m_discord_instance = std::nullopt;
                 spdlog::warn("Error initializing the discord instance, it might not be running, destroying client!");
                 break;
+            case DiscordStatus::Starting:
             case DiscordStatus::Ok:
-                m_discord_instance->update();
+                DiscordInstance::update();
                 break;
         }
     }