fix: fix clang-tidy warnings

Author: Totto16

src/executables/game/application.cpp

@@ -42,8 +42,7 @@ Application::Application(std::shared_ptr<Window>&& window, CommandLineArguments&
       m_window{ std::move(window) },
       m_renderer{ *m_window, m_command_line_arguments.target_fps.has_value() ? Renderer::VSync::Disabled
                                                                              : Renderer::VSync::Enabled },
-      m_target_framerate{ m_command_line_arguments.target_fps },
-      m_api{} {
+      m_target_framerate{ m_command_line_arguments.target_fps } {
     initialize();
 } catch (const helper::GeneralError& general_error) {
     const auto severity = general_error.severity();

src/lobby/api.cpp

@@ -96,8 +96,8 @@ helper::expected<lobby::API, std::string> lobby::API::get_api(const std::string&
         //TODO(Totto):  once version is standard, check here if the version is supported
 
         return api;
-    } catch (const std::exception& err) {
-        return helper::unexpected<std::string>{ err.what() };
+    } catch (const std::exception& error) {
+        return helper::unexpected<std::string>{ error.what() };
     }
 }
 

src/lobby/credentials/secret.cpp

@@ -19,7 +19,7 @@ namespace {
 
     key_serial_t get_id_from_name(key_serial_t keyring_id, const std::string& key) {
 
-        std::string full_key = get_key_name(key);
+        const std::string full_key = get_key_name(key);
 
         // 0 stands for: do not create a link to another keyring
         return keyctl_search(keyring_id, constants::key_type_user, full_key.c_str(), 0);
@@ -84,8 +84,11 @@ secret::SecretStorage::~SecretStorage() = default;
         };
     }
 
-    auto result_string = std::string{ static_cast<char*>(buffer), static_cast<char*>(buffer) + result };
-    free(buffer);
+    auto result_string = std::string{
+        static_cast<char*>(buffer),
+        static_cast<char*>(buffer) + result //NOLINT(cppcoreguidelines-pro-bounds-pointer-arithmetic)
+    };
+    free(buffer); // NOLINT(cppcoreguidelines-no-malloc,cppcoreguidelines-owning-memory)
     return result_string;
 }
 

src/manager/settings_manager.cpp

@@ -4,7 +4,7 @@
 #include "input/touch_input.hpp"
 
 namespace {
-    static constexpr auto settings_filename = "settings.json";
+    constexpr const auto settings_filename = "settings.json";
 
 }
 
@@ -47,7 +47,7 @@ void SettingsManager::save() const {
 
     const auto result = json::try_write_json_to_file(settings_file, m_settings, true);
 
-    if (not result.has_value()) {
+    if (result.has_value()) {
         spdlog::error("unable to save settings to \"{}\": {}", settings_filename, result.value());
         return;
     }

src/manager/settings_manager.hpp

@@ -32,5 +32,4 @@ struct SettingsManager {
 
 private:
     void fire_callbacks() const;
-    std::optional<std::string> save_to_file(const std::string& content) const;
 };