Skip to content

Commit c839866

Browse files
committed
windows: fix define magic for static builds
1 parent 0a1bb66 commit c839866

File tree

8 files changed

+26
-11
lines changed

8 files changed

+26
-11
lines changed

src/helper/graphic_utils.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ namespace utils {
3636

3737
// this needs some special handling, so the macro is defined here
3838
#if defined(_MSC_VER)
39-
#if defined(OOPETRIS_LIBRARY_GRAPHICS_EXPORT)
39+
#if defined(OOPETRIS_LIBRARY_GRAPHICS_TYPE) && OOPETRIS_LIBRARY_GRAPHICS_TYPE == 0
4040
#define OOPETRIS_GRAPHICS_EXPORTED_NORETURN __declspec(dllexport, noreturn)
4141
#else
4242
#define OOPETRIS_GRAPHICS_EXPORTED_NORETURN __declspec(dllimport, noreturn)

src/helper/windows.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
#pragma once
22

33
#if defined(_MSC_VER)
4-
#if defined(OOPETRIS_LIBRARY_GRAPHICS_COMPILATION)
4+
#if defined(OOPETRIS_LIBRARY_GRAPHICS_TYPE) && OOPETRIS_LIBRARY_GRAPHICS_TYPE == 0
55
#if defined(OOPETRIS_LIBRARY_GRAPHICS_EXPORT)
66
#define OOPETRIS_GRAPHICS_EXPORTED __declspec(dllexport)
77
#else

src/libs/core/hash-library/sha256.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@ typedef unsigned __int8 uint8_t;
1818
typedef unsigned __int32 uint32_t;
1919
typedef unsigned __int64 uint64_t;
2020

21-
#if defined(HASH_LIBRARY_COMPILATION)
22-
#if defined(HASH_LIBRARY_EXPORT)
21+
#if defined(OOPETRIS_LIBRARY_CORE_TYPE) && OOPETRIS_LIBRARY_CORE_TYPE == 0
22+
#if defined(OOPETRIS_LIBRARY_CORE_EXPORT)
2323
#define HASH_LIBRARY_EXPORTED __declspec(dllexport)
2424
#else
2525
#define HASH_LIBRARY_EXPORTED __declspec(dllimport)

src/libs/core/helper/windows.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
#pragma once
22

33
#if defined(_MSC_VER)
4-
#if defined(OOPETRIS_LIBRARY_CORE_COMPILATION)
4+
#if defined(OOPETRIS_LIBRARY_CORE_TYPE) && OOPETRIS_LIBRARY_CORE_TYPE == 0
55
#if defined(OOPETRIS_LIBRARY_CORE_EXPORT)
66
#define OOPETRIS_CORE_EXPORTED __declspec(dllexport)
77
#else

src/libs/core/meson.build

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,20 @@ subdir('game')
77
subdir('hash-library')
88
subdir('helper')
99

10+
temp = core_lib.get('compile_args')
11+
temp += '-DOOPETRIS_LIBRARY_CORE_TYPE='+ (get_option('default_library') == 'static' ? '1' : '0')
12+
core_lib += {'compile_args': temp}
13+
temp = 0
14+
15+
1016
liboopetris_core = library(
1117
'oopetris_core',
1218
core_src_files,
1319
core_header_files,
1420
include_directories: core_lib.get('inc_dirs'),
1521
dependencies: core_lib.get('deps'),
16-
cpp_args: [core_lib.get('compile_args'),'-DOOPETRIS_LIBRARY_CORE_COMPILATION','-DHASH_LIBRARY_COMPILATION'],
17-
cpp_shared_args: ['-DOOPETRIS_LIBRARY_CORE_EXPORT', '-DHASH_LIBRARY_EXPORT'],
22+
cpp_args: core_lib.get('compile_args'),
23+
cpp_shared_args: ['-DOOPETRIS_LIBRARY_CORE_EXPORT'],
1824
override_options: {
1925
'warning_level': '3',
2026
'werror': true,

src/libs/recordings/meson.build

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,15 @@ recordings_include_dir = include_dir / 'oopetris' / 'recordings'
55

66
subdir('utility')
77

8+
temp = recordings_lib.get('compile_args')
9+
temp += '-DOOPETRIS_LIBRARY_RECORDINGS_TYPE='+ (get_option('default_library') == 'static' ? '1' : '0')
10+
recordings_lib += {'compile_args': temp}
11+
temp = 0
12+
13+
814
recordings_lib += {
915
'deps': [recordings_lib.get('deps'), liboopetris_core_dep],
10-
'inc_dirs': [recordings_lib.get('inc_dirs'), include_directories('.')],
16+
'inc_dirs': [recordings_lib.get('inc_dirs'), include_directories('.')]
1117
}
1218

1319
liboopetris_recordings = library(
@@ -16,7 +22,7 @@ liboopetris_recordings = library(
1622
recordings_header_files,
1723
include_directories: recordings_lib.get('inc_dirs'),
1824
dependencies: recordings_lib.get('deps'),
19-
cpp_args: [recordings_lib.get('compile_args'),'-DOOPETRIS_LIBRARY_RECORDINGS_COMPILATION'],
25+
cpp_args: recordings_lib.get('compile_args'),
2026
cpp_shared_args: ['-DOOPETRIS_LIBRARY_RECORDINGS_EXPORT'],
2127
override_options: {
2228
'warning_level': '3',

src/libs/recordings/utility/windows.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
#pragma once
22

33
#if defined(_MSC_VER)
4-
#if defined(OOPETRIS_LIBRARY_RECORDINGS_COMPILATION)
4+
#if defined(OOPETRIS_LIBRARY_RECORDINGS_TYPE) && OOPETRIS_LIBRARY_RECORDINGS_TYPE == 0
55
#if defined(OOPETRIS_LIBRARY_RECORDINGS_EXPORT)
66
#define OOPETRIS_RECORDINGS_EXPORTED __declspec(dllexport)
77
#else

src/meson.build

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,14 +23,17 @@ if build_application
2323
graphics_lib += {
2424
'deps': [graphics_lib.get('deps'), liboopetris_recordings_dep],
2525
'inc_dirs': [graphics_lib.get('inc_dirs'), include_directories('.')],
26+
'compile_args' : [graphics_lib.get('compile_args'),
27+
'-DOOPETRIS_LIBRARY_GRAPHICS_TYPE='+
28+
(get_option('default_library') == 'static' ? '1' : '0')]
2629
}
2730

2831
liboopetris_graphics = library(
2932
'oopetris_graphics',
3033
graphics_src_files,
3134
include_directories: graphics_lib.get('inc_dirs'),
3235
dependencies: graphics_lib.get('deps'),
33-
cpp_args: [graphics_lib.get('compile_args'),'-DOOPETRIS_LIBRARY_GRAPHICS_COMPILATION'],
36+
cpp_args: graphics_lib.get('compile_args'),
3437
cpp_shared_args: ['-DOOPETRIS_LIBRARY_GRAPHICS_EXPORT'],
3538
override_options: {
3639
'warning_level': '3',

0 commit comments

Comments
 (0)