fix: fix many clang tidy errors (8/x)

this is part 8 of 143 errors in the whole codebase, it is split into multiple commits, so that each patch is not to big

Author: Totto16

src/libs/core/helper/expected.hpp

@@ -12,17 +12,17 @@ namespace helper {
 
 #ifdef _USE_TL_EXPECTED
     template<typename S, typename T>
-    using expected = tl::expected<S, T>;
+    using expected = tl::expected<S, T>; //NOLINT(readability-identifier-naming)
 
     template<typename T>
-    using unexpected = tl::unexpected<T>;
+    using unexpected = tl::unexpected<T>; //NOLINT(readability-identifier-naming)
 
 #else
     template<typename S, typename T>
-    using expected = std::expected<S, T>;
+    using expected = std::expected<S, T>; //NOLINT(readability-identifier-naming)
 
     template<typename T>
-    using unexpected = std::unexpected<T>;
+    using unexpected = std::unexpected<T>; //NOLINT(readability-identifier-naming)
 
 #endif
 

src/libs/core/helper/static_string.hpp

@@ -17,7 +17,8 @@ struct StaticString {
     constexpr StaticString() : m_data{} { }
 
 public:
-    constexpr StaticString(const char (&chars // NOLINT(modernize-avoid-c-arrays,cppcoreguidelines-avoid-c-arrays)
+    constexpr explicit StaticString(const char( // NOLINT(modernize-avoid-c-arrays,cppcoreguidelines-avoid-c-arrays)
+            &chars
     )[DataSize]) {
         std::copy(chars, chars + DataSize, begin());
     }

src/libs/core/helper/types.hpp

@@ -3,14 +3,14 @@
 #include <cstdint>
 #include <cstdlib>
 
-using usize = std::size_t;
-using u8 = std::uint8_t;
-using u16 = std::uint16_t;
-using u32 = std::uint32_t;
-using u64 = std::uint64_t;
-using i8 = std::int8_t;
-using i16 = std::int16_t;
-using i32 = std::int32_t;
-using i64 = std::int64_t;
+using usize = std::size_t; //NOLINT(readability-identifier-naming)
+using u8 = std::uint8_t;   //NOLINT(readability-identifier-naming)
+using u16 = std::uint16_t; //NOLINT(readability-identifier-naming)
+using u32 = std::uint32_t; //NOLINT(readability-identifier-naming)
+using u64 = std::uint64_t; //NOLINT(readability-identifier-naming)
+using i8 = std::int8_t;    //NOLINT(readability-identifier-naming)
+using i16 = std::int16_t;  //NOLINT(readability-identifier-naming)
+using i32 = std::int32_t;  //NOLINT(readability-identifier-naming)
+using i64 = std::int64_t;  //NOLINT(readability-identifier-naming)
 
 using SimulationStep = u64;

src/manager/event_dispatcher.hpp

@@ -85,7 +85,7 @@ struct EventDispatcher final {
         }
 
         if (rect.has_value()) {
-            SDL_Rect sdl_rect = rect.value().to_sdl_rect();
+            const SDL_Rect sdl_rect = rect.value().to_sdl_rect();
             SDL_SetTextInputRect(&sdl_rect);
         }
 

src/manager/font.hpp

@@ -9,13 +9,13 @@
 
 struct FontLoadingError final : public std::exception {
 private:
-    std::string message;
+    std::string m_message;
 
 public:
-    OOPETRIS_GRAPHICS_EXPORTED explicit FontLoadingError(std::string message) : message{ std::move(message) } { }
+    OOPETRIS_GRAPHICS_EXPORTED explicit FontLoadingError(std::string message) : m_message{ std::move(message) } { }
 
     [[nodiscard]] const char* what() const noexcept override {
-        return message.c_str();
+        return m_message.c_str();
     }
 };
 

src/manager/music_manager.cpp

@@ -20,10 +20,10 @@ MusicManager::MusicManager(ServiceProvider* service_provider, u8 channel_size)
       m_channel_size{ channel_size },
       m_chunk_map{ std::unordered_map<std::string, Mix_Chunk*>{} },
       m_volume{ service_provider->command_line_arguments().silent ? std::nullopt : std::optional{ 1.0F } } {
-    if (s_instance != nullptr) {
+    if (m_s_instance != nullptr) {
         spdlog::error(
                 "it's not allowed to create more than one MusicManager instance: {} != {}",
-                static_cast<void*>(s_instance), static_cast<void*>(this)
+                static_cast<void*>(m_s_instance), static_cast<void*>(this)
         );
         return;
     }
@@ -65,7 +65,7 @@ MusicManager::MusicManager(ServiceProvider* service_provider, u8 channel_size)
         throw helper::InitializationError{ fmt::format("Failed to open an audio device: {}", SDL_GetError()) };
     }
 
-    s_instance = this;
+    m_s_instance = this;
 
     set_volume(m_volume, true);
 }
@@ -97,7 +97,7 @@ MusicManager::~MusicManager() noexcept {
     Mix_CloseAudio();
     Mix_Quit();
 
-    s_instance = nullptr;
+    m_s_instance = nullptr;
 }
 
 std::optional<std::string> MusicManager::load_and_play_music(const std::filesystem::path& location, const usize delay) {
@@ -159,11 +159,11 @@ std::optional<std::string> MusicManager::load_and_play_music(const std::filesyst
         m_delay = delay;
         Mix_HookMusicFinished([]() {
             // this can happen on e.g. android, where if we exit the application, we don't close the window, so its reused, but the music manager is destroyed, but the hook is called later xD
-            /* if (s_instance == nullptr) {
+            /* if (m_s_instance == nullptr) {
                 return;
             } */
 
-            s_instance->hook_music_finished();
+            m_s_instance->hook_music_finished();
         });
 
         // this wasn't block, so we have to wait for the callback to be called
@@ -252,10 +252,10 @@ void MusicManager::hook_music_finished() {
 }
 
 [[nodiscard]] bool MusicManager::validate_instance() {
-    if (s_instance != this) {
+    if (m_s_instance != this) {
         spdlog::error(
                 "this MusicManager instance is not the instance that is used globally: {} != {}",
-                static_cast<void*>(s_instance), static_cast<void*>(this)
+                static_cast<void*>(m_s_instance), static_cast<void*>(this)
         );
         return false;
     }

src/manager/music_manager.hpp

@@ -20,7 +20,7 @@
 
 struct MusicManager final {
 private:
-    static inline MusicManager* s_instance{ nullptr }; // NOLINT(cppcoreguidelines-avoid-non-const-global-variables)
+    static inline MusicManager* m_s_instance{ nullptr }; // NOLINT(cppcoreguidelines-avoid-non-const-global-variables)
     static const constexpr double step_width = 0.05F;
 
     using VolumeChangeFunction = std::function<void(std::optional<double> volume)>;