Fix item_url bad query detection

akariv · akariv · commit 4dea48f13f19 · 2025-04-20T19:09:13.000+03:00
diff --git a/budgetkey_api/modules/simpledb.py b/budgetkey_api/modules/simpledb.py
@@ -42,7 +42,7 @@ def check_for_common_errors(table, sql):
                 'item multiple times. Use an exact match instead, e.g. "code = 12.34.56" or filter the query using the '
                 '`level` field.'
             )
-        group_by_item_url = re.search(r'group by .+ item_url', sql, re.I | re.M | re.S | re.U)
+        group_by_item_url = re.search(r'group by.+item_url', sql, re.I | re.M | re.S | re.U)
         if group_by_item_url:
             ret.append(
                 'Using "GROUP BY" with "item_url" may lead to unwanted results.'

Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ def check_for_common_errors(table, sql):`
`42`	`42`	`'item multiple times. Use an exact match instead, e.g. "code = 12.34.56" or filter the query using the '`
`43`	`43`	'`level` field.'
`44`	`44`	`)`
`45`		`- group_by_item_url = re.search(r'group by .+ item_url', sql, re.I \| re.M \| re.S \| re.U)`
	`45`	`+ group_by_item_url = re.search(r'group by.+item_url', sql, re.I \| re.M \| re.S \| re.U)`
`46`	`46`	`if group_by_item_url:`
`47`	`47`	`ret.append(`
`48`	`48`	`'Using "GROUP BY" with "item_url" may lead to unwanted results.'`