Fix clippy warnings

Author: OpenByteDev

src/error/hosting_result.rs

@@ -1,5 +1,5 @@
 use std::convert::TryFrom;
-#[cfg(any(nightly, feature = "nightly"))]
+#[cfg(feature = "nightly")]
 use std::ops::{ControlFlow, FromResidual, Try};
 
 use crate::bindings;
@@ -116,7 +116,7 @@ impl From<HostingError> for HostingResult {
     }
 }
 
-#[cfg(any(nightly, feature = "nightly"))]
+#[cfg(feature = "nightly")]
 impl Try for HostingResult {
     type Output = HostingSuccess;
     type Residual = HostingError;
@@ -131,7 +131,7 @@ impl Try for HostingResult {
     }
 }
 
-#[cfg(any(nightly, feature = "nightly"))]
+#[cfg(feature = "nightly")]
 impl FromResidual for HostingResult {
     fn from_residual(r: HostingError) -> Self {
         HostingResult(Err(r))

src/nethost.rs

@@ -112,20 +112,20 @@ pub enum LoadHostfxrError {
 }
 
 const unsafe fn maybe_uninit_slice_assume_init_ref<T>(slice: &[MaybeUninit<T>]) -> &[T] {
-    #[cfg(any(nightly, feature = "nightly"))]
+    #[cfg(feature = "nightly")]
     unsafe {
         MaybeUninit::slice_assume_init_ref(slice)
     }
-    #[cfg(not(any(nightly, feature = "nightly")))]
+    #[cfg(not(feature = "nightly"))]
     unsafe {
-        &*(slice as *const [MaybeUninit<T>] as *const [T])
+        &*(std::ptr::from_ref::<[MaybeUninit<T>]>(slice) as *const [T])
     }
 }
 
 fn maybe_uninit_uninit_array<T, const LEN: usize>() -> [MaybeUninit<T>; LEN] {
-    #[cfg(any(nightly, feature = "nightly"))]
+    #[cfg(feature = "nightly")]
     return MaybeUninit::<T>::uninit_array::<LEN>();
-    #[cfg(not(any(nightly, feature = "nightly")))]
+    #[cfg(not(feature = "nightly"))]
     unsafe {
         MaybeUninit::<[MaybeUninit<T>; LEN]>::uninit().assume_init()
     }

src/pdcstring/impl/traits.rs

@@ -36,4 +36,5 @@ pub(crate) trait ToStringErrorInner: Debug + Display + Error + Clone {
     fn index(&self) -> Option<usize>;
 }
 
+#[allow(dead_code)]
 pub(crate) trait MissingNulTerminatorInner: Debug + Display + Error + Clone {}

src/pdcstring/shared.rs

@@ -67,13 +67,13 @@ impl PdCStr {
     pub(crate) fn from_inner(inner: &PdCStrInnerImpl) -> &Self {
         // Safety:
         // Safe because PdCStr has the same layout as PdCStrInnerImpl
-        unsafe { &*(inner as *const PdCStrInnerImpl as *const PdCStr) }
+        unsafe { &*(std::ptr::from_ref::<PdCStrInnerImpl>(inner) as *const PdCStr) }
     }
     #[inline]
     pub(crate) fn as_inner(&self) -> &PdCStrInnerImpl {
         // Safety:
         // Safe because PdCStr has the same layout as PdCStrInnerImpl
-        unsafe { &*(self as *const PdCStr as *const PdCStrInnerImpl) }
+        unsafe { &*(std::ptr::from_ref::<PdCStr>(self) as *const PdCStrInnerImpl) }
     }
 
     /// Returns a raw pointer to the string.