Skip to content

Commit 7917a14

Browse files
author
mason
committed
feat: support insecure pull from private registry
1 parent 9498c4e commit 7917a14

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

charts/csghub/charts/runner/templates/helpers/_runner.tpl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,8 +96,8 @@ Define the kaniko args for runner
9696
{{- $pypi := printf "--build-arg=PyPI=%s" .Values.global.pipIndexUrl }}
9797
{{- $hf := printf "--build-arg=HF_ENDPOINT=%s/hf" (or .Values.externalUrl (include "csghub.external.endpoint" .)) }}
9898
{{- $insecure := "" }}
99-
{{- if or .Values.global.registry.enabled .Values.registry.insecure .Values.global.registry.external.insecure }}
100-
{{- $insecure = "--skip-tls-verify,--insecure" }}
99+
{{- if .Values.registry.insecure }}
100+
{{- $insecure = "--skip-tls-verify,--skip-tls-verify-pull,--insecure,--insecure-pull" }}
101101
{{- end }}
102102
{{- printf "%s,%s,%s,%s" $speedUpArgs $pypi $hf $insecure | trimSuffix "," -}}
103103
{{- end }}

charts/runner/templates/helpers/_runner.tpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ Define the kaniko args for runner
9797
{{- $hf := printf "--build-arg=HF_ENDPOINT=%s/hf" (or .Values.externalUrl (include "csghub.external.endpoint" .)) }}
9898
{{- $insecure := "" }}
9999
{{- if .Values.registry.insecure }}
100-
{{- $insecure = "--skip-tls-verify,--insecure" }}
100+
{{- $insecure = "--skip-tls-verify,--skip-tls-verify-pull,--insecure,--insecure-pull" }}
101101
{{- end }}
102102
{{- printf "%s,%s,%s,%s" $speedUpArgs $pypi $hf $insecure | trimSuffix "," -}}
103103
{{- end }}

0 commit comments

Comments
 (0)