fix(ci): run go test under bash on Windows; fix errcheck in model tests

PowerShell treats coverage.out as property access, breaking -coverprofile.
Complete errcheck fixes in model tests and remaining csghub models_test handlers.

Made-with: Cursor

Author: ganisback

.github/workflows/ci.yml

@@ -40,13 +40,17 @@ jobs:
         with:
           go-version: ${{ matrix.go-version }}
 
+      # Use bash on Windows too: PowerShell parses coverage.out as member access on $coverage.
       - name: Run tests
+        shell: bash
         run: go test -race -count=1 -coverprofile=coverage.out ./...
 
       - name: Build binary
+        shell: bash
         run: go build -o bin/csghub-lite ./cmd/csghub-lite
 
       - name: Verify version flag
+        shell: bash
         run: ./bin/csghub-lite --version
 
       - name: Upload coverage

internal/csghub/models_test.go

@@ -88,7 +88,7 @@ func TestGetModelTree(t *testing.T) {
 				{Name: "model.safetensors", Type: "file", Size: 2200119664, LFS: true, LFSSHA256: "abc123"},
 			},
 		}
-		json.NewEncoder(w).Encode(resp)
+		_ = json.NewEncoder(w).Encode(resp)
 	}))
 	defer server.Close()
 
@@ -123,7 +123,7 @@ func TestSearchModels(t *testing.T) {
 			Data:  []Model{{Name: "llama-7b"}},
 			Total: 5,
 		}
-		json.NewEncoder(w).Encode(resp)
+		_ = json.NewEncoder(w).Encode(resp)
 	}))
 	defer server.Close()
 

internal/model/manager_test.go

@@ -31,7 +31,9 @@ func TestManager_List_WithModels(t *testing.T) {
 		{Namespace: "ns1", Name: "model1", Format: FormatGGUF, Size: 100, DownloadedAt: time.Now()},
 		{Namespace: "ns2", Name: "model2", Format: FormatSafeTensors, Size: 200, DownloadedAt: time.Now()},
 	} {
-		SaveManifest(dir, m)
+		if err := SaveManifest(dir, m); err != nil {
+			t.Fatal(err)
+		}
 	}
 
 	models, err := mgr.List()
@@ -54,7 +56,9 @@ func TestManager_Get(t *testing.T) {
 		Format:    FormatGGUF,
 		Size:      1024,
 	}
-	SaveManifest(dir, lm)
+	if err := SaveManifest(dir, lm); err != nil {
+		t.Fatal(err)
+	}
 
 	got, err := mgr.Get("test/model")
 	if err != nil {
@@ -86,7 +90,9 @@ func TestManager_Remove(t *testing.T) {
 		Name:      "removeme",
 		Format:    FormatGGUF,
 	}
-	SaveManifest(dir, lm)
+	if err := SaveManifest(dir, lm); err != nil {
+		t.Fatal(err)
+	}
 
 	if err := mgr.Remove("test/removeme"); err != nil {
 		t.Fatalf("Remove error: %v", err)

internal/model/manifest_test.go

@@ -119,8 +119,12 @@ func TestFindModelFile(t *testing.T) {
 	dir := t.TempDir()
 
 	// Create a GGUF file
-	os.WriteFile(filepath.Join(dir, "model.gguf"), []byte("gguf"), 0o644)
-	os.WriteFile(filepath.Join(dir, "config.json"), []byte("{}"), 0o644)
+	if err := os.WriteFile(filepath.Join(dir, "model.gguf"), []byte("gguf"), 0o644); err != nil {
+		t.Fatal(err)
+	}
+	if err := os.WriteFile(filepath.Join(dir, "config.json"), []byte("{}"), 0o644); err != nil {
+		t.Fatal(err)
+	}
 
 	path, format, err := FindModelFile(dir)
 	if err != nil {
@@ -137,7 +141,9 @@ func TestFindModelFile(t *testing.T) {
 func TestFindModelFile_SafeTensors(t *testing.T) {
 	dir := t.TempDir()
 
-	os.WriteFile(filepath.Join(dir, "model.safetensors"), []byte("st"), 0o644)
+	if err := os.WriteFile(filepath.Join(dir, "model.safetensors"), []byte("st"), 0o644); err != nil {
+		t.Fatal(err)
+	}
 
 	path, format, err := FindModelFile(dir)
 	if err != nil {
@@ -153,7 +159,9 @@ func TestFindModelFile_SafeTensors(t *testing.T) {
 
 func TestFindModelFile_NotFound(t *testing.T) {
 	dir := t.TempDir()
-	os.WriteFile(filepath.Join(dir, "config.json"), []byte("{}"), 0o644)
+	if err := os.WriteFile(filepath.Join(dir, "config.json"), []byte("{}"), 0o644); err != nil {
+		t.Fatal(err)
+	}
 
 	_, _, err := FindModelFile(dir)
 	if err == nil {
@@ -163,8 +171,12 @@ func TestFindModelFile_NotFound(t *testing.T) {
 
 func TestFindModelFile_PicksHighestPrecisionGGUF(t *testing.T) {
 	dir := t.TempDir()
-	os.WriteFile(filepath.Join(dir, "low-Q4_0.gguf"), []byte("a"), 0o644)
-	os.WriteFile(filepath.Join(dir, "high-Q8_0.gguf"), []byte("b"), 0o644)
+	if err := os.WriteFile(filepath.Join(dir, "low-Q4_0.gguf"), []byte("a"), 0o644); err != nil {
+		t.Fatal(err)
+	}
+	if err := os.WriteFile(filepath.Join(dir, "high-Q8_0.gguf"), []byte("b"), 0o644); err != nil {
+		t.Fatal(err)
+	}
 
 	path, format, err := FindModelFile(dir)
 	if err != nil {

internal/model/storage_test.go

@@ -43,8 +43,12 @@ func TestRemoveModelDir(t *testing.T) {
 
 	// Create model directory with a file
 	modelDir := filepath.Join(dir, "ns", "model")
-	os.MkdirAll(modelDir, 0o755)
-	os.WriteFile(filepath.Join(modelDir, "test.txt"), []byte("test"), 0o644)
+	if err := os.MkdirAll(modelDir, 0o755); err != nil {
+		t.Fatal(err)
+	}
+	if err := os.WriteFile(filepath.Join(modelDir, "test.txt"), []byte("test"), 0o644); err != nil {
+		t.Fatal(err)
+	}
 
 	if err := RemoveModelDir(dir, "ns", "model"); err != nil {
 		t.Fatalf("RemoveModelDir error: %v", err)
@@ -65,9 +69,15 @@ func TestRemoveModelDir_KeepsOtherModels(t *testing.T) {
 	dir := t.TempDir()
 
 	// Create two models in the same namespace
-	os.MkdirAll(filepath.Join(dir, "ns", "model1"), 0o755)
-	os.MkdirAll(filepath.Join(dir, "ns", "model2"), 0o755)
-	os.WriteFile(filepath.Join(dir, "ns", "model2", "file.txt"), []byte("keep"), 0o644)
+	if err := os.MkdirAll(filepath.Join(dir, "ns", "model1"), 0o755); err != nil {
+		t.Fatal(err)
+	}
+	if err := os.MkdirAll(filepath.Join(dir, "ns", "model2"), 0o755); err != nil {
+		t.Fatal(err)
+	}
+	if err := os.WriteFile(filepath.Join(dir, "ns", "model2", "file.txt"), []byte("keep"), 0o644); err != nil {
+		t.Fatal(err)
+	}
 
 	if err := RemoveModelDir(dir, "ns", "model1"); err != nil {
 		t.Fatalf("RemoveModelDir error: %v", err)