Skip to content

Commit 8300770

Browse files
luojun96Jun Luo
andauthored
fix lint issue (#599)
* fix lint issue * fix lint issue in space component --------- Co-authored-by: Jun Luo <[email protected]>
1 parent 5d26d92 commit 8300770

File tree

13 files changed

+590
-61
lines changed

13 files changed

+590
-61
lines changed

aigateway/router/aigateway.go

Lines changed: 19 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -3,39 +3,48 @@ package router
33
import (
44
"fmt"
55

6+
"github.com/gin-contrib/cors"
67
"github.com/gin-gonic/gin"
78
"opencsg.com/csghub-server/aigateway/handler"
89
"opencsg.com/csghub-server/api/middleware"
10+
"opencsg.com/csghub-server/builder/instrumentation"
911
"opencsg.com/csghub-server/common/config"
10-
"opencsg.com/csghub-server/common/i18n"
1112
)
1213

1314
func NewRouter(config *config.Config) (*gin.Engine, error) {
1415
r := gin.New()
15-
r.Use(gin.Recovery())
16-
r.Use(middleware.Log())
16+
middleware.SetInfraMiddleware(r, config, instrumentation.Aigateway)
17+
r.Use(cors.New(cors.Config{
18+
AllowCredentials: true,
19+
AllowHeaders: []string{"*"},
20+
AllowMethods: []string{"*"},
21+
AllowAllOrigins: true,
22+
}))
1723
//to access model,fintune with any kind of tokens in auth header
18-
i18n.InitLocalizersFromEmbedFile()
19-
r.Use(middleware.ModifyAcceptLanguageMiddleware(), middleware.LocalizedErrorMiddleware())
2024
r.Use(middleware.Authenticator(config))
21-
mustLogin := middleware.MustLogin()
25+
middlewareCollection := middleware.MiddlewareCollection{}
26+
middlewareCollection.Auth.NeedLogin = middleware.MustLogin()
27+
middlewareCollection.Auth.NeedPhoneVerified = middleware.NeedPhoneVerified(config)
2228

2329
v1Group := r.Group("/v1")
2430

2531
openAIhandler, err := handler.NewOpenAIHandlerFromConfig(config)
2632
if err != nil {
2733
return nil, fmt.Errorf("error creating openai handler :%w", err)
2834
}
29-
v1Group.GET("/models", mustLogin, openAIhandler.ListModels)
30-
v1Group.GET("/models/:model", mustLogin, openAIhandler.GetModel)
31-
v1Group.POST("/chat/completions", mustLogin, openAIhandler.Chat)
32-
v1Group.POST("/embeddings", mustLogin, openAIhandler.Embedding)
35+
v1Group.GET("/models", middlewareCollection.Auth.NeedLogin, openAIhandler.ListModels)
36+
v1Group.GET("/models/:model", middlewareCollection.Auth.NeedLogin, openAIhandler.GetModel)
37+
v1Group.POST("/chat/completions", middlewareCollection.Auth.NeedLogin, openAIhandler.Chat)
38+
v1Group.POST("/embeddings", middlewareCollection.Auth.NeedLogin, openAIhandler.Embedding)
3339

3440
mcpProxy, err := handler.NewMCPProxyHandler(config)
3541
if err != nil {
3642
return nil, fmt.Errorf("error creating mcp proxy handler :%w", err)
3743
}
3844
CreateMCPRoute(v1Group, mcpProxy)
45+
if err := extendRoutes(v1Group, middlewareCollection, config); err != nil {
46+
return nil, fmt.Errorf("error creating extended routes :%w", err)
47+
}
3948
return r, nil
4049
}
4150

aigateway/router/api_ce.go

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
//go:build !ee && !saas
2+
3+
package router
4+
5+
import (
6+
"github.com/gin-gonic/gin"
7+
"opencsg.com/csghub-server/api/middleware"
8+
"opencsg.com/csghub-server/common/config"
9+
)
10+
11+
func extendRoutes(_ *gin.RouterGroup, _ middleware.MiddlewareCollection, _ *config.Config) error {
12+
return nil
13+
}

api/handler/finetune.go

Lines changed: 3 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -11,31 +11,9 @@ import (
1111

1212
"github.com/gin-gonic/gin"
1313
"opencsg.com/csghub-server/api/httpbase"
14-
"opencsg.com/csghub-server/common/config"
1514
"opencsg.com/csghub-server/common/types"
16-
"opencsg.com/csghub-server/component"
1715
)
1816

19-
func NewFinetuneHandler(config *config.Config) (*FinetuneHandler, error) {
20-
ftComp, err := component.NewFinetuneComponent(config)
21-
if err != nil {
22-
return nil, err
23-
}
24-
sc, err := component.NewSensitiveComponent(config)
25-
if err != nil {
26-
return nil, fmt.Errorf("error creating sensitive component:%w", err)
27-
}
28-
return &FinetuneHandler{
29-
ftComp: ftComp,
30-
sensitive: sc,
31-
}, nil
32-
}
33-
34-
type FinetuneHandler struct {
35-
ftComp component.FinetuneComponent
36-
sensitive component.SensitiveComponent
37-
}
38-
3917
// create finetune godoc
4018
// @Security ApiKey
4119
// @Summary run fineune with model and dataset
@@ -72,6 +50,9 @@ func (h *FinetuneHandler) RunFinetuneJob(ctx *gin.Context) {
7250
httpbase.ServerError(ctx, err)
7351
return
7452
}
53+
54+
h.createAgentInstanceTask(ctx.Request.Context(), req.Agent, finetune.TaskId, currentUser)
55+
7556
httpbase.OK(ctx, finetune)
7657
}
7758

api/handler/finetune_ce.go

Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,34 @@
1+
//go:build !ee && !saas
2+
3+
package handler
4+
5+
import (
6+
"context"
7+
"fmt"
8+
9+
"opencsg.com/csghub-server/common/config"
10+
"opencsg.com/csghub-server/component"
11+
)
12+
13+
func NewFinetuneHandler(config *config.Config) (*FinetuneHandler, error) {
14+
ftComp, err := component.NewFinetuneComponent(config)
15+
if err != nil {
16+
return nil, err
17+
}
18+
sc, err := component.NewSensitiveComponent(config)
19+
if err != nil {
20+
return nil, fmt.Errorf("error creating sensitive component:%w", err)
21+
}
22+
return &FinetuneHandler{
23+
ftComp: ftComp,
24+
sensitive: sc,
25+
}, nil
26+
}
27+
28+
type FinetuneHandler struct {
29+
ftComp component.FinetuneComponent
30+
sensitive component.SensitiveComponent
31+
}
32+
33+
func (h *FinetuneHandler) createAgentInstanceTask(_ context.Context, _ string, _ string, _ string) {
34+
}
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
//go:build !ee && !saas
2+
13
package handler
24

35
import (

api/handler/model.go

Lines changed: 1 addition & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -11,39 +11,11 @@ import (
1111

1212
"github.com/gin-gonic/gin"
1313
"opencsg.com/csghub-server/api/httpbase"
14-
"opencsg.com/csghub-server/common/config"
1514
"opencsg.com/csghub-server/common/errorx"
1615
"opencsg.com/csghub-server/common/types"
1716
"opencsg.com/csghub-server/common/utils/common"
18-
"opencsg.com/csghub-server/component"
1917
)
2018

21-
func NewModelHandler(config *config.Config) (*ModelHandler, error) {
22-
uc, err := component.NewModelComponent(config)
23-
if err != nil {
24-
return nil, err
25-
}
26-
sc, err := component.NewSensitiveComponent(config)
27-
if err != nil {
28-
return nil, fmt.Errorf("error creating sensitive component:%w", err)
29-
}
30-
repo, err := component.NewRepoComponent(config)
31-
if err != nil {
32-
return nil, fmt.Errorf("error creating repo component:%w", err)
33-
}
34-
return &ModelHandler{
35-
model: uc,
36-
sensitive: sc,
37-
repo: repo,
38-
}, nil
39-
}
40-
41-
type ModelHandler struct {
42-
model component.ModelComponent
43-
repo component.RepoComponent
44-
sensitive component.SensitiveComponent
45-
}
46-
4719
// GetVisiableModels godoc
4820
// @Security ApiKey
4921
// @Summary Get Visiable models for current user
@@ -737,6 +709,7 @@ func (h *ModelHandler) DeployDedicated(ctx *gin.Context) {
737709

738710
slog.Debug("deploy model as inference created", slog.String("namespace", namespace),
739711
slog.String("name", name), slog.Int64("deploy_id", deployID))
712+
h.createAgentInstanceTask(ctx.Request.Context(), req.Agent, fmt.Sprintf("%d", deployID), types.AgentTaskTypeInference, currentUser)
740713

741714
// return deploy_id
742715
response := types.DeployRepo{DeployID: deployID}

api/handler/model_ce.go

Lines changed: 41 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,41 @@
1+
//go:build !ee && !saas
2+
3+
package handler
4+
5+
import (
6+
"context"
7+
"fmt"
8+
9+
"opencsg.com/csghub-server/common/config"
10+
"opencsg.com/csghub-server/common/types"
11+
"opencsg.com/csghub-server/component"
12+
)
13+
14+
func NewModelHandler(config *config.Config) (*ModelHandler, error) {
15+
uc, err := component.NewModelComponent(config)
16+
if err != nil {
17+
return nil, err
18+
}
19+
sc, err := component.NewSensitiveComponent(config)
20+
if err != nil {
21+
return nil, fmt.Errorf("error creating sensitive component:%w", err)
22+
}
23+
repo, err := component.NewRepoComponent(config)
24+
if err != nil {
25+
return nil, fmt.Errorf("error creating repo component:%w", err)
26+
}
27+
return &ModelHandler{
28+
model: uc,
29+
sensitive: sc,
30+
repo: repo,
31+
}, nil
32+
}
33+
34+
type ModelHandler struct {
35+
model component.ModelComponent
36+
repo component.RepoComponent
37+
sensitive component.SensitiveComponent
38+
}
39+
40+
func (h *ModelHandler) createAgentInstanceTask(_ context.Context, _ string, _ string, _ types.AgentTaskType, _ string) {
41+
}
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
//go:build !ee && !saas
2+
13
package handler
24

35
import (

0 commit comments

Comments
 (0)