[connectors] Adapt pylint, adding global rule no-value-for-parameter

Author: richard-julien

pycti/entities/opencti_stix_sighting_relationship.py

@@ -263,7 +263,6 @@ def __init__(self, opencti):
 
     @staticmethod
     def generate_id(
-        relationship_type,
         sighting_of_ref,
         where_sighted_refs,
         first_seen=None,
@@ -276,22 +275,22 @@ def generate_id(
 
         if first_seen is not None and last_seen is not None:
             data = {
-                "type": relationship_type,
+                "type": "sighting",
                 "sighting_of_ref": sighting_of_ref,
                 "where_sighted_refs": where_sighted_refs,
                 "first_seen": first_seen,
                 "last_seen": last_seen,
             }
         elif first_seen is not None:
             data = {
-                "type": relationship_type,
+                "type": "sighting",
                 "sighting_of_ref": sighting_of_ref,
                 "where_sighted_refs": where_sighted_refs,
                 "first_seen": first_seen,
             }
         else:
             data = {
-                "type": relationship_type,
+                "type": "sighting",
                 "sighting_of_ref": sighting_of_ref,
                 "where_sighted_refs": where_sighted_refs,
             }
@@ -302,7 +301,6 @@ def generate_id(
     @staticmethod
     def generate_id_from_data(data):
         return StixSightingRelationship.generate_id(
-            data["type"],
             data["sighting_of_ref"],
             data["where_sighted_refs"],
             data.get("first_seen"),