[client] Fix marking definition addition in entities (#140)

Samuel Hassine · Samuel Hassine · commit 4217fcd5de2b · 2021-02-14T14:39:32.000+01:00
diff --git a/pycti/entities/opencti_stix_core_relationship.py b/pycti/entities/opencti_stix_core_relationship.py
@@ -589,7 +589,7 @@ def add_marking_definition(self, **kwargs):
                     "error", "Cannot add Marking-Definition, entity not found"
                 )
                 return False
-            if marking_definition_id in stix_core_relationship["markingDefinitionsIds"]:
+            if marking_definition_id in stix_core_relationship["objectMarkingIds"]:
                 return True
             else:
                 self.opencti.log(
diff --git a/pycti/entities/opencti_stix_cyber_observable.py b/pycti/entities/opencti_stix_cyber_observable.py
@@ -1250,7 +1250,7 @@ def add_marking_definition(self, **kwargs):
                     "error", "Cannot add Marking-Definition, entity not found"
                 )
                 return False
-            if marking_definition_id in stix_cyber_observable["markingDefinitionsIds"]:
+            if marking_definition_id in stix_cyber_observable["objectMarkingIds"]:
                 return True
             else:
                 self.opencti.log(
diff --git a/pycti/entities/opencti_stix_domain_object.py b/pycti/entities/opencti_stix_domain_object.py
@@ -839,7 +839,7 @@ def add_marking_definition(self, **kwargs):
                     "error", "Cannot add Marking-Definition, entity not found"
                 )
                 return False
-            if marking_definition_id in stix_domain_object["markingDefinitionsIds"]:
+            if marking_definition_id in stix_domain_object["objectMarkingIds"]:
                 return True
             else:
                 self.opencti.log(

Original file line number	Diff line number	Diff line change
`@@ -589,7 +589,7 @@ def add_marking_definition(self, **kwargs):`
`589`	`589`	`"error", "Cannot add Marking-Definition, entity not found"`
`590`	`590`	`)`
`591`	`591`	`return False`
`592`		`- if marking_definition_id in stix_core_relationship["markingDefinitionsIds"]:`
	`592`	`+ if marking_definition_id in stix_core_relationship["objectMarkingIds"]:`
`593`	`593`	`return True`
`594`	`594`	`else:`
`595`	`595`	`self.opencti.log(`
Original file line number	Diff line number	Diff line change
`@@ -1250,7 +1250,7 @@ def add_marking_definition(self, **kwargs):`
`1250`	`1250`	`"error", "Cannot add Marking-Definition, entity not found"`
`1251`	`1251`	`)`
`1252`	`1252`	`return False`
`1253`		`- if marking_definition_id in stix_cyber_observable["markingDefinitionsIds"]:`
	`1253`	`+ if marking_definition_id in stix_cyber_observable["objectMarkingIds"]:`
`1254`	`1254`	`return True`
`1255`	`1255`	`else:`
`1256`	`1256`	`self.opencti.log(`
Original file line number	Diff line number	Diff line change
`@@ -839,7 +839,7 @@ def add_marking_definition(self, **kwargs):`
`839`	`839`	`"error", "Cannot add Marking-Definition, entity not found"`
`840`	`840`	`)`
`841`	`841`	`return False`
`842`		`- if marking_definition_id in stix_domain_object["markingDefinitionsIds"]:`
	`842`	`+ if marking_definition_id in stix_domain_object["objectMarkingIds"]:`
`843`	`843`	`return True`
`844`	`844`	`else:`
`845`	`845`	`self.opencti.log(`