[client] Adapt acknowledge strategy in connector helper

Author: richard-julien

pycti/api/opencti_api_playbook.py

@@ -1,5 +1,3 @@
-import json
-
 from pycti.api import LOGGER
 
 

pycti/connector/opencti_connector_helper.py

@@ -220,7 +220,6 @@ async def _process_message(self, channel, method, properties, body) -> None:
 
         json_data = json.loads(body)
         work_id = json_data["internal"]["work_id"]
-        channel.basic_ack(delivery_tag=method.delivery_tag)
         message_task = self._data_handler(json_data)
         five_minutes = 60 * 5
         time_wait = 0
@@ -240,6 +239,8 @@ async def _process_message(self, channel, method, properties, body) -> None:
             logging.exception("Error in message processing, reporting error to API")
             if work_id:
                 self.helper.api.work.to_processed(work_id, str(e), True)
+        finally:
+            channel.basic_ack(delivery_tag=method.delivery_tag)
         LOGGER.info(
             "Message (delivery_tag=%s) processed, thread terminated",
             method.delivery_tag,