Move test stubs for Settings to entities test file

Author: peritz

pycti/entities/opencti_settings.py

@@ -209,24 +209,6 @@ def __init__(self, opencti):
             analytics_google_analytics_v4
             enterprise_edition
         """ + self.password_policy_properties
-        self._deleted = False
-
-    def create(self, **kwargs) -> Dict:
-        """Stub function for tests
-
-        :return: Settings as defined by self.read()
-        :rtype: Dict
-        """
-        self.opencti.admin_logger.info(
-            "Settings.create called with arguments", kwargs)
-        self._deleted = False
-        return self.read()
-
-    def delete(self, **kwargs):
-        """Stub function for tests"""
-        self.opencti.admin_logger.info(
-            "Settings.delete called with arguments", kwargs)
-        self._deleted = True
 
     def read(self, **kwargs) -> Dict:
         """Reads settings from the platform
@@ -242,9 +224,6 @@ def read(self, **kwargs) -> Dict:
         :return: Representation of the platform settings
         :rtype: Dict
         """
-        if self._deleted:
-            return None
-
         custom_attributes = kwargs.get("customAttributes", None)
         include_password_policy = kwargs.get("include_password_policy", False)
         include_messages = kwargs.get("include_messages", False)

tests/cases/entities.py

@@ -3,6 +3,7 @@
 from stix2 import TLP_GREEN, TLP_WHITE, AttackPattern
 
 from pycti.utils.constants import ContainerTypes, IdentityTypes, LocationTypes
+from pycti.entities.opencti_settings import Settings
 from tests.utils import get_incident_end_date, get_incident_start_date
 
 
@@ -1262,7 +1263,37 @@ def get_search(self):
 
 
 class SettingsTest(EntityTest):
+
+    class SettingsWrapper(Settings):
+        def __init__(self, opencti):
+            self._deleted = False
+            super().__init__(opencti)
+
+        def create(self, **kwargs) -> Dict:
+            """Stub function for tests
+
+            :return: Settings as defined by self.read()
+            :rtype: Dict
+            """
+            self.opencti.admin_logger.info(
+                "Settings.create called with arguments", kwargs)
+            self._deleted = False
+            return self.read()
+
+        def delete(self, **kwargs):
+            """Stub function for tests"""
+            self.opencti.admin_logger.info(
+                "Settings.delete called with arguments", kwargs)
+            self._deleted = True
+
+        def read(self, **kwargs):
+            """Stub function for tests"""
+            if self._deleted:
+                return None
+            return super().read(**kwargs)
+
     def setup(self):
+        self._ownclass = self.SettingsWrapper(self.api_client)
         # Save current platform information
         custom_attributes = self.own_class().editable_properties
         self.own_class().create()
@@ -1287,7 +1318,7 @@ def data(self) -> Dict:
         return {}
 
     def own_class(self):
-        return self.api_client.settings
+        return self._ownclass
 
     def base_class(self):
         return self.own_class()