@@ -237,50 +237,7 @@ Scripts scan `__metadata__/connector_manifest.json` files and consolidate them.
2372376 . ** Docker networking** - Locally, connectors expect ` docker_default ` network
2382387 . ** Environment variables** - Use ` .env.sample ` as template, never commit secrets
239239
240- ## Code Review & PR Submission
241-
242- ** When reviewing code, focus on:**
243-
244- ### Security Critical Issues
245- - Check for hardcoded secrets, API keys, or credentials
246- - Look for SQL injection and XSS vulnerabilities
247- - Verify proper input validation and sanitization
248- - Review authentication and authorization logic
249-
250- ### Performance Red Flags
251- - Identify N+1 database query problems
252- - Spot inefficient loops and algorithmic issues
253- - Check for memory leaks and resource cleanup
254- - Review caching opportunities for expensive operations
255-
256- ### Code Quality Essentials
257- - Functions should be focused and appropriately sized
258- - Use clear, descriptive naming conventions
259- - Ensure proper error handling throughout
260-
261- ### Review Style
262- - Be specific and actionable in feedback
263- - Explain the "why" behind recommendations
264- - Acknowledge good patterns when you see them
265- - Ask clarifying questions when code intent is unclear
266-
267- Always prioritize security vulnerabilities and performance issues that could impact users.
268-
269- Always suggest changes to improve readability. For example:
270-
271- ``` python
272- # Instead of:
273- if user.email and ' @' in user.email and len (user.email) > 5 :
274- submit_button.enabled = True
275- else :
276- submit_button.enabled = False
277-
278- # Consider:
279- def is_valid_email (email ):
280- return email and ' @' in email and len (email) > 5
281-
282- submit_button.enabled = is_valid_email(user.email)
283- ```
240+ ## PR Submission
284241
285242** Before submitting a PR:**
286243
0 commit comments