[frontend] Take care of PR review comments (#8237)

Author: richard-julien

opencti-platform/opencti-front/src/private/components/common/drawer/HistoryDrawer.tsx

@@ -78,7 +78,7 @@ const HistoryDrawerContent: FunctionComponent<HistoryDrawerContentProps> = ({ lo
               <TableBody>
                 {changes && changes.length > 0 ? (changes.map((row) => {
                   return (
-                    <TableRow key={row?.field} hover={true}>
+                    <TableRow key={row?.field} hover={false}>
                       <TableCell component="th" scope="row" style={{ fontWeight: 'bold', padding: 14, verticalAlign: 'top' }}>
                         {row?.field}
                       </TableCell>

opencti-platform/opencti-front/src/private/components/settings/activity/audit/AuditDrawer.tsx

@@ -99,7 +99,7 @@ const AuditDrawerContent: FunctionComponent<{ logId: string }> = ({ logId }) =>
                 <TableBody>
                   {changes && changes.length > 0 ? (changes.map((row) => {
                     return (
-                      <TableRow key={row?.field} hover={true}>
+                      <TableRow key={row?.field} hover={false}>
                         <TableCell component="th" scope="row" style={{ fontWeight: 'bold', verticalAlign: 'top' }}>
                           {row?.field}
                         </TableCell>

opencti-platform/opencti-graphql/src/database/data-changes.ts

@@ -249,13 +249,13 @@ const convertAttribute = async (context: AuthContext, user: AuthUser,
     return { raw: item };
   }
   if (attribute.type === 'date') {
-    return { raw: item };
+    return { raw: String(item) };
   }
   if (attribute.type === 'boolean') {
-    return { raw: item };
+    return { raw: String(item) };
   }
   if (attribute.type === 'numeric') {
-    return { raw: item };
+    return { raw: String(item) };
   }
   throw UnsupportedError('Change build error, unknown attribute', { attribute });
 };
@@ -374,7 +374,6 @@ const legacyHistoryChanges = (log: any) => {
 
 export const changeIdsExtractor = async (context: AuthContext, user: AuthUser, changes: Change[]) => {
   const ids = [];
-  // const { context_data } = log;
   const getEntitiesMapFromCache = buildMapFromCacheContext(context, user);
   for (let index = 0; index < changes.length; index++) {
     const change = changes[index];
@@ -424,7 +423,6 @@ export const attributesChangesResolver = async (context: AuthContext, user: Auth
   const lookingIds = [];
   for (let index = 0; index < attributesChanges.length; index++) {
     const attributeChanges = attributesChanges[index];
-    // const changes: Change[] = log.context_data.history_changes ?? [];
     const idsFromData = await changeIdsExtractor(context, user, attributeChanges);
     for (let i = 0; i < idsFromData.length; i++) {
       const idFromData = idsFromData[i];

opencti-platform/opencti-graphql/src/modules/workflow/workflow-types.ts

@@ -4,5 +4,5 @@ import type { BasicStoreIdentifier, BasicWorkflowStatus, BasicWorkflowTemplateEn
 export const isEntityStatus
   = (entity: BasicStoreIdentifier): entity is BasicWorkflowStatus => entity.entity_type === ENTITY_TYPE_STATUS;
 
-export const isEntityTemplate
+export const isEntityStatusTemplate
   = (entity: BasicStoreIdentifier): entity is BasicWorkflowTemplateEntity => entity.entity_type === ENTITY_TYPE_STATUS_TEMPLATE;