Apply PR feedback

Author: fellowseb

opencti-platform/opencti-front/src/private/components/analyses/groupings/Root.tsx

@@ -137,6 +137,7 @@ const RootGrouping = () => {
                   />
                   <StixDomainObjectTabsBox
                     basePath="/dashboard/analyses/groupings"
+                    entity={grouping}
                     tabs={[
                       'overview',
                       'knowledge',

opencti-platform/opencti-front/src/private/components/analyses/notes/Root.jsx

@@ -1,5 +1,5 @@
 import { useMemo } from 'react';
-import { Route, Routes, useLocation, useParams } from 'react-router-dom';
+import { Route, Routes, useParams } from 'react-router-dom';
 import { graphql, useSubscription } from 'react-relay';
 import { useFormatter } from '../../../../components/i18n';
 import Breadcrumbs from '../../../../components/Breadcrumbs';
@@ -66,7 +66,6 @@ const RootNote = () => {
     }),
     [noteId],
   );
-  const location = useLocation();
   const { t_i18n } = useFormatter();
   useSubscription(subConfig);
   return (

opencti-platform/opencti-front/src/private/components/cases/feedbacks/Root.tsx

@@ -133,7 +133,7 @@ const RootFeedbackComponent = ({ queryRef, caseId }) => {
         redirectToContent={true}
       />
       <StixDomainObjectTabsBox
-        basePath="/dashboard/incidents/feedbacks"
+        basePath="/dashboard/cases/feedbacks"
         entity={feedbackData}
         tabs={[
           'overview',

opencti-platform/opencti-front/src/private/components/common/stix_domain_objects/StixDomainObjectTabsBox.test.tsx

@@ -32,10 +32,12 @@ describe('StixDomainObjectTabsBox', () => {
         basePath={basePath}
       />,
     );
-    const tabElem = screen.getByText(new RegExp(tabName, 'i'));
+    const tabElem = screen.getByRole('tab', { name: new RegExp(tabName, 'i') });
     expect(tabElem).toBeInTheDocument();
-    expect(tabElem).toBeInstanceOf(HTMLAnchorElement);
-    expect((tabElem as HTMLAnchorElement).href).toMatch(new RegExp(`${basePath}/${entityId}${subroute}$`));
+    expect(tabElem).toHaveAttribute(
+      'href',
+      expect.stringMatching(new RegExp(`${basePath}/${entityId}${subroute}$`)),
+    );
   });
 
   it('renders components passed as extraActions', () => {

opencti-platform/opencti-front/src/private/components/events/observed_data/Root.tsx

@@ -1,5 +1,5 @@
 import { Suspense, useMemo } from 'react';
-import { Route, Routes, useLocation, useParams } from 'react-router-dom';
+import { Route, Routes, useParams } from 'react-router-dom';
 import { graphql, PreloadedQuery, usePreloadedQuery, useSubscription } from 'react-relay';
 import { GraphQLSubscriptionConfig } from 'relay-runtime';
 import { RootObservedDataSubscription } from './__generated__/RootObservedDataSubscription.graphql';
@@ -75,7 +75,6 @@ const RootObservedData = ({ queryRef, observedDataId }: RootObservedDataProps) =
   }), [observedDataId]);
 
   const { t_i18n } = useFormatter();
-  const location = useLocation();
 
   useSubscription<RootObservedDataSubscription>(subConfig);
 

opencti-platform/opencti-front/src/private/components/locations/regions/Root.tsx

@@ -163,7 +163,7 @@ const RootRegionComponent = ({ queryRef, regionId }) => {
             />
             <StixDomainObjectTabsBox
               basePath="/dashboard/locations/regions"
-              entity={position}
+              entity={region}
               tabs={[
                 'overview',
                 'knowledge-overview',