need to sort when we have multiple unknown keys for consistent output

freyfogle · freyfogle · commit ca315d8fa24f · 2025-03-26T09:52:42.000+01:00
diff --git a/lib/Geo/Address/Formatter.pm b/lib/Geo/Address/Formatter.pm
@@ -444,8 +444,10 @@ sub format_address {
                 say STDERR "unknown_components:";
                 say STDERR Dumper $ra_unknown;
             }
+            # need to sort for consistency
+            # FIXME - add better sorting based on meaning of the values
             $rh_components->{attention} =
-                join(', ', map { $rh_components->{$_} } @$ra_unknown);
+                join(', ', map { $rh_components->{$_} } sort @$ra_unknown);
             if ($debug){
                 say STDERR "putting unknown_components in 'attention'";
             }

Original file line number	Diff line number	Diff line change
`@@ -444,8 +444,10 @@ sub format_address {`
`444`	`444`	`say STDERR "unknown_components:";`
`445`	`445`	`say STDERR Dumper $ra_unknown;`
`446`	`446`	`}`
	`447`	`+ # need to sort for consistency`
	`448`	`+ # FIXME - add better sorting based on meaning of the values`
`447`	`449`	`$rh_components->{attention} =`
`448`		`- join(', ', map { $rh_components->{$_} } @$ra_unknown);`
	`450`	`+ join(', ', map { $rh_components->{$_} } sort @$ra_unknown);`
`449`	`451`	`if ($debug){`
`450`	`452`	`say STDERR "putting unknown_components in 'attention'";`
`451`	`453`	`}`