Merge pull request #21 from OpenCageData/fix-issue-18

fix: 🐛 Warning with PHP 8.5 on $http_response_header

Author: tsamaya

.github/workflows/ci.yml

@@ -37,9 +37,10 @@ jobs:
 
       - name: Run phpunit tests (with and without cURL)
         run: |
-          composer check
+          ./vendor/bin/phpunit --display-deprecations
+          SKIP_CURL=1 ./vendor/bin/phpunit --display-deprecations
 
-      - name: Run proxy tests
+      - name: Run proxy tests (with and without cURL)
         run: |
           docker run -d --name=tinyproxy -p 8888:8888 monokal/tinyproxy:latest ANY
           PROXY=http://0.0.0.0:8888 ./vendor/bin/phpunit

composer.lock

@@ -68,11 +68,11 @@ protected function getJSONByFopen($query)
 
         $ret = @file_get_contents($query);
         if ($ret === false) {
-            $response_headers = function_exists('http_get_last_response_headers')
-                ? http_get_last_response_headers()
-                /** NOTE: https://github.com/phpstan/phpstan/issues/3213 */
-                /** @phpstan-ignore-next-line */
-                : (isset($http_response_header) ? $http_response_header : null);
+            if (function_exists('http_get_last_response_headers')) {
+                $http_response_header = http_get_last_response_headers();
+            }
+
+            $response_headers = isset($http_response_header) ? $http_response_header : null;
 
             /** @phpstan-ignore-next-line */
             if (isset($response_headers) && is_array($response_headers)) {