[ToolChain] Better test to determine whether to use the --enable-new-dtags flag when linking the OpenCilk runtime

neboat · neboat · commit 2ab1c1226fc0 · 2020-07-04T13:33:15.000-04:00
diff --git a/clang/lib/Driver/ToolChain.cpp b/clang/lib/Driver/ToolChain.cpp
@@ -1060,7 +1060,7 @@ static void addRuntimeRunPath(const ToolChain &TC, const ArgList &Args,
       CmdArgs.push_back("-rpath");
       CmdArgs.push_back(Args.MakeArgString(CandidateRPath->c_str()));
       // TODO: Check the portability of the --enable-new-dtags flag.
-      if (!Triple.isOSDarwin())
+      if (Triple.isOSBinFormatELF())
         CmdArgs.push_back("--enable-new-dtags");
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -1060,7 +1060,7 @@ static void addRuntimeRunPath(const ToolChain &TC, const ArgList &Args,`
`1060`	`1060`	`CmdArgs.push_back("-rpath");`
`1061`	`1061`	`CmdArgs.push_back(Args.MakeArgString(CandidateRPath->c_str()));`
`1062`	`1062`	`// TODO: Check the portability of the --enable-new-dtags flag.`
`1063`		`- if (!Triple.isOSDarwin())`
	`1063`	`+ if (Triple.isOSBinFormatELF())`
`1064`	`1064`	`CmdArgs.push_back("--enable-new-dtags");`
`1065`	`1065`	`}`
`1066`	`1066`	`}`