Merge pull request #898 from OpenConext/bugfix/cleanup-unused-destination

Clean up unused usage of authnrequest destination

Author: MKodde

library/EngineBlock/Corto/Module/Bindings.php

@@ -183,10 +183,7 @@ public function receiveRequest()
         $_SESSION['currentServiceProvider'] = $ebRequest->getIssuer()->getValue();
 
         // Verify that we know this SP and have metadata for it.
-        $serviceProvider = $this->_verifyKnownSP(
-            $spEntityId->getValue(),
-            $ebRequest->getDestination()
-        );
+        $serviceProvider = $this->_verifyKnownSP($spEntityId->getValue());
 
         if (!$serviceProvider instanceof ServiceProvider) {
             throw new EngineBlock_Corto_Module_Bindings_Exception(
@@ -513,11 +510,10 @@ protected function _receiveMessageFromInternalBinding($key)
      * Verify if a message has an issuer that is known as an SP to us. If not, it
      * throws a Corto_Module_Bindings_VerificationException.
      * @param string $messageIssuer
-     * @param string $destination
      * @return AbstractRole Remote Entity that issued the message
      * @throws EngineBlock_Exception_UnknownServiceProvider
      */
-    protected function _verifyKnownSP(string $messageIssuer, string $destination = '')
+    protected function _verifyKnownSP(string $messageIssuer)
     {
         $remoteEntity = $this->_server->getRepository()->findServiceProviderByEntityId($messageIssuer);
 
@@ -534,8 +530,7 @@ protected function _verifyKnownSP(string $messageIssuer, string $destination = '
 
         throw new EngineBlock_Exception_UnknownServiceProvider(
             sprintf('Issuer "%s" is not a known remote entity? (please add SP to Remote Entities)', $messageIssuer),
-            $messageIssuer,
-            $destination
+            $messageIssuer
         );
     }
 

library/EngineBlock/Exception/UnknownServiceProvider.php

@@ -19,22 +19,15 @@
 class EngineBlock_Exception_UnknownServiceProvider extends Exception
 {
     private $_entityId;
-    private $_destination;
 
-    function __construct($message, $entityId, $destination)
+    function __construct($message, $entityId)
     {
         parent::__construct($message);
         $this->_entityId = $entityId;
-        $this->_destination = $destination;
     }
 
     public function getEntityId()
     {
         return $this->_entityId;
     }
-
-    public function getDestination()
-    {
-        return $this->_destination;
-    }
 }

src/OpenConext/EngineBlockBundle/EventListener/RedirectToFeedbackPageExceptionListener.php

@@ -160,7 +160,6 @@ public function onKernelException(GetResponseForExceptionEvent $event)
 
             $redirectParams  = [
                 'entity-id'   => $exception->getEntityId(),
-                'destination' => $exception->getDestination()
             ];
         } elseif ($exception instanceof EngineBlock_Exception_UnknownIdentityProvider) {
             $message         = 'Unknown Identity Provider';