Skip to content

Commit ce5f01c

Browse files
authored
Merge pull request #1187 from OpenConext/bugfix/request-access-console-error
Prevent removal of form from IdP when previously removed
2 parents 4ef5324 + 4c2a586 commit ce5f01c

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

theme/base/javascripts/wayf/handleClickingDisabledIdp.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,10 @@ export const handleClickingDisabledIdp = (element) => {
2222
cloneOfIdp.setAttribute('tabindex', '-1');
2323
// change titleText of clone to represent state of clone
2424
cloneOfIdp.querySelector(`#${noAccessIdpTitleId}`).firstElementChild.innerHTML = getData(li, 'titlestart');
25-
// remove form so the login button is not there
26-
cloneOfIdp.querySelector(idpFormSelector).remove();
25+
// remove form so the login button is not there, but only while the form is still in the clone
26+
if (cloneOfIdp.querySelector(idpFormSelector)) {
27+
cloneOfIdp.querySelector(idpFormSelector).remove();
28+
}
2729
// hide disabled idp button from screenreaders
2830
cloneOfIdp.querySelector(idpDeleteDisabledSelector).setAttribute('aria-hidden', 'true');
2931
const connectable = getData(target, 'connectable') === 'true';

0 commit comments

Comments
 (0)