builder: combine the converter set to converter_runner

Signed-off-by: Jack Lau <[email protected]>

Author: JackLau1222

src/CMakeLists.txt

@@ -240,6 +240,7 @@ if(ENABLE_GUI)
     list(APPEND GUI_SOURCES
         ${CMAKE_SOURCE_DIR}/builder/src/base_page.cpp
         ${CMAKE_SOURCE_DIR}/builder/src/file_selector_widget.cpp
+        ${CMAKE_SOURCE_DIR}/builder/src/converter_runner.cpp
         ${CMAKE_SOURCE_DIR}/builder/src/placeholder_page.cpp
         ${CMAKE_SOURCE_DIR}/builder/src/info_view_page.cpp
         ${CMAKE_SOURCE_DIR}/builder/src/compress_picture_page.cpp
@@ -257,6 +258,7 @@ if(ENABLE_GUI)
     list(APPEND GUI_HEADERS
         ${CMAKE_SOURCE_DIR}/builder/include/base_page.h
         ${CMAKE_SOURCE_DIR}/builder/include/file_selector_widget.h
+        ${CMAKE_SOURCE_DIR}/builder/include/converter_runner.h
         ${CMAKE_SOURCE_DIR}/builder/include/placeholder_page.h
         ${CMAKE_SOURCE_DIR}/builder/include/info_view_page.h
         ${CMAKE_SOURCE_DIR}/builder/include/compress_picture_page.h

src/builder/include/converter_runner.h

@@ -0,0 +1,146 @@
+/*
+ * Copyright 2025 Jack Lau
+ * Email: [email protected]
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#ifndef CONVERTER_RUNNER_H
+#define CONVERTER_RUNNER_H
+
+#include "../../common/include/process_observer.h"
+#include <QLabel>
+#include <QObject>
+#include <QProgressBar>
+#include <QPushButton>
+#include <QString>
+#include <functional>
+
+class EncodeParameter;
+class ProcessParameter;
+
+/**
+ * @brief Helper class to manage conversion operations with progress tracking
+ *
+ * This class encapsulates the common pattern of:
+ * - Input validation
+ * - Progress bar management
+ * - Button state management
+ * - Thread-based conversion execution
+ * - Completion handling with success/error messages
+ *
+ * Usage:
+ * @code
+ * ConverterRunner *runner = new ConverterRunner(
+ *     progressBar, progressLabel, convertButton,
+ *     "Converting...", "Convert",
+ *     "Success", "File converted successfully!",
+ *     "Error", "Failed to convert file.",
+ *     this
+ * );
+ *
+ * connect(runner, &ConverterRunner::ConversionFinished, this, &MyPage::OnConversionFinished);
+ *
+ * runner->RunConversion(inputPath, outputPath, encodeParam, processParam);
+ * @endcode
+ */
+class ConverterRunner : public QObject, public ProcessObserver {
+    Q_OBJECT
+
+public:
+    /**
+     * @brief Construct a ConverterRunner
+     * @param progressBar Progress bar widget to show conversion progress
+     * @param progressLabel Label to show time remaining
+     * @param actionButton Button to trigger conversion (will be disabled during conversion)
+     * @param runningButtonText Text to show on button during conversion (e.g., "Converting...")
+     * @param idleButtonText Text to show on button when idle (e.g., "Convert")
+     * @param successTitle Title for success message box
+     * @param successMessage Message for success message box
+     * @param errorTitle Title for error message box
+     * @param errorMessage Message for error message box
+     * @param parent Parent QObject
+     */
+    explicit ConverterRunner(QProgressBar *progressBar,
+                            QLabel *progressLabel,
+                            QPushButton *actionButton,
+                            const QString &runningButtonText,
+                            const QString &idleButtonText,
+                            const QString &successTitle,
+                            const QString &successMessage,
+                            const QString &errorTitle,
+                            const QString &errorMessage,
+                            QObject *parent = nullptr);
+
+    ~ConverterRunner() override;
+
+    /**
+     * @brief Run conversion in a separate thread
+     * @param inputPath Input file path
+     * @param outputPath Output file path
+     * @param encodeParam Encoding parameters (ownership transferred to runner)
+     * @param processParam Process parameters (ownership transferred to runner)
+     * @param transcoderName Transcoder name (default: "FFMPEG")
+     * @return true if conversion started successfully, false if validation failed
+     */
+    bool RunConversion(const QString &inputPath,
+                      const QString &outputPath,
+                      EncodeParameter *encodeParam,
+                      ProcessParameter *processParam,
+                      const QString &transcoderName = "FFMPEG");
+
+    /**
+     * @brief Set custom validation function
+     * @param validator Function that returns true if validation passes, false otherwise
+     */
+    void SetValidator(std::function<bool()> validator);
+
+    /**
+     * @brief Set custom completion handler (called before showing message box)
+     * @param handler Function called with success status
+     */
+    void SetCompletionHandler(std::function<void(bool)> handler);
+
+    // ProcessObserver interface
+    void on_process_update(double progress) override;
+    void on_time_update(double timeRequired) override;
+
+signals:
+    /**
+     * @brief Emitted when conversion finishes
+     * @param success true if conversion succeeded, false otherwise
+     */
+    void ConversionFinished(bool success);
+
+private:
+    void ShowProgressUI();
+    void HideProgressUI();
+    void SetButtonRunning();
+    void SetButtonIdle();
+    void ShowCompletionMessage(bool success);
+
+    QProgressBar *progressBar;
+    QLabel *progressLabel;
+    QPushButton *actionButton;
+    QString runningButtonText;
+    QString idleButtonText;
+    QString successTitle;
+    QString successMessage;
+    QString errorTitle;
+    QString errorMessage;
+
+    std::function<bool()> customValidator;
+    std::function<void(bool)> customCompletionHandler;
+};
+
+#endif // CONVERTER_RUNNER_H

src/builder/include/cut_video_page.h

@@ -19,21 +19,20 @@
 #define CUT_VIDEO_PAGE_H
 
 #include "base_page.h"
+#include "converter_runner.h"
 #include "file_selector_widget.h"
 #include "simple_video_player.h"
-#include "../../common/include/process_observer.h"
 #include <QGroupBox>
 #include <QLabel>
 #include <QProgressBar>
 #include <QPushButton>
 #include <QSlider>
-#include <QThread>
 #include <QTimeEdit>
 
 class EncodeParameter;
 class ProcessParameter;
 
-class CutVideoPage : public BasePage, public ProcessObserver {
+class CutVideoPage : public BasePage {
     Q_OBJECT
 
 public:
@@ -45,10 +44,6 @@ class CutVideoPage : public BasePage, public ProcessObserver {
     QString GetPageTitle() const override { return "Cut Video"; }
     void RetranslateUi() override;
 
-    // ProcessObserver interface
-    void on_process_update(double progress) override;
-    void on_time_update(double timeRequired) override;
-
 protected:
     void OnInputFileChanged(const QString &newPath) override;
     void OnOutputPathUpdate() override;
@@ -79,8 +74,6 @@ private slots:
     void UpdateTimeLabels();
     void UpdateDurationLabel();
     QString FormatTime(qint64 milliseconds);
-    void RunCutInThread(const QString &inputPath, const QString &outputPath,
-                        EncodeParameter *encodeParam, ProcessParameter *processParam);
 
     // Input/Output section
     FileSelectorWidget *inputFileSelector;
@@ -118,6 +111,9 @@ private slots:
     // Action section
     QPushButton *cutButton;
 
+    // Conversion runner
+    ConverterRunner *converterRunner;
+
     // State
     qint64 videoDuration;  // in milliseconds
     qint64 startTime;      // in milliseconds

src/builder/include/extract_audio_page.h

@@ -19,20 +19,16 @@
 #define EXTRACT_AUDIO_PAGE_H
 
 #include "base_page.h"
+#include "converter_runner.h"
 #include "file_selector_widget.h"
-#include "../../common/include/process_observer.h"
 #include <QComboBox>
 #include <QGroupBox>
 #include <QLabel>
 #include <QProgressBar>
 #include <QPushButton>
 #include <QSpinBox>
-#include <QThread>
 
-class EncodeParameter;
-class ProcessParameter;
-
-class ExtractAudioPage : public BasePage, public ProcessObserver {
+class ExtractAudioPage : public BasePage {
     Q_OBJECT
 
 public:
@@ -44,10 +40,6 @@ class ExtractAudioPage : public BasePage, public ProcessObserver {
     QString GetPageTitle() const override { return "Extract Audio"; }
     void RetranslateUi() override;
 
-    // ProcessObserver interface
-    void on_process_update(double progress) override;
-    void on_time_update(double timeRequired) override;
-
 protected:
     void OnOutputPathUpdate() override;
 
@@ -64,8 +56,6 @@ private slots:
 private:
     void SetupUI();
     void UpdateOutputPath();
-    void RunExtractInThread(const QString &inputPath, const QString &outputPath,
-                            EncodeParameter *encodeParam, ProcessParameter *processParam);
     QString DetectAudioCodecFromFile(const QString &filePath);
     QString MapCodecToFormat(const QString &codec);
 
@@ -86,6 +76,9 @@ private slots:
 
     // Action section
     QPushButton *extractButton;
+
+    // Conversion runner
+    ConverterRunner *converterRunner;
 };
 
 #endif // EXTRACT_AUDIO_PAGE_H

src/builder/include/remux_page.h

@@ -19,16 +19,15 @@
 #define REMUX_PAGE_H
 
 #include "base_page.h"
+#include "converter_runner.h"
 #include "file_selector_widget.h"
-#include "../../common/include/process_observer.h"
 #include <QCheckBox>
 #include <QComboBox>
 #include <QGroupBox>
 #include <QLabel>
 #include <QProgressBar>
 #include <QPushButton>
 #include <QScrollArea>
-#include <QThread>
 #include <QVBoxLayout>
 #include <QVector>
 
@@ -47,7 +46,7 @@ struct StreamInfo {
     QCheckBox *checkbox;
 };
 
-class RemuxPage : public BasePage, public ProcessObserver {
+class RemuxPage : public BasePage {
     Q_OBJECT
 
 public:
@@ -59,10 +58,6 @@ class RemuxPage : public BasePage, public ProcessObserver {
     QString GetPageTitle() const override { return "Remux"; }
     void RetranslateUi() override;
 
-    // ProcessObserver interface
-    void on_process_update(double progress) override;
-    void on_time_update(double timeRequired) override;
-
 protected:
     void OnInputFileChanged(const QString &newPath) override;
     void OnOutputPathUpdate() override;
@@ -84,8 +79,6 @@ private slots:
     void ClearStreams();
     QString GetStreamTypeName(int codecType);
     QString FormatBitrate(int64_t bitsPerSec);
-    void RunRemuxInThread(const QString &inputPath, const QString &outputPath,
-                          EncodeParameter *encodeParam, ProcessParameter *processParam);
 
     // Input/Output section
     FileSelectorWidget *inputFileSelector;
@@ -109,6 +102,9 @@ private slots:
 
     // Action section
     QPushButton *remuxButton;
+
+    // Conversion runner
+    ConverterRunner *converterRunner;
 };
 
 #endif // REMUX_PAGE_H

src/builder/include/transcode_page.h

@@ -19,20 +19,19 @@
 #define TRANSCODE_PAGE_H
 
 #include "base_page.h"
+#include "converter_runner.h"
 #include "file_selector_widget.h"
-#include "../../common/include/process_observer.h"
 #include <QComboBox>
 #include <QGroupBox>
 #include <QLabel>
 #include <QProgressBar>
 #include <QPushButton>
 #include <QSpinBox>
-#include <QThread>
 
 class EncodeParameter;
 class ProcessParameter;
 
-class TranscodePage : public BasePage, public ProcessObserver {
+class TranscodePage : public BasePage {
     Q_OBJECT
 
 public:
@@ -44,10 +43,6 @@ class TranscodePage : public BasePage, public ProcessObserver {
     QString GetPageTitle() const override { return "Transcode"; }
     void RetranslateUi() override;
 
-    // ProcessObserver interface
-    void on_process_update(double progress) override;
-    void on_time_update(double timeRequired) override;
-
 protected:
     void OnInputFileChanged(const QString &newPath) override;
     void OnOutputPathUpdate() override;
@@ -67,8 +62,6 @@ private slots:
     void SetupUI();
     void UpdateOutputPath();
     QString GetFileExtension(const QString &filePath);
-    void RunTranscodeInThread(const QString &inputPath, const QString &outputPath,
-                              EncodeParameter *encodeParam, ProcessParameter *processParam);
 
     // Input/Output section
     FileSelectorWidget *inputFileSelector;
@@ -112,6 +105,9 @@ private slots:
 
     // Action section
     QPushButton *transcodeButton;
+
+    // Conversion runner
+    ConverterRunner *converterRunner;
 };
 
 #endif // TRANSCODE_PAGE_H