Skip to content

Commit 21cb8a1

Browse files
committed
fixed 2 new Sonar issues cpp:S5319
1 parent 8b0cefe commit 21cb8a1

File tree

4 files changed

+10
-10
lines changed

4 files changed

+10
-10
lines changed

include/libcyphal/transport/can/delegate.hpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ class IRxSessionDelegate
126126

127127
/// @brief Accepts a received transfer from the transport dedicated to this RX session.
128128
///
129-
virtual void acceptRxTransfer(CanardMemory&& canard_memory,
129+
virtual void acceptRxTransfer(CanardMemory&& lizard_memory,
130130
const TransferRxMetadata& rx_metadata,
131131
const NodeId source_node_id) = 0;
132132

@@ -569,7 +569,7 @@ class TransportDelegate
569569
private:
570570
// IRxSessionDelegate
571571

572-
void acceptRxTransfer(CanardMemory&& canard_memory,
572+
void acceptRxTransfer(CanardMemory&& lizard_memory,
573573
const TransferRxMetadata& rx_metadata,
574574
const NodeId source_node_id) override
575575
{
@@ -579,7 +579,7 @@ class TransportDelegate
579579
const ResponseRxParams params{0, subscription_.port_id, source_node_id};
580580
if (auto* const session_delegate = transport_delegate_.tryFindRxSessionDelegateFor(params))
581581
{
582-
session_delegate->acceptRxTransfer(std::move(canard_memory), rx_metadata, source_node_id);
582+
session_delegate->acceptRxTransfer(std::move(lizard_memory), rx_metadata, source_node_id);
583583
}
584584
}
585585

include/libcyphal/transport/can/msg_rx_session.hpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -130,15 +130,15 @@ class MessageRxSession final : private IRxSessionDelegate, public IMessageRxSess
130130

131131
// MARK: IRxSessionDelegate
132132

133-
void acceptRxTransfer(CanardMemory&& canard_memory,
133+
void acceptRxTransfer(CanardMemory&& lizard_memory,
134134
const TransferRxMetadata& rx_metadata,
135135
const NodeId source_node_id) override
136136
{
137137
const cetl::optional<NodeId> publisher_node_id =
138138
source_node_id > CANARD_NODE_ID_MAX ? cetl::nullopt : cetl::make_optional(source_node_id);
139139

140140
const MessageRxMetadata meta{rx_metadata, publisher_node_id};
141-
MessageRxTransfer msg_rx_transfer{meta, ScatteredBuffer{std::move(canard_memory)}};
141+
MessageRxTransfer msg_rx_transfer{meta, ScatteredBuffer{std::move(lizard_memory)}};
142142
if (on_receive_cb_fn_)
143143
{
144144
on_receive_cb_fn_(OnReceiveCallback::Arg{msg_rx_transfer});

include/libcyphal/transport/udp/delegate.hpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,7 @@ class IRxSessionDelegate
214214

215215
/// @brief Accepts a received transfer from the transport dedicated to this RX session.
216216
///
217-
virtual void acceptRxTransfer(UdpardMemory&& udpard_memory,
217+
virtual void acceptRxTransfer(UdpardMemory&& lizard_memory,
218218
const TransferRxMetadata& rx_metadata,
219219
const NodeId source_node_id) = 0;
220220

@@ -519,7 +519,7 @@ class TransportDelegate
519519
private:
520520
// IRxSessionDelegate
521521

522-
void acceptRxTransfer(UdpardMemory&& udpard_memory,
522+
void acceptRxTransfer(UdpardMemory&& lizard_memory,
523523
const TransferRxMetadata& rx_metadata,
524524
const NodeId source_node_id) override
525525
{
@@ -529,7 +529,7 @@ class TransportDelegate
529529
const ResponseRxParams params{0, port_.service_id, source_node_id};
530530
if (auto* const session_delegate = transport_delegate_.tryFindRxSessionDelegateFor(params))
531531
{
532-
session_delegate->acceptRxTransfer(std::move(udpard_memory), rx_metadata, source_node_id);
532+
session_delegate->acceptRxTransfer(std::move(lizard_memory), rx_metadata, source_node_id);
533533
}
534534
}
535535

include/libcyphal/transport/udp/msg_rx_session.hpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -142,15 +142,15 @@ class MessageRxSession final : private IMsgRxSessionDelegate, public IMessageRxS
142142

143143
// MARK: IRxSessionDelegate
144144

145-
void acceptRxTransfer(UdpardMemory&& udpard_memory,
145+
void acceptRxTransfer(UdpardMemory&& lizard_memory,
146146
const TransferRxMetadata& rx_metadata,
147147
const NodeId source_node_id) override
148148
{
149149
const cetl::optional<NodeId> publisher_node_id =
150150
source_node_id > UDPARD_NODE_ID_MAX ? cetl::nullopt : cetl::make_optional(source_node_id);
151151

152152
const MessageRxMetadata meta{rx_metadata, publisher_node_id};
153-
MessageRxTransfer msg_rx_transfer{meta, ScatteredBuffer{std::move(udpard_memory)}};
153+
MessageRxTransfer msg_rx_transfer{meta, ScatteredBuffer{std::move(lizard_memory)}};
154154
if (on_receive_cb_fn_)
155155
{
156156
on_receive_cb_fn_(OnReceiveCallback::Arg{msg_rx_transfer});

0 commit comments

Comments
 (0)