- try fix CI by ts22.4.10 -> ts24.4.3

- minor pr fixes

Author: serges147

.devcontainer/devcontainer.json

@@ -1,6 +1,6 @@
 {
     "name": "linux development environment for libcyphal",
-    "image": "ghcr.io/opencyphal/toolshed:ts22.4.10",
+    "image": "ghcr.io/opencyphal/toolshed:ts24.4.3",
     "customizations": {
         "vscode": {
             "extensions": [

.github/workflows/sonar.yml

@@ -15,7 +15,7 @@ jobs:
       contains(github.ref, '/issue/') ||
       (github.event_name == 'pull_request')
     runs-on: ubuntu-latest
-    container: ghcr.io/opencyphal/toolshed:ts22.4.10
+    container: ghcr.io/opencyphal/toolshed:ts24.4.3
     steps:
       - uses: actions/checkout@v4
         with:

.github/workflows/tests.yml

@@ -16,7 +16,7 @@ jobs:
       contains(github.ref, '/issue/') ||
       (github.event_name == 'pull_request')
     runs-on: ubuntu-latest
-    container: ghcr.io/opencyphal/toolshed:ts22.4.10
+    container: ghcr.io/opencyphal/toolshed:ts24.4.3
     steps:
       - uses: actions/checkout@v4
       - name: Cache ext modules
@@ -47,7 +47,7 @@ jobs:
       contains(github.ref, '/issue/') ||
       (github.event_name == 'pull_request')
     runs-on: ubuntu-latest
-    container: ghcr.io/opencyphal/toolshed:ts22.4.10
+    container: ghcr.io/opencyphal/toolshed:ts24.4.3
     needs: [warmup]
     strategy:
       matrix:
@@ -101,7 +101,7 @@ jobs:
       contains(github.ref, '/issue/') ||
       (github.event_name == 'pull_request')
     runs-on: ubuntu-latest
-    container: ghcr.io/opencyphal/toolshed:ts22.4.10
+    container: ghcr.io/opencyphal/toolshed:ts24.4.3
     needs: [warmup]
     steps:
     - uses: actions/checkout@v4

CONTRIBUTING.md

@@ -147,10 +147,10 @@ and manually run it.
 
 ### TLDR
 ```
-docker pull ghcr.io/opencyphal/toolshed:ts22.4.10
+docker pull ghcr.io/opencyphal/toolshed:ts24.4.3
 git clone {this repo}
 cd {this repo}
-docker run --rm -it -v ${PWD}:/repo ghcr.io/opencyphal/toolshed:ts22.4.10
+docker run --rm -it -v ${PWD}:/repo ghcr.io/opencyphal/toolshed:ts24.4.3
 mkdir build
 cd build
 cmake ..
@@ -200,7 +200,7 @@ To ensure that the formatting matches the expectations of the CI suite,
 invoke Clang-Format of the correct version from the container (be sure to use the correct image tag):
 
 ```
-docker run --rm -v ${PWD}:/repo ghcr.io/opencyphal/toolshed:ts22.4.10 ./build-tools/bin/verify.py build-danger-danger-repo-clang-format-in-place
+docker run --rm -v ${PWD}:/repo ghcr.io/opencyphal/toolshed:ts24.4.3 ./build-tools/bin/verify.py build-danger-danger-repo-clang-format-in-place
 ```
 
 ### `issue/*` and hashtag-based CI triggering

docs/examples/1_presentation/example_1_presentation_2_heartbeat_getinfo_udp.cpp

@@ -176,7 +176,7 @@ TEST_F(Example_1_Presentation_2_Heartbeat_GetInfo_Udp, main)
 
     // Bring up 'GetInfo' server.
     //
-    using GetInfo_1_0 = uavcan::node::GetInfo_1_0;
+    using uavcan::node::GetInfo_1_0;
     const std::string node_name{"org.opencyphal.Ex_1_Pres_2_HB_GetInfo_UDP"};
     std::copy_n(node_name.begin(), std::min(node_name.size(), 50UL), std::back_inserter(state.get_info_response.name));
     //

docs/examples/1_presentation/example_1_presentation_3_hb_getinfo_ping_linux_can.cpp

@@ -424,8 +424,8 @@ TEST_F(Example_1_Presentation_3_HB_GetInfo_Ping_Can, main)
 
     // 7. Bring up 'GetInfo' server.
     //
-    using GetInfo_1_0 = uavcan::node::GetInfo_1_0;
-    uavcan::node::GetInfo_1_0::Response get_info_response{{&mr_}};
+    using uavcan::node::GetInfo_1_0;
+    GetInfo_1_0::Response get_info_response{{&mr_}};
     get_info_response.protocol_version.major = 1;
     const std::string node_name{"org.opencyphal.Ex_1_Pres_3_HB_GetInfo_Ping_CAN"};
     std::copy_n(node_name.begin(), std::min(node_name.size(), 50UL), std::back_inserter(get_info_response.name));

docs/examples/platform/node_helpers.hpp

@@ -69,15 +69,15 @@ struct NodeHelpers
                                                                              TxSession&        tx_session,
                                                                              const TxMetadata& metadata)
     {
-        using traits          = typename T::_traits_;
-        using PayloadFragment = libcyphal::transport::PayloadFragment;
+        using traits = typename T::_traits_;
+        using libcyphal::transport::PayloadFragment;
 
         std::array<std::uint8_t, traits::SerializationBufferSizeBytes> buffer{};
 
         const auto data_size = serialize(value, buffer).value();
 
         // NOLINTNEXTLINE
-        const PayloadFragment fragment{reinterpret_cast<cetl::byte*>(buffer.data()), data_size};
+        const PayloadFragment                      fragment{reinterpret_cast<cetl::byte*>(buffer.data()), data_size};
         const std::array<const PayloadFragment, 1> payload{fragment};
 
         return tx_session.send(metadata, payload);

include/libcyphal/transport/can/can_transport_impl.hpp

@@ -109,7 +109,7 @@ class TransportImpl final : private TransportDelegate, public ICanTransport
     private:
         CETL_NODISCARD static CanardMemoryResource makeTxMemoryResource(IMedia& media_interface)
         {
-            using LizardHelpers = libcyphal::transport::detail::LizardHelpers;
+            using transport::detail::LizardHelpers;
 
             // TX memory resource is used for raw bytes block allocations only.
             // So it has no alignment requirements.

include/libcyphal/transport/udp/udp_transport_impl.hpp

@@ -119,7 +119,7 @@ class TransportImpl final : private TransportDelegate, public IUdpTransport
     private:
         CETL_NODISCARD static UdpardMemoryResource makeTxMemoryResource(IMedia& media_interface)
         {
-            using LizardHelpers = libcyphal::transport::detail::LizardHelpers;
+            using transport::detail::LizardHelpers;
 
             // TX memory resource is used for raw bytes block allocations only.
             // So it has no alignment requirements.

test/unittest/platform/test_single_threaded_executor.cpp

@@ -27,10 +27,10 @@
 namespace
 {
 
-using Duration  = libcyphal::Duration;
-using TimePoint = libcyphal::TimePoint;
-using Callback  = libcyphal::IExecutor::Callback;
-using Schedule  = libcyphal::IExecutor::Callback::Schedule;
+using libcyphal::Duration;
+using libcyphal::TimePoint;
+using Callback = libcyphal::IExecutor::Callback;
+using Schedule = libcyphal::IExecutor::Callback::Schedule;
 using namespace libcyphal::platform;  // NOLINT This our main concern here in the unit tests.
 
 using testing::Eq;