clang-tidy 19 fixes

Author: serges147

.clang-tidy

@@ -12,6 +12,7 @@ Checks: >-
   performance-*,
   portability-*,
   readability-*,
+  -boost-use-ranges,
   -clang-analyzer-core.uninitialized.Assign,
   -cppcoreguidelines-avoid-const-or-ref-data-members,
   -cppcoreguidelines-use-default-member-init,

include/libcyphal/common/cavl/cavl.hpp

@@ -81,12 +81,12 @@ class Node  // NOSONAR cpp:S1448
     using DerivedType = Derived;
 
     // Tree nodes cannot be copied for obvious reasons.
-    Node(const Node&)                    = delete;
+    Node(const Node&)                    = delete;  // NOLINT bugprone-crtp-constructor-accessibility
     auto operator=(const Node&) -> Node& = delete;
 
     // Tree nodes can be moved. We update the pointers in the adjacent nodes to keep the tree valid,
     // as well as root node pointer if needed (see `moveFrom`). This operation is constant time.
-    Node(Node&& other) noexcept
+    Node(Node&& other) noexcept  // NOLINT bugprone-crtp-constructor-accessibility
     {
         moveFrom(other);
     }
@@ -102,7 +102,7 @@ class Node  // NOSONAR cpp:S1448
     }
 
 protected:
-    Node()  = default;
+    Node()  = default;  // NOLINT bugprone-crtp-constructor-accessibility
     ~Node() = default;
 
     /// Accessors for advanced tree introspection. Not needed for typical usage.

include/libcyphal/transport/udp/delegate.hpp

@@ -167,10 +167,10 @@ class UdpardMemory final : public ScatteredBuffer::IStorage
         while ((nullptr != frag) && (dst_offset < length_bytes))
         {
             CETL_DEBUG_ASSERT(nullptr != frag->view.data, "");
-            // Next nolint-s are unavoidable: we need offset from the beginning of the buffer.
+            // Next nolint-s are unavoidable: we need to offset from the beginning of the buffer.
             // No Sonar `cpp:S5356` & `cpp:S5357` b/c we integrate here with libcanard raw C buffers.
-            // NOLINTNEXTLINE(cppcoreguidelines-pro-bounds-pointer-arithmetic)
             const auto* const offset_data =
+                // NOLINTNEXTLINE(cppcoreguidelines-pro-bounds-pointer-arithmetic)
                 static_cast<const cetl::byte*>(frag->view.data) + view_offset;  // NOSONAR cpp:S5356 cpp:S5357
             const PayloadFragment frag_span{offset_data,
                                             std::min(frag->view.size - view_offset, length_bytes - dst_offset)};

test/unittest/common/cavl/.clang-tidy

@@ -11,6 +11,7 @@ Checks: >-
   misc-*,
   portability-*,
   readability-*,
+  -boost-use-ranges,
   -hicpp-function-size,
   -hicpp-no-array-decay,
   -google-readability-todo,

test/unittest/presentation/test_presentation.cpp

@@ -499,7 +499,7 @@ TEST_F(TestPresentation, makeServer_custom)
 
     Presentation presentation{mr_, scheduler_, transport_mock_};
 
-    auto maybe_server = presentation.makeServer<Service>([](const auto&, auto) {});
+    auto maybe_server = presentation.makeServer<Service>([](const auto&, const auto&) {});
     ASSERT_THAT(maybe_server, VariantWith<ServiceServer<Service>>(_));
 
     EXPECT_CALL(req_rx_session_mock, deinit()).Times(1);
@@ -526,7 +526,10 @@ TEST_F(TestPresentation, makeServer_raw)
 
     Presentation presentation{mr_, scheduler_, transport_mock_};
 
-    auto maybe_server = presentation.makeServer(rx_params.service_id, rx_params.extent_bytes, [](const auto&, auto) {});
+    auto maybe_server = presentation.makeServer(  //
+        rx_params.service_id,
+        rx_params.extent_bytes,
+        [](const auto&, const auto&) {});
     ASSERT_THAT(maybe_server, VariantWith<RawServiceServer>(_));
 
     EXPECT_CALL(req_rx_session_mock, deinit()).Times(1);

test/unittest/transport/can/test_can_msg_tx_session.cpp

@@ -190,7 +190,7 @@ TEST_F(TestCanMsgTxSession, send_empty_payload)
                 return IMedia::PushResult::Success{false /* is_accepted */};
             });
         EXPECT_CALL(media_mock_, registerPushCallback(_))  //
-            .WillOnce(Invoke([](auto) { return libcyphal::IExecutor::Callback::Any{}; }));
+            .WillOnce(Invoke([](const auto&) { return libcyphal::IExecutor::Callback::Any{}; }));
 
         metadata.deadline = now() + timeout;
         auto failure      = session->send(metadata, empty_payload);

test/unittest/transport/can/test_can_svc_tx_sessions.cpp

@@ -195,7 +195,7 @@ TEST_F(TestCanSvcTxSessions, send_request)
                 return IMedia::PushResult::Success{true /* is_accepted */};
             });
         EXPECT_CALL(media_mock_, registerPushCallback(_))  //
-            .WillOnce(Invoke([](auto) { return libcyphal::IExecutor::Callback::Any{}; }));
+            .WillOnce(Invoke([](const auto&) { return libcyphal::IExecutor::Callback::Any{}; }));
 
         metadata.deadline  = now() + timeout;
         const auto failure = session->send(metadata, empty_payload);
@@ -247,7 +247,7 @@ TEST_F(TestCanSvcTxSessions, send_request_with_argument_error)
                 return IMedia::PushResult::Success{true /* is_accepted */};
             });
         EXPECT_CALL(media_mock_, registerPushCallback(_))  //
-            .WillOnce(Invoke([](auto) { return libcyphal::IExecutor::Callback::Any{}; }));
+            .WillOnce(Invoke([](const auto&) { return libcyphal::IExecutor::Callback::Any{}; }));
 
         metadata.deadline  = now() + timeout;
         const auto failure = session->send(metadata, empty_payload);

test/unittest/transport/udp/test_udp_msg_tx_session.cpp

@@ -269,7 +269,7 @@ TEST_F(TestUdpMsgTxSession, send_empty_payload)
         EXPECT_CALL(tx_socket_mock_, send(_, _, _, _))
             .WillOnce(Return(ITxSocket::SendResult::Success{false /* is_accepted */}));
         EXPECT_CALL(tx_socket_mock_, registerCallback(_))  //
-            .WillOnce(Invoke([](auto) { return libcyphal::IExecutor::Callback::Any{}; }));
+            .WillOnce(Invoke([](const auto&) { return libcyphal::IExecutor::Callback::Any{}; }));
 
         metadata.deadline = now() + 1s;
         auto failure      = session->send(metadata, empty_payload);

test/unittest/transport/udp/test_udp_svc_tx_sessions.cpp

@@ -286,7 +286,7 @@ TEST_F(TestUdpSvcTxSessions, send_empty_payload_request)
         EXPECT_CALL(tx_socket_mock_, send(_, _, _, _))
             .WillOnce(Return(ITxSocket::SendResult::Success{false /* is_accepted */}));
         EXPECT_CALL(tx_socket_mock_, registerCallback(_))  //
-            .WillOnce(Invoke([](auto) { return libcyphal::IExecutor::Callback::Any{}; }));
+            .WillOnce(Invoke([](const auto&) { return libcyphal::IExecutor::Callback::Any{}; }));
 
         metadata.deadline = now() + 1s;
         auto failure      = session->send(metadata, empty_payload);
@@ -349,7 +349,7 @@ TEST_F(TestUdpSvcTxSessions, send_empty_payload_responce)
         EXPECT_CALL(tx_socket_mock_, send(_, _, _, _))
             .WillOnce(Return(ITxSocket::SendResult::Success{false /* is_accepted */}));
         EXPECT_CALL(tx_socket_mock_, registerCallback(_))  //
-            .WillOnce(Invoke([](auto) { return libcyphal::IExecutor::Callback::Any{}; }));
+            .WillOnce(Invoke([](const auto&) { return libcyphal::IExecutor::Callback::Any{}; }));
 
         metadata.tx_meta.deadline = now() + 1s;
         auto failure              = session->send(metadata, empty_payload);