fix clang-tidy issues

Author: serges147

src/daemon/main.cpp

@@ -391,30 +391,39 @@ int main(const int argc, const char** const argv)
     setupLogging(pipe_write_fd, should_daemonize, argc, argv);
 
     spdlog::info("OCVSMD started (ver='{}.{}').", VERSION_MAJOR, VERSION_MINOR);
+    int result = EXIT_SUCCESS;
     {
-        Application application;
-        if (const auto failure_str = application.init())
+        try
         {
-            spdlog::critical("Failed to init application: {}", failure_str.value());
-
-            // Report the failure to the parent process (if daemonized; otherwise goes to stderr).
-            writeString(pipe_write_fd, "Failed to init application: ");
-            writeString(pipe_write_fd, failure_str.value().c_str());
-            ::exit(EXIT_FAILURE);
-        }
-        if (should_daemonize)
+            Application application;
+            if (const auto failure_str = application.init())
+            {
+                spdlog::critical("Failed to init application: {}", failure_str.value());
+
+                // Report the failure to the parent process (if daemonized; otherwise goes to stderr).
+                writeString(pipe_write_fd, "Failed to init application: ");
+                writeString(pipe_write_fd, failure_str.value().c_str());
+                ::exit(EXIT_FAILURE);
+            }
+            if (should_daemonize)
+            {
+                step_14_notify_init_complete(pipe_write_fd);
+            }
+
+            application.runWhile([] { return g_running == 1; });
+
+        } catch (const std::exception& ex)
         {
-            step_14_notify_init_complete(pipe_write_fd);
+            spdlog::critical("Unhandled exception: {}", ex.what());
+            result = EXIT_FAILURE;
         }
 
-        application.runWhile([] { return g_running == 1; });
-
         if (g_running == 0)
         {
             spdlog::debug("Received termination signal.");
         }
     }
     spdlog::info("OCVSMD daemon terminated.");
 
-    return EXIT_SUCCESS;
+    return result;
 }

src/sdk/daemon.cpp

@@ -69,12 +69,13 @@ class DaemonImpl final : public Daemon
                     },
                     [this](const ExecCmdChannel::Input& input) {
                         //
+                        // NOLINTNEXTLINE
                         logger_->info("C << 🔵 Ch Msg='{}'.", reinterpret_cast<const char*>(input.some_stuff.data()));
 
                         if (countdown_--)
                         {
                             logger_->info("C >> 🔵 Ch '{}' msg.",
-                                          reinterpret_cast<const char*>(input.some_stuff.data()));
+                                          reinterpret_cast<const char*>(input.some_stuff.data()));  // NOLINT
                             const int result = ipc_exec_cmd_ch_->send(input);
                             (void) result;
                         }

test/common/ipc/test_server_router.cpp

@@ -224,11 +224,11 @@ TEST_F(TestServerRouter, channel_send)
     const Channel::Output msg{&mr_};
     EXPECT_CALL(server_pipe_mock, send(cl_id, PayloadOfRouteChannelMsg(msg, mr_, tag, seq++)))  //
         .WillOnce(Return(0));
-    EXPECT_THAT(maybe_channel->send(msg), 0);
+    EXPECT_THAT(maybe_channel->send(msg), 0);  // NOLINT
 
     EXPECT_CALL(server_pipe_mock, send(cl_id, PayloadOfRouteChannelMsg(msg, mr_, tag, seq++)))  //
         .WillOnce(Return(0));
-    EXPECT_THAT(maybe_channel->send(msg), 0);
+    EXPECT_THAT(maybe_channel->send(msg), 0);  // NOLINT
 }
 
 // NOLINTEND(cppcoreguidelines-avoid-magic-numbers, readability-magic-numbers)