tests

Author: pavel-kirienko

tests/src/test_intrusive_header.c

@@ -17,14 +17,14 @@ static void test_header_v2(void)
         .sender_uid            = 0x1122334455667788ULL,
         .topic_hash            = 0x99AABBCCDDEEFF00ULL,
     };
-    header_serialize(buffer, meta_in, true, 0x00123456, 0x00654321, 0x11223344);
+    header_serialize(buffer, meta_in, 0x00123456, 0x00654321, 0x11223344);
 
     // >>> from pycyphal.transport.commons.crc import CRC32C
     // >>> list(CRC32C.new(data).value_as_bytes)
     // clang-format off
     const byte_t reference[48] = {
         (2U | ((size_t)udpard_prio_high << 5U)),            // version | priority
-        (HEADER_FLAG_EOT),                                  // flags
+        0,                                                  // flags
         0, 0,                                               // reserved
         0x56, 0x34, 0x12, 0x00,                             // frame_index
         0x21, 0x43, 0x65, 0x00,                             // frame_payload_offset
@@ -33,20 +33,18 @@ static void test_header_v2(void)
         0x88, 0x77, 0x66, 0x55, 0x44, 0x33, 0x22, 0x11,     // sender_uid
         0x00, 0xFF, 0xEE, 0xDD, 0xCC, 0xBB, 0xAA, 0x99,     // topic_hash
         0x44, 0x33, 0x22, 0x11,                             // prefix_crc
-        113, 119, 83, 71                                    // header CRC
+        224, 92, 8, 213                                     // header CRC
     };
     // clang-format on
     TEST_ASSERT_EQUAL_MEMORY(reference, buffer, HEADER_SIZE_BYTES);
 
     meta_t             meta_out;
     udpard_bytes_mut_t payload_out;
-    bool               flag_eot             = false;
     uint32_t           frame_index          = 0;
     uint32_t           frame_payload_offset = 0;
     uint32_t           prefix_crc           = 0;
     TEST_ASSERT(header_deserialize((udpard_bytes_mut_t){ .size = sizeof(buffer), .data = buffer },
                                    &meta_out,
-                                   &flag_eot,
                                    &frame_index,
                                    &frame_payload_offset,
                                    &prefix_crc,
@@ -55,7 +53,6 @@ static void test_header_v2(void)
     TEST_ASSERT_EQUAL(&buffer[HEADER_SIZE_BYTES], payload_out.data);
 
     TEST_ASSERT_EQUAL_UINT8(meta_in.priority, meta_out.priority);
-    TEST_ASSERT_TRUE(flag_eot);
     TEST_ASSERT_FALSE(meta_out.flag_ack);
     TEST_ASSERT_EQUAL_UINT32(0x00123456, frame_index);
     TEST_ASSERT_EQUAL_UINT32(0x00654321, frame_payload_offset);
@@ -67,23 +64,20 @@ static void test_header_v2(void)
 
     TEST_ASSERT_FALSE(header_deserialize((udpard_bytes_mut_t){ .size = 23, .data = buffer },
                                          &meta_out,
-                                         &flag_eot,
                                          &frame_index,
                                          &frame_payload_offset,
                                          &prefix_crc,
                                          &payload_out));
 
     TEST_ASSERT(header_deserialize((udpard_bytes_mut_t){ .size = sizeof(buffer), .data = buffer },
                                    &meta_out,
-                                   &flag_eot,
                                    &frame_index,
                                    &frame_payload_offset,
                                    &prefix_crc,
                                    &payload_out));
     buffer[HEADER_SIZE_BYTES - 1] ^= 0xFFU; // Corrupt the CRC.
     TEST_ASSERT_FALSE(header_deserialize((udpard_bytes_mut_t){ .size = sizeof(buffer), .data = buffer },
                                          &meta_out,
-                                         &flag_eot,
                                          &frame_index,
                                          &frame_payload_offset,
                                          &prefix_crc,

tests/src/test_intrusive_tx.c

@@ -38,27 +38,12 @@ static void test_tx_serialize_header(void)
                .sender_uid            = 0x0123456789ABCDEFULL,
                .topic_hash            = 0xFEDCBA9876543210ULL,
         };
-        (void)header_serialize(buffer.data, meta, false, 12345, 0, 0);
+        (void)header_serialize(buffer.data, meta, 12345, 0, 0);
         TEST_ASSERT_EQUAL(HEADER_SIZE_BYTES, sizeof(buffer.data));
         // Verify version and priority in first byte
         TEST_ASSERT_EQUAL((HEADER_VERSION | ((unsigned)udpard_prio_fast << 5U)), buffer.data[0]);
     }
-    // Test case 2: End of transfer flag
-    {
-        header_buffer_t buffer;
-        const meta_t    meta = {
-               .priority              = udpard_prio_low,
-               .flag_ack              = false,
-               .transfer_payload_size = 1234,
-               .transfer_id           = 0x0BADC0DE0BADC0DEULL,
-               .sender_uid            = 0xFEDCBA9876543210ULL,
-               .topic_hash            = 0x0123456789ABCDEFULL,
-        };
-        (void)header_serialize(buffer.data, meta, true, 0x7FFF, 100, 0);
-        TEST_ASSERT_EQUAL((HEADER_VERSION | ((unsigned)udpard_prio_low << 5U)), buffer.data[0]);
-        TEST_ASSERT_EQUAL(HEADER_FLAG_EOT, buffer.data[1]);
-    }
-    // Test case 3: Ack flag
+    // Test case 2: Ack flag
     {
         header_buffer_t buffer;
         const meta_t    meta = {
@@ -69,7 +54,7 @@ static void test_tx_serialize_header(void)
                .sender_uid            = 0xBBBBBBBBBBBBBBBBULL,
                .topic_hash            = 0xCCCCCCCCCCCCCCCCULL,
         };
-        (void)header_serialize(buffer.data, meta, false, 100, 200, 0);
+        (void)header_serialize(buffer.data, meta, 100, 200, 0);
         TEST_ASSERT_EQUAL((HEADER_VERSION | ((unsigned)udpard_prio_nominal << 5U)), buffer.data[0]);
         TEST_ASSERT_EQUAL(HEADER_FLAG_ACK, buffer.data[1]);
     }