fix tests

Author: pavel-kirienko

libudpard/udpard.c

@@ -473,7 +473,7 @@ static tx_chain_t tx_spool(const udpard_tx_mem_resources_t memory,
     uint32_t   prefix_crc = CRC_INITIAL;
     tx_chain_t out        = { NULL, NULL, 0 };
     size_t     offset     = 0U;
-    while (offset < payload.size) {
+    do {
         const size_t            progress = smaller(payload.size - offset, mtu);
         udpard_tx_item_t* const item     = tx_item_new(memory, //
                                                    deadline,
@@ -504,7 +504,7 @@ static tx_chain_t tx_spool(const udpard_tx_mem_resources_t memory,
         UDPARD_ASSERT(offset <= payload.size);
         UDPARD_ASSERT((!last) || (offset == payload.size));
         out.count++;
-    }
+    } while (offset < payload.size);
     UDPARD_ASSERT((offset == payload.size) || (out.tail == NULL));
     return out;
 }
@@ -519,7 +519,7 @@ static uint32_t tx_push(udpard_tx_t* const         tx,
     UDPARD_ASSERT(tx != NULL);
     uint32_t     out         = 0; // The number of frames enqueued; zero on error (error counters incremented).
     const size_t mtu         = larger(tx->mtu, UDPARD_MTU_MIN);
-    const size_t frame_count = (payload.size + mtu - 1U) / mtu;
+    const size_t frame_count = larger(1, (payload.size + mtu - 1U) / mtu);
     if ((tx->queue_size + frame_count) > tx->queue_capacity) {
         tx->errors_capacity++;
     } else {

tests/src/test_intrusive_header.c

@@ -17,7 +17,7 @@ static void test_header_v2(void)
         .sender_uid            = 0x1122334455667788ULL,
         .topic_hash            = 0x99AABBCCDDEEFF00ULL,
     };
-    header_serialize(buffer, meta_in, true, 0x00123456, 0x00654321);
+    header_serialize(buffer, meta_in, true, 0x00123456, 0x00654321, 0x11223344);
 
     // >>> from pycyphal.transport.commons.crc import CRC32C
     // >>> list(CRC32C.new(data).value_as_bytes)
@@ -32,8 +32,8 @@ static void test_header_v2(void)
         0x11, 0x00, 0xFF, 0xEE, 0xDD, 0xCC, 0xBB, 0xAA,     // transfer_id
         0x88, 0x77, 0x66, 0x55, 0x44, 0x33, 0x22, 0x11,     // sender_uid
         0x00, 0xFF, 0xEE, 0xDD, 0xCC, 0xBB, 0xAA, 0x99,     // topic_hash
-        0, 0, 0, 0,                                         // reserved
-        8, 200, 228, 86                                     // header CRC
+        0x44, 0x33, 0x22, 0x11,                             // prefix_crc
+        113, 119, 83, 71                                    // header CRC
     };
     // clang-format on
     TEST_ASSERT_EQUAL_MEMORY(reference, buffer, HEADER_SIZE_BYTES);
@@ -43,11 +43,13 @@ static void test_header_v2(void)
     bool               flag_eot             = false;
     uint32_t           frame_index          = 0;
     uint32_t           frame_payload_offset = 0;
+    uint32_t           prefix_crc           = 0;
     TEST_ASSERT(header_deserialize((udpard_bytes_mut_t){ .size = sizeof(buffer), .data = buffer },
                                    &meta_out,
                                    &flag_eot,
                                    &frame_index,
                                    &frame_payload_offset,
+                                   &prefix_crc,
                                    &payload_out));
     TEST_ASSERT_EQUAL(sizeof(buffer) - HEADER_SIZE_BYTES, payload_out.size);
     TEST_ASSERT_EQUAL(&buffer[HEADER_SIZE_BYTES], payload_out.data);
@@ -57,6 +59,7 @@ static void test_header_v2(void)
     TEST_ASSERT_FALSE(meta_out.flag_ack);
     TEST_ASSERT_EQUAL_UINT32(0x00123456, frame_index);
     TEST_ASSERT_EQUAL_UINT32(0x00654321, frame_payload_offset);
+    TEST_ASSERT_EQUAL_UINT32(0x11223344, prefix_crc);
     TEST_ASSERT_EQUAL_UINT32(meta_in.transfer_payload_size, meta_out.transfer_payload_size);
     TEST_ASSERT_EQUAL_UINT64(meta_in.transfer_id, meta_out.transfer_id);
     TEST_ASSERT_EQUAL_UINT64(meta_in.sender_uid, meta_out.sender_uid);
@@ -67,20 +70,23 @@ static void test_header_v2(void)
                                          &flag_eot,
                                          &frame_index,
                                          &frame_payload_offset,
+                                         &prefix_crc,
                                          &payload_out));
 
     TEST_ASSERT(header_deserialize((udpard_bytes_mut_t){ .size = sizeof(buffer), .data = buffer },
                                    &meta_out,
                                    &flag_eot,
                                    &frame_index,
                                    &frame_payload_offset,
+                                   &prefix_crc,
                                    &payload_out));
     buffer[HEADER_SIZE_BYTES - 1] ^= 0xFFU; // Corrupt the CRC.
     TEST_ASSERT_FALSE(header_deserialize((udpard_bytes_mut_t){ .size = sizeof(buffer), .data = buffer },
                                          &meta_out,
                                          &flag_eot,
                                          &frame_index,
                                          &frame_payload_offset,
+                                         &prefix_crc,
                                          &payload_out));
 }