add intrusive tx test

Author: pavel-kirienko

.gitignore

@@ -22,6 +22,7 @@
 *build/
 cmake-build-*/
 build-avr/
+.cache/
 .metadata
 .settings
 .project

.zed/tasks.json

@@ -0,0 +1,37 @@
+[
+  {
+    "label": "Configure (CMake)",
+    "command": "cmake -B build",
+    "tags": ["build"]
+  },
+  {
+    "label": "Build",
+    "command": "cmake --build build",
+    "tags": ["build"]
+  },
+  {
+    "label": "Configure and Build",
+    "command": "cmake -B build && cmake --build build",
+    "tags": ["build"]
+  },
+  {
+    "label": "Run Tests",
+    "command": "ctest --test-dir build --output-on-failure",
+    "tags": ["test"]
+  },
+  {
+    "label": "Clean",
+    "command": "rm -rf build",
+    "tags": ["build"]
+  },
+  {
+    "label": "Format Code",
+    "command": "cmake --build build --target format",
+    "tags": ["format"]
+  },
+  {
+    "label": "Full Build and Test",
+    "command": "cmake -B build && cmake --build build && ctest --test-dir build --output-on-failure",
+    "tags": ["build", "test"]
+  }
+]

AGENTS.md

@@ -0,0 +1,5 @@
+# LibUDPard instructions for agents
+
+Please read README.md for general information about LibUDPard.
+Read `.clang-format` and `**/.clang-tidy` to understand the coding style used in this project.
+Avoid blank lines inside function bodies. Avoid redundant comments that do not add new information.

CMakeLists.txt

@@ -12,6 +12,8 @@ cmake_minimum_required(VERSION 3.20)
 project(udpard)
 enable_testing()
 
+set(CMAKE_EXPORT_COMPILE_COMMANDS ON)
+
 # Shared Clang-Format target for all subprojects.
 find_program(clang_format NAMES clang-format)
 if (NOT clang_format)

libudpard/udpard.c

@@ -436,23 +436,25 @@ static uint32_t tx_push(udpard_tx_t* const         tx,
 static uint64_t tx_purge_expired(udpard_tx_t* const self, const udpard_microsecond_t now)
 {
     uint64_t count = 0;
-    for (udpard_tree_t* p = cavl2_min(self->index_deadline); p != NULL; p = cavl2_next_greater(p)) {
+    for (udpard_tree_t* p = cavl2_min(self->index_deadline); p != NULL;) {
         udpard_tx_item_t* const item = CAVL2_TO_OWNER(p, udpard_tx_item_t, index_deadline);
         if (item->deadline >= now) {
             break;
         }
+        udpard_tree_t* const next = cavl2_next_greater(p); // Get next before removing current node from tree.
         // Remove from both indices.
         cavl2_remove(&self->index_deadline, &item->index_deadline);
         cavl2_remove(&self->index_prio, &item->index_prio);
         // Free the entire transfer chain.
         udpard_tx_item_t* current = item;
         while (current != NULL) {
-            udpard_tx_item_t* const next = current->next_in_transfer;
+            udpard_tx_item_t* const next_in_transfer = current->next_in_transfer;
             udpard_tx_free(self->memory, current);
-            current = next;
+            current = next_in_transfer;
             count++;
             self->queue_size--;
         }
+        p = next;
     }
     return count;
 }

tests/CMakeLists.txt

@@ -80,3 +80,4 @@ endfunction()
 gen_test_matrix(test_helpers "src/test_helpers.c")
 gen_test_matrix(test_intrusive_header "src/test_intrusive_header.c")
 gen_test_matrix(test_intrusive_crc "src/test_intrusive_crc.c")
+gen_test_matrix(test_intrusive_tx "src/test_intrusive_tx.c")