Skip to content

Commit dc253f9

Browse files
Merge pull request #133 from OpenDTU-App/fix-ios-modal
2 parents 484c6f7 + 2678cc9 commit dc253f9

File tree

3 files changed

+13
-4
lines changed

3 files changed

+13
-4
lines changed

android/app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ android {
113113
minifyEnabled enableProguardInReleaseBuilds
114114
proguardFiles getDefaultProguardFile("proguard-android.txt"), "proguard-rules.pro"
115115
**/
116-
if (false && project.hasProperty('MYAPP_UPLOAD_STORE_FILE')) {
116+
if (project.hasProperty('MYAPP_UPLOAD_STORE_FILE')) {
117117
signingConfig signingConfigs.release
118118
minifyEnabled enableProguardInReleaseBuilds
119119
proguardFiles getDefaultProguardFile("proguard-android.txt"), "proguard-rules.pro"

licenses.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
"licenseUrl": "https://github.com/react-native-masked-view/masked-view/raw/master/LICENSE",
3636
"parents": "opendtu-react-native"
3737
},
38-
"@react-navigation/bottom-tabs@6.5.20": {
38+
"@react-navigation/bottom-tabs@6.6.0": {
3939
"licenses": "MIT",
4040
"repository": "https://github.com/react-navigation/react-navigation",
4141
"licenseUrl": "https://github.com/react-navigation/react-navigation/raw/master/LICENSE",
@@ -209,7 +209,7 @@
209209
"licenseUrl": "https://github.com/callstack/react-native-paper/raw/master/LICENSE.md",
210210
"parents": "opendtu-react-native"
211211
},
212-
"react-native-reanimated@3.11.0": {
212+
"react-native-reanimated@3.12.1": {
213213
"licenses": "MIT",
214214
"repository": "https://github.com/software-mansion/react-native-reanimated",
215215
"licenseUrl": "https://github.com/software-mansion/react-native-reanimated/raw/master/LICENSE",

src/components/BaseModal.tsx

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@ import type { FC } from 'react';
22
import type { ModalProps } from 'react-native-paper';
33
import { Modal, useTheme } from 'react-native-paper';
44

5+
import { Platform } from 'react-native';
6+
7+
import { spacing } from '@/constants';
8+
59
export interface BaseModalProps extends ModalProps {
610
backgroundColor?: string;
711
disableSidePadding?: boolean;
@@ -20,7 +24,12 @@ const BaseModal: FC<BaseModalProps> = ({
2024
return (
2125
<Modal
2226
{...rest}
23-
style={{ backgroundColor: visible ? 'rgba(0, 0, 0, 0.5)' : undefined }}
27+
style={{
28+
...(Platform.OS !== 'android'
29+
? { height: '100%', paddingBottom: spacing * 10 }
30+
: {}),
31+
backgroundColor: visible ? 'rgba(0, 0, 0, 0.5)' : undefined,
32+
}}
2433
contentContainerStyle={{
2534
backgroundColor: backgroundColor ?? theme.colors.elevation.level4,
2635
...(disableSidePadding

0 commit comments

Comments
 (0)