Skip to content

Commit 43620ba

Browse files
committed
test: create-template --no-deprecated-fields breaks with $ref - failing test case
#185 (comment)
1 parent 1edf755 commit 43620ba

File tree

7 files changed

+42
-1
lines changed

7 files changed

+42
-1
lines changed

.gitignore

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,10 @@ examples/create-template/deprecated-yes/actual
1818
examples/create-template/deprecated-yes/actual.*
1919
examples/create-template/deprecated-no/actual
2020
examples/create-template/deprecated-no/actual.*
21+
examples/create-template/deprecated-yes-ref/actual
22+
examples/create-template/deprecated-yes-ref/actual.*
23+
examples/create-template/deprecated-no-ref/actual
24+
examples/create-template/deprecated-no-ref/actual.*
2125
examples/create-template/refs/actual
2226
examples/create-template/refs/actual.*
2327
examples/create-template/truncation-length/actual
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
$ flatten-tool create-template --no-deprecated-fields --use-titles --main-sheet-name=interviewee --schema=examples/create-template/deprecated-ref.schema -f csv -o examples/create-template/deprecated-no-ref/actual
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Identifier,Name
Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
1+
{
2+
"$schema": "http://json-schema.org/draft-04/schema#",
3+
"definitions": {
4+
"Pet": {
5+
"type": "object",
6+
"properties": {
7+
"name": {
8+
"type": "string",
9+
"title": "Pet name"
10+
}
11+
}
12+
}
13+
},
14+
"type": "object",
15+
"properties": {
16+
"id": {
17+
"type": "string",
18+
"title": "Identifier"
19+
},
20+
"name": {
21+
"type": "string",
22+
"title": "Name"
23+
},
24+
"pet": {
25+
"type": "string",
26+
"title": "Pet",
27+
"$ref": "#/definitions/Pet",
28+
"deprecated": {
29+
"description": "So yeah, H.R. told us that asking people in job interviews if they have pets is super illegal. Better stop that."
30+
}
31+
}
32+
}
33+
}
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
$ flatten-tool create-template --use-titles --main-sheet-name=interviewee --schema=examples/create-template/deprecated-ref.schema -f csv -o examples/create-template/deprecated-yes-ref/actual
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Identifier,Name,Pet:Pet name

flattentool/tests/test_docs.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ def test_example_in_doc(root, filename):
133133

134134

135135
def test_expected_number_of_examples_in_docs_data():
136-
assert len(examples_in_docs_data) == 59
136+
assert len(examples_in_docs_data) == 61
137137

138138

139139
def _simplify_warnings(lines):

0 commit comments

Comments
 (0)