Merge branch 'main' into personal/razbenhemo/input_report_read

Author: jerrysxie

Cargo.toml

@@ -28,6 +28,20 @@ repository = "https://github.com/OpenDevicePartnership/embedded-services"
 [workspace.lints.rust]
 warnings = "deny"
 
+[workspace.lints.clippy]
+correctness = "deny"
+expect_used = "deny"
+indexing_slicing = "deny"
+panic = "deny"
+panic_in_result_fn = "deny"
+perf = "deny"
+suspicious = "deny"
+style = "deny"
+todo = "deny"
+unimplemented = "deny"
+unreachable = "deny"
+unwrap_used = "deny"
+
 [workspace.dependencies]
 aligned = "0.4"
 anyhow = "1.0"

debug-service/src/lib.rs

@@ -1,4 +1,8 @@
 #![no_std]
+#![allow(clippy::expect_used)]
+#![allow(clippy::indexing_slicing)]
+#![allow(clippy::unwrap_used)]
+
 mod debug_service;
 mod defmt_ring_logger;
 pub mod task;

deny.toml

@@ -77,6 +77,7 @@ ignore = [
     { id = "RUSTSEC-2024-0370", reason = "proc-macro-error is unmaintained, no safe upgrade available, need upstream dependencies to migrate away from it." },
     { id = "RUSTSEC-2024-0436", reason = "there are no suitable replacements for paste right now; paste has been archived as read-only. It only affects compile time concatenation in macros. We will allow it for now" },
     { id = "RUSTSEC-2023-0089", reason = "this is a deprecation warning for a dependency of a dependency. https://github.com/jamesmunns/postcard/issues/223 tracks fixing the dependency; until that's resolved, we can accept the deprecated code as it has no known vulnerabilities." },
+    { id = "RUSTSEC-2025-0141", reason = "bincode is unmaintained, planning on migrating to an alternative." },
 ]
 # If this is true, then cargo deny will use the git executable to fetch advisory database.
 # If this is false, then it uses a built-in git library.

embedded-service/src/broadcaster/immediate.rs

@@ -74,6 +74,7 @@ impl<T: Clone + 'static> Immediate<T> {
 }
 
 #[cfg(test)]
+#[allow(clippy::unwrap_used)]
 mod test {
     use super::*;
     use embassy_sync::pubsub::{PubSubChannel, WaitResult};

embedded-service/src/buffer.rs

@@ -320,6 +320,7 @@ macro_rules! define_static_buffer {
 }
 
 #[cfg(test)]
+#[allow(clippy::unwrap_used)]
 mod test {
     extern crate std;
     use super::*;

embedded-service/src/ec_type/mod.rs

@@ -504,6 +504,7 @@ pub fn mem_map_to_time_alarm_msg(
 }
 
 #[cfg(test)]
+#[allow(clippy::unwrap_used)]
 mod tests {
     use super::*;
 

embedded-service/src/ec_type/protocols/mctp.rs

@@ -1341,6 +1341,7 @@ mod tests {
     }
 
     #[test]
+    #[allow(clippy::panic)]
     fn odp_header_error_on_short_buffer() {
         let header = OdpHeader {
             request_bit: false,

embedded-service/src/hid/command.rs

@@ -562,6 +562,8 @@ impl<'a> Command<'a> {
 }
 
 #[cfg(test)]
+#[allow(clippy::indexing_slicing)]
+#[allow(clippy::unwrap_used)]
 mod test {
     use super::*;
     use crate::define_static_buffer;

embedded-service/src/hid/mod.rs

@@ -350,6 +350,7 @@ pub async fn send_request(tp: &Endpoint, to: DeviceId, request: Request<'static>
 }
 
 #[cfg(test)]
+#[allow(clippy::unwrap_used)]
 mod test {
     use super::*;
 

embedded-service/src/intrusive_list.rs

@@ -414,6 +414,7 @@ mod test {
     }
 
     #[test]
+    #[allow(clippy::unwrap_used)]
     fn test_monotype_list() {
         let list_a = IntrusiveList::new();
         let list_b = IntrusiveList::new();
@@ -462,6 +463,7 @@ mod test {
     }
 
     #[test]
+    #[allow(clippy::unwrap_used)]
     fn test_multitype_list() {
         // list with multiple types within it (same registration type)
         let list_a = IntrusiveList::new();
@@ -498,6 +500,7 @@ mod test {
     }
 
     #[test]
+    #[allow(clippy::unwrap_used)]
     fn test_multi_list() {
         // nodes in multiple lists
         let list_a = IntrusiveList::new();
@@ -554,6 +557,7 @@ mod test {
     }
 
     #[test]
+    #[allow(clippy::unwrap_used)]
     fn test_multi_registration_list() {
         // list with multiple registration types
         let list = IntrusiveList::new();