Appearance Weakrefs (#1815)

Co-authored-by: amylizzle <[email protected]>
Co-authored-by: wixoaGit <[email protected]>

Author: amylizzle

Content.IntegrationTests/DMProject/Tests/icons.dmi

@@ -2,7 +2,9 @@
 	plane = 123
 	icon_state = "subclass"
 
-/proc/RunTest()
+/proc/test_images()
+	ASSERT(image('icons.dmi', "mob") != null)
+
 	var/image/test = new /image/subclass
 	ASSERT(test.plane == 123)
 	ASSERT(test.icon_state == "subclass")

….Tests/DMProject/Tests/Image/subclass.dm …ntegrationTests/DMProject/Tests/image.dmContent.Tests/DMProject/Tests/Image/subclass.dm renamed to Content.IntegrationTests/DMProject/Tests/image.dm Content.Tests/DMProject/Tests/Image/subclass.dm renamed to Content.IntegrationTests/DMProject/Tests/image.dm

@@ -10,6 +10,6 @@
 		out += dir
 		ASSERT(out == 14)
 
-/proc/RunTest()
+/proc/test_nonlocal_var()
 	var/mob/m = new
 	m.dodir()

…ect/Tests/Statements/For/nonlocal_var.dm …ionTests/DMProject/Tests/nonlocal_var.dmContent.Tests/DMProject/Tests/Statements/For/nonlocal_var.dm renamed to Content.IntegrationTests/DMProject/Tests/nonlocal_var.dm Content.Tests/DMProject/Tests/Statements/For/nonlocal_var.dm renamed to Content.IntegrationTests/DMProject/Tests/nonlocal_var.dm

@@ -30,5 +30,7 @@
 	test_color_matrix()
 	test_range()
 	test_verb_duplicate()
+	test_nonlocal_var()
+	test_images()
 	test_filter_init()
 	world.log << "IntegrationTests successful, /world/New() exiting..."

Content.IntegrationTests/DMProject/code.dm

@@ -3,6 +3,8 @@
 #include "Tests/color_matrix.dm"
 #include "Tests/range.dm"
 #include "Tests/verb_duplicate.dm"
+#include "Tests/nonlocal_var.dm"
+#include "Tests/image.dm"
 #include "Tests/filter_initial.dm"
 #include "map.dmm"
 #include "interface.dmf"

Content.IntegrationTests/DMProject/environment.dme

@@ -1,8 +1,9 @@
-/obj/savetest
-	var/obj/savetest/recurse = null
+/datum/savetest
+	var/name
+	var/datum/savetest/recurse = null
 
 /proc/RunTest()
-	var/obj/savetest/O = new() //create a test object
+	var/datum/savetest/O = new() //create a test object
 	O.name = "test"
 	//O.recurse = O //TODO
 

Content.Tests/DMProject/Tests/Image/Image.dm

@@ -26,9 +26,9 @@ public void InitializeAtoms(List<DreamMapJson>? maps) { }
 
     public void SetTurf(DreamObjectTurf turf, DreamObjectDefinition type, DreamProcArguments creationArguments) { }
 
-    public void SetTurfAppearance(DreamObjectTurf turf, IconAppearance appearance) { }
+    public void SetTurfAppearance(DreamObjectTurf turf, MutableAppearance appearance) { }
 
-    public void SetAreaAppearance(DreamObjectArea area, IconAppearance appearance) { }
+    public void SetAreaAppearance(DreamObjectArea area, MutableAppearance appearance) { }
 
     public void SetArea(DreamObjectTurf turf, DreamObjectArea area) { }
 

Content.Tests/DMProject/Tests/Savefile/ExportText.dm

@@ -1,7 +1,7 @@
 /image
 	parent_type = /datum
 
-	//note these values also need to be set in IconAppearance.cs
+	//note these values also need to be set in MutableAppearance.cs
 	var/alpha = 255
 	var/appearance
 	var/appearance_flags = 0

Content.Tests/DummyDreamMapManager.cs

@@ -85,6 +85,7 @@ public override void PostInit() {
         IoCManager.Resolve<IDreamSoundEngine>().Initialize();
 
         _netManager.RegisterNetMessage<MsgAllAppearances>(RxAllAppearances);
+        _netManager.RegisterNetMessage<MsgNewAppearance>(RxNewAppearance);
 
         if (_configurationManager.GetCVar(CVars.DisplayCompat))
             _dreamInterface.OpenAlert(
@@ -112,6 +113,15 @@ private void RxAllAppearances(MsgAllAppearances message) {
         clientAppearanceSystem.SetAllAppearances(message.AllAppearances);
     }
 
+    private void RxNewAppearance(MsgNewAppearance message) {
+        if (!_entitySystemManager.TryGetEntitySystem<ClientAppearanceSystem>(out var clientAppearanceSystem)) {
+            Logger.GetSawmill("opendream").Error("Received MsgNewAppearance before initializing entity systems");
+            return;
+        }
+
+        clientAppearanceSystem.OnNewAppearance(message);
+    }
+
     // As of RobustToolbox v0.90.0.0 there's a TileEdgeOverlay that breaks our rendering
     // because we don't have an ITileDefinition for each tile.
     // This removes that overlay immediately after MapSystem adds it.