Fix for(var/V in list) for special lists (#2368)

Author: wixoaGit

OpenDreamRuntime/AtomManager.cs

@@ -385,7 +385,7 @@ public void SetAppearanceVar(MutableAppearance appearance, string varName, Dream
                 appearance.Verbs.Clear();
 
                 if (value.TryGetValueAsDreamList(out var valueList)) {
-                    foreach (DreamValue verbValue in valueList.GetValues()) {
+                    foreach (DreamValue verbValue in valueList.EnumerateValues()) {
                         if (!verbValue.TryGetValueAsProc(out var verb))
                             continue;
 

OpenDreamRuntime/ByondApi/ByondApi.Functions.cs

@@ -303,16 +303,19 @@ private static byte Byond_ReadList(CByondValue* loc, CByondValue* list, uint* le
                 return 0;
             }
 
-            var srcDreamVals = srcList.GetValues();
-            int length = srcDreamVals.Count;
+            int length = srcList.GetLength();
             *len = (uint)length;
             if (list == null || providedBufLen < length) {
                 return 0;
             }
 
             try {
-                for (int i = 0; i < length; i++) {
-                    list[i] = ValueToByondApi(srcDreamVals[i]);
+                int i = 0;
+                foreach (var value in srcList.EnumerateValues()) {
+                    if (i >= length)
+                        throw new Exception($"List {srcList} had more elements than the expected {length}");
+
+                    list[i++] = ValueToByondApi(value);
                 }
             } catch (Exception) {
                 return 0;
@@ -706,7 +709,7 @@ private static byte Byond_Block(CByondXYZ* corner1, CByondXYZ* corner2, CByondVa
                     corner1->x, corner1->y, corner1->z,
                     corner2->x, corner2->y, corner2->z);
 
-                foreach (var turf in turfs.GetValues()) {
+                foreach (var turf in turfs.EnumerateValues()) {
                     list.Add(ValueToByondApi(turf));
                 }
             } catch (Exception) {
@@ -879,15 +882,10 @@ private static byte Byond_NewArglist(CByondValue* cType, CByondValue* cArglist,
                 var objectDef = treeEntry.ObjectDefinition;
 
                 var arglistVal = ValueFromDreamApi(*cArglist);
-                if (!arglistVal.TryGetValueAsDreamList(out DreamList? arglist)) return 0;
+                if (!arglistVal.TryGetValueAsIDreamList(out var arglist)) return 0;
 
                 // Copy the arglist's values to a new array to ensure no shenanigans
-                var argListValues = arglist.GetValues();
-                var argValues = new DreamValue[argListValues.Count];
-                for (int i = 0; i < argListValues.Count; i++) {
-                    argValues[i] = argListValues[i];
-                }
-
+                var argValues = arglist.CopyToArray();
                 var args = new DreamProcArguments(argValues);
 
                 // TODO: This is code duplicated with DMOpcodeHandlers.CreateObject()

OpenDreamRuntime/DreamConnection.cs

@@ -273,10 +273,10 @@ public Task<DreamValue> Prompt(DreamValueType types, string title, string messag
         return task;
     }
 
-    public async Task<DreamValue> PromptList(DreamValueType types, DreamList list, string title, string message, DreamValue defaultValue) {
-        List<DreamValue> listValues = list.GetValues();
+    public async Task<DreamValue> PromptList(DreamValueType types, IDreamList list, string title, string message, DreamValue defaultValue) {
+        DreamValue[] listValues = list.CopyToArray();
 
-        List<string> promptValues = new(listValues.Count);
+        List<string> promptValues = new(listValues.Length);
         foreach (var value in listValues) {
             if (types.HasFlag(DreamValueType.Obj) && !value.TryGetValueAsDreamObject<DreamObjectMovable>(out _))
                 continue;
@@ -307,7 +307,7 @@ public async Task<DreamValue> PromptList(DreamValueType types, DreamList list, s
 
         // The client returns the index of the selected item, this needs turned back into the DreamValue.
         var selectedIndex = await task;
-        if (selectedIndex.TryGetValueAsInteger(out int index) && index < listValues.Count) {
+        if (selectedIndex.TryGetValueAsInteger(out int index) && index < listValues.Length) {
             return listValues[index];
         }