Misc builtin tests (#2388)

ike709 · ike709 · wixoaGit · web-flow · commit 545cd48f2cd1 · 2025-09-06T18:49:10.000Z
Co-authored-by: ike709 &lt;ike709@github.com&gt;
Co-authored-by: wixoa &lt;wixoag@gmail.com&gt;
diff --git a/Content.Tests/DMProject/Tests/Builtins/astype.dm b/Content.Tests/DMProject/Tests/Builtins/astype.dm
@@ -7,12 +7,25 @@
 	var/datum/foo/bar/B = astype(D)
 	return isnull(B)
 
+/proc/test_null2()
+	var/datum/D = new
+	var/datum/foo/bar/B = astype(D, /datum/foo/bar)
+	return isnull(B)
+
 /proc/test_type()
 	var/datum/foo/bar/B = new
 	var/datum/D = astype(B)
 	var/datum/foo/F = astype(D)
 	return F.type
 
+/proc/test_type2()
+	var/datum/foo/bar/B = new
+	var/datum/D = astype(B, /datum)
+	var/datum/foo/F = astype(D, /datum/foo)
+	return F.type
+
 /proc/RunTest()
 	ASSERT(test_null())
+	ASSERT(test_null2())
 	ASSERT(test_type() == /datum/foo/bar)
+	ASSERT(test_type2() == /datum/foo/bar)
diff --git a/Content.Tests/DMProject/Tests/Builtins/locate_inferred1.dm b/Content.Tests/DMProject/Tests/Builtins/locate_inferred1.dm
@@ -0,0 +1,4 @@
+/datum/foo
+/proc/RunTest()
+	var/datum/foo/F = locate()
+	ASSERT(isnull(F))
diff --git a/Content.Tests/DMProject/Tests/Builtins/locate_inferred2.dm b/Content.Tests/DMProject/Tests/Builtins/locate_inferred2.dm
@@ -0,0 +1,4 @@
+// COMPILE ERROR OD0404
+
+/proc/RunTest()
+	var/datum/foo/F = locate()
diff --git a/Content.Tests/DMProject/Tests/Builtins/rgb/rgb.dm b/Content.Tests/DMProject/Tests/Builtins/rgb/rgb.dm
diff --git a/Content.Tests/DMProject/Tests/Builtins/rgb/rgb2num.dm b/Content.Tests/DMProject/Tests/Builtins/rgb/rgb2num.dm
diff --git a/Content.Tests/DMProject/Tests/Builtins/rgb/rgb_args1.dm b/Content.Tests/DMProject/Tests/Builtins/rgb/rgb_args1.dm
@@ -0,0 +1,3 @@
+// COMPILE ERROR OD0013
+/proc/RunTest()
+	rgb(1,2)
diff --git a/Content.Tests/DMProject/Tests/Builtins/rgb/rgb_args2.dm b/Content.Tests/DMProject/Tests/Builtins/rgb/rgb_args2.dm
@@ -0,0 +1,3 @@
+// COMPILE ERROR OD0013
+/proc/RunTest()
+	rgb(1,2,3,4,5,6)
diff --git a/Content.Tests/DMProject/Tests/Builtins/rgb/rgb_args3.dm b/Content.Tests/DMProject/Tests/Builtins/rgb/rgb_args3.dm
@@ -0,0 +1,5 @@
+// COMPILE ERROR OD2208
+#pragma FallbackBuiltinArgument error
+/datum/foo/var/bar = rgb(1,2,null)
+/proc/RunTest()
+	return
diff --git a/Content.Tests/DMProject/Tests/Expression/weighted_pick2.dm b/Content.Tests/DMProject/Tests/Expression/weighted_pick2.dm
@@ -0,0 +1,3 @@
+// COMPILE ERROR OD0013
+/proc/RunTest()
+	var/a = pick(prob(50);1)
diff --git a/Content.Tests/DMProject/Tests/SpecialProcs/issaved/issaved_local.dm b/Content.Tests/DMProject/Tests/SpecialProcs/issaved/issaved_local.dm
@@ -0,0 +1,3 @@
+/proc/RunTest()
+	var/foo = 1
+	ASSERT(issaved(foo) == FALSE)
diff --git a/DMCompiler/DM/Expressions/Builtins.cs b/DMCompiler/DM/Expressions/Builtins.cs
@@ -109,7 +109,8 @@ internal sealed class LocateInferred(Location location, DreamPath path, DMExpres
     public override void EmitPushValue(ExpressionContext ctx) {
         if (!ctx.ObjectTree.TryGetTypeId(path, out var typeId)) {
             ctx.Compiler.Emit(WarningCode.ItemDoesntExist, Location, $"Type {path} does not exist");
-
+            ctx.Proc.PushNull(); // prevents a negative stack size error
+            ctx.Proc.Error();
             return;
         }
 
@@ -257,7 +258,7 @@ public override void EmitPushValue(ExpressionContext ctx) {
 
         if (weighted) {
             if (values.Length == 1) {
-                ctx.Compiler.ForcedWarning(Location, "Weighted pick() with one argument");
+                ctx.Compiler.Emit(WarningCode.InvalidArgumentCount, Location, "Weighted pick() with one argument"); // BYOND errors with "extra args"
             }
 
             ctx.Compiler.Emit(WarningCode.PickWeightedSyntax, Location, "Use of weighted pick() syntax");

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+// COMPILE ERROR OD0013`
	`2`	`+/proc/RunTest()`
	`3`	`+ rgb(1,2)`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+/proc/RunTest()`
	`2`	`+ var/foo = 1`
	`3`	`+ ASSERT(issaved(foo) == FALSE)`