Reintstate the TGS test with a retry handler this time (#2267)

Author: Cyberboss

.github/workflows/rerun-flaky-tests.yml

@@ -0,0 +1,21 @@
+name: Rerun Flaky Tests
+on:
+  workflow_run:
+    workflows: ["Test tgstation-server Integration"]
+    types:
+      - completed
+jobs:
+  rerun_flaky_tests:
+    name: Rerun Flaky Tests
+    runs-on: ubuntu-latest
+    if: ${{ github.event.workflow_run.conclusion == 'failure' && github.event.workflow_run.run_attempt < 5 }}
+    steps:
+      - name: Rerun Flaky Tests
+        uses: actions/github-script@v7
+        with:
+          script: |
+            await github.rest.actions.reRunWorkflowFailedJobs({
+                owner: context.repo.owner,
+                repo: context.repo.repo,
+                run_id: context.payload.workflow_run.id,
+            });

.github/workflows/test-tgs.yml

@@ -0,0 +1,91 @@
+name: Test tgstation-server Integration
+
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+    branches: [ master ]
+
+concurrency:
+  group: "tgs-${{ github.head_ref || github.run_id }}-${{ github.event_name }}"
+  cancel-in-progress: true
+
+env:
+  OD_DOTNET_VERSION: 9
+  TGS_DOTNET_VERSION: 8
+  TGS_NODE_VERSION: 20.x
+  TGS_REFERENCE: dev
+  TGS_TEST_GITHUB_TOKEN: ${{ github.token }}
+
+jobs:
+  build:
+    strategy:
+      fail-fast: false
+      matrix:
+        os: [ ubuntu-latest, windows-latest ]
+    runs-on: ${{ matrix.os }}
+    steps:
+    - name: Disable ptrace_scope
+      if: matrix.os == 'ubuntu-latest'
+      run: echo 0 | sudo tee /proc/sys/kernel/yama/ptrace_scope
+
+    - name: Install gdb and libgdiplus
+      if: matrix.os == 'ubuntu-latest'
+      run: |
+        sudo apt-get update
+        sudo apt-get install -y gdb libgdiplus
+
+    - name: Setup dotnet
+      uses: actions/setup-dotnet@v4
+      with:
+        dotnet-version: |
+          ${{ env.TGS_DOTNET_VERSION }}.0.x
+          ${{ env.OD_DOTNET_VERSION }}.0.x
+
+    - name: Setup Node.JS
+      uses: actions/setup-node@v4
+      with:
+        node-version: ${{ env.TGS_NODE_VERSION }}
+
+    - name: Enable Corepack
+      run: corepack enable
+
+    - name: Checkout OpenDream
+      uses: actions/checkout@v4
+      with:
+        fetch-depth: 0
+        fetch-tags: true
+        submodules: true
+
+    - name: Pull engine updates
+      uses: space-wizards/submodule-dependency@v0.1.5
+
+    - name: Update Engine Submodules
+      run: |
+        cd RobustToolbox/
+        git submodule update --init --recursive
+    
+    - name: Checkout TGS
+      run: |
+        cd ..
+        git clone https://github.com/tgstation/tgstation-server --depth 1 --branch ${{ env.TGS_REFERENCE }}
+
+    - name: Build TGS Integration Tests
+      env:
+        TGS_TELEMETRY_KEY_FILE: fake.txt
+      shell: bash
+      run: |
+        cd ../tgstation-server
+        echo "fake" > src/Tgstation.Server.Host/${{ env.TGS_TELEMETRY_KEY_FILE }}
+        dotnet build -c ReleaseNoWindows -p:TGS_HOST_NO_WEBPANEL=true tests/Tgstation.Server.Tests/Tgstation.Server.Tests.csproj
+
+    - name: Run TGS OpenDream Tests
+      shell: bash
+      run: |
+        cd ../tgstation-server/tests/Tgstation.Server.Tests
+        export TGS_TEST_OD_EXCLUSIVE=true
+        export TGS_TEST_OD_ENGINE_VERSION=$GITHUB_SHA
+        export TGS_TEST_OD_GIT_DIRECTORY="../../../../../../${{ github.event.repository.name }}"
+        export TGS_TEST_DATABASE_TYPE=Sqlite
+        export TGS_TEST_CONNECTION_STRING="Data Source=TGS.sqlite3;Mode=ReadWriteCreate"
+        dotnet test -c ReleaseNoWindows --no-build --filter Name=TestOpenDreamExclusiveTgsOperation --logger "GitHubActions;summary.includePassedTests=true;summary.includeSkippedTests=true" --settings ../../build/ci.runsettings --results-directory ../../TestResults

OpenDreamRuntime/DreamManager.cs

@@ -71,7 +71,9 @@ public sealed partial class DreamManager {
     //TODO This arg is awful and temporary until RT supports cvar overrides in unit tests
     public void PreInitialize(string? jsonPath) {
         _sawmill = Logger.GetSawmill("opendream");
+#if !DISABLE_BYOND_API
         ByondApi.ByondApi.Initialize(this, _atomManager, _dreamMapManager, _objectTree);
+#endif
 
         InitializeConnectionManager();
         _dreamResourceManager.PreInitialize();

OpenDreamRuntime/OpenDreamRuntime.csproj

@@ -6,6 +6,9 @@
     <Configurations>Debug;Release;Tools</Configurations>
     <Platforms>AnyCPU</Platforms>
   </PropertyGroup>
+  <PropertyGroup Condition="'$(TgsEngineBuild)'=='True'">
+    <DefineConstants>$(DefineConstants);DISABLE_BYOND_API</DefineConstants>
+  </PropertyGroup>
   <ItemGroup>
     <ProjectReference Include="..\DMCompiler\DMCompiler.csproj" />
     <ProjectReference Include="..\OpenDreamPackaging\OpenDreamPackaging.csproj" />

OpenDreamRuntime/Procs/DMOpcodeHandlers.CallExt.cs

@@ -38,6 +38,9 @@ private static unsafe ProcStatus CallExtByond(
         DreamProcArguments arguments) {
         // TODO: Don't allocate string copy
         // TODO: Handle stdcall (do we care?)
+#if DISABLE_BYOND_API
+        throw new Exception("Server was not compiled with BYOND API support!");
+#else
         var entryPoint = (delegate* unmanaged[Cdecl]<uint, ByondApi.CByondValue*, ByondApi.CByondValue>)
             DllHelper.ResolveDllTarget(state.Proc.DreamResourceManager, dllName, procName["byond:".Length..]);
 
@@ -53,6 +56,7 @@ private static unsafe ProcStatus CallExtByond(
 
         state.Push(Api.ValueFromDreamApi(result));
         return ProcStatus.Continue;
+#endif
     }
 
     private static unsafe ProcStatus CallExtString(