refresh client verbs on timer instead of on appearance update

Author: Ruzihm

OpenDreamClient/Rendering/ClientAppearanceSystem.cs

@@ -11,6 +11,8 @@
 using Robust.Client.Player;
 using Robust.Shared.Map;
 using Robust.Shared.Timing;
+using Robust.Shared.Asynchronous;
+using System.Threading.Tasks;
 
 namespace OpenDreamClient.Rendering;
 
@@ -56,6 +58,7 @@ public int GetAnimationFrame(IGameTiming gameTiming) {
     private readonly Dictionary<(int X, int Y, int Z), Flick> _turfFlicks = new();
     private readonly Dictionary<EntityUid, Flick> _movableFlicks = new();
     private bool _receivedAllAppearancesMsg;
+    private readonly float timeToRefreshVerbs = 3f;
 
     [Dependency] private readonly IEntityManager _entityManager = default!;
     [Dependency] private readonly IDreamResourceManager _dreamResourceManager = default!;
@@ -69,6 +72,7 @@ public int GetAnimationFrame(IGameTiming gameTiming) {
     [Dependency] private readonly MapSystem _mapSystem = default!;
     [Dependency] private readonly IPrototypeManager _protoManager = default!;
     [Dependency] private readonly ClientVerbSystem _verbSystem = default!;
+    [Dependency] private readonly ITaskManager _taskManager = default!;
 
     public override void Initialize() {
         UpdatesOutsidePrediction = true;
@@ -78,6 +82,8 @@ public override void Initialize() {
         SubscribeNetworkEvent<AnimationEvent>(OnAnimation);
         SubscribeNetworkEvent<FlickEvent>(OnFlick);
         SubscribeLocalEvent<DMISpriteComponent, WorldAABBEvent>(OnWorldAABB);
+
+        _ = StartVerbRefresher();
     }
 
     public override void Shutdown() {
@@ -365,7 +371,10 @@ public string GetName(ClientObjectReference reference) {
         return _movableFlicks.GetValueOrDefault(entity);
     }
 
-    public void RefreshVerbs() {
-        _verbSystem.RefreshVerbs();
+    private async Task StartVerbRefresher() {
+        while (true) {
+            await Task.Delay(TimeSpan.FromSeconds(timeToRefreshVerbs));
+            _taskManager.RunOnMainThread(_verbSystem.RefreshVerbs);
+        }
     }
 }

OpenDreamClient/Rendering/DreamIcon.cs

@@ -147,7 +147,6 @@ public void SetAppearance(uint? appearanceId, AtomDirection? parentDir = null) {
             }
 
             Appearance = appearance;
-            appearanceSystem.RefreshVerbs();
         });
     }