prune formatting when outputting (#2491)

Author: Ruzihm

OpenDreamRuntime/DreamConnection.cs

@@ -1,5 +1,6 @@
 using System.Threading.Tasks;
 using System.Web;
+using DMCompiler.Bytecode;
 using OpenDreamRuntime.Objects;
 using OpenDreamRuntime.Objects.Types;
 using OpenDreamRuntime.Procs.Native;
@@ -282,7 +283,11 @@ public void OutputDreamValue(DreamValue value) {
             return;
         }
 
-        OutputControl(value.Stringify(), null);
+        // Prune any remaining formatting
+        var message = value.Stringify();
+        message = StringFormatEncoder.RemoveFormatting(message);
+
+        OutputControl(message, null);
     }
 
     public void OutputControl(string message, string? control) {

OpenDreamRuntime/Resources/ConsoleOutputResource.cs

@@ -1,3 +1,4 @@
+using DMCompiler.Bytecode;
 using OpenDreamRuntime.Procs.DebugAdapter;
 
 namespace OpenDreamRuntime.Resources;
@@ -19,6 +20,10 @@ public void WriteConsole(LogLevel logLevel, string sawmill, string message) {
     }
 
     public override void Output(DreamValue value) {
-        WriteConsole(LogLevel.Info, "world.log", value.Stringify());
+        // Prune any remaining formatting
+        var message = value.Stringify();
+        message = StringFormatEncoder.RemoveFormatting(message);
+
+        WriteConsole(LogLevel.Info, "world.log", message);
     }
 }

OpenDreamRuntime/Resources/DreamResource.cs

@@ -1,4 +1,5 @@
 using System.IO;
+using DMCompiler.Bytecode;
 using System.Runtime.CompilerServices;
 using System.Text;
 
@@ -78,6 +79,9 @@ public virtual void Output(DreamValue value) {
             throw new Exception($"Invalid output operation '{ResourcePath}' << {value}");
         }
 
+        // Prune any remaining formatting
+        text = StringFormatEncoder.RemoveFormatting(text);
+
         CreateDirectory();
         File.AppendAllText(ResourcePath, text + "\r\n");
         _resourceDataBacking = null;