Fixes self-closing html tag check, interprets br as newline (#2482)

Author: Ruzihm

OpenDreamClient/Interface/Html/HtmlParser.cs

@@ -71,7 +71,17 @@ void PushCurrentText() {
                     string tagType = attributes[0].ToLowerInvariant();
 
                     currentText.Clear();
+
                     bool isSelfClosing = IsSelfClosing(tagType, attributes);
+
+                    // remove self-closing slash if attached to tagType
+                    tagType = tagType.TrimEnd('/');
+
+                    // remove self-closing slash at end of attributes, if present
+                    if (attributes.Length > 0) {
+                        attributes[^1] = attributes[^1].TrimEnd('/');
+                    }
+
                     if (closingTag) {
                         if (isSelfClosing) {
                             // ignore closing tags of void elements since they don't
@@ -92,7 +102,11 @@ void PushCurrentText() {
                             tags.Push(tagType);
                         }
 
-                        appendTo.PushTag(new MarkupNode(tagType, null, ParseAttributes(attributes)), selfClosing: isSelfClosing);
+                        if (tagType == "br") {
+                            appendTo.PushNewline();
+                        } else {
+                            appendTo.PushTag(new MarkupNode(tagType, null, ParseAttributes(attributes)), selfClosing: isSelfClosing);
+                        }
                     }
 
                     break;
@@ -166,7 +180,7 @@ void PushCurrentText() {
      * </summary>
      */
     private static bool IsSelfClosing(string tagType, string[] attributes) {
-        if (attributes[^1] == "/") {
+        if (tagType.EndsWith("/") || attributes[^1].EndsWith("/")) {
             return true;
         }
 
@@ -197,7 +211,8 @@ private static Dictionary<string, MarkupParameter> ParseAttributes(string[] attr
 
         for (int i = 1; i < attributes.Length; i++) { // First one should be the tag type, skip it
             string attribute = attributes[i];
-            if (attribute == "/")
+
+            if (attribute == "") // tag ended with a detached self-closing slash
                 continue;
 
             int equalsIndex = attribute.IndexOf('=');